Re: Help with ticket #28426

2021-03-04 Thread Tom Forbes
Personally I don’t think we should prompt the user for anything. If the user gives the username and password in the url (user:pass@host) then we can use that, otherwise we just throw an error. A more complicated solution involving making a request, detecting a 401, prompting the user and retry

Re: Help with ticket #28426

2021-03-04 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I also think this is feature creep and if it's a complicated change it's not worth it. On Thu, 4 Mar 2021 at 18:36, Tim Graham wrote: > I'd like to see what your code looks like so far. Personally, this is > sounding a lot more complicated than I imagined when I accepted the ticket. > I doubt th

Re: Help with ticket #28426

2021-03-04 Thread Bence Gáspár
My solution for the basic auth problem would be something like this Tim Graham ezt írta (időpont: 2021. márc. 4., Cs, 19:36): > I'd like to see what your code looks like so far. Personally, this is > sounding a lot more complicated than I imagined when I accepted the ticket. > I doubt this is a

Re: Help with ticket #28426

2021-03-04 Thread Tim Graham
I'd like to see what your code looks like so far. Personally, this is sounding a lot more complicated than I imagined when I accepted the ticket. I doubt this is a highly requested feature that couldn't be solved another way (e.g. downloading the template file without Django), and It's not clear

Re: Help with ticket #28426

2021-03-04 Thread Bence Gáspár
Thanks for the fast reply I found these test cases but I am not sure how to extend them with basic auth, because I don't know if the *LiveServerTestCase *is capable of doing basic auth. As I see currently there is no testcase checking basic auth here and it has to be checked by hand. I am sorry b

Re: Help with ticket #28426

2021-03-04 Thread Carlton Gibson
Hi Bence, welcome! There are already a couple of tests in place to check the remove fetching: https://github.com/django/django/blob/05bbff82638731a6abfed2fe0ae06a4d429cb32f/tests/admin_scripts/tests.py#L2047-L2072 Without changing the command code I'd first add view (in admin_scripts/urls.py

Help with ticket #28426

2021-03-03 Thread Bence Gáspár
Hi, I would like to work on this ticket https://code.djangoproject.com/ticket/28426. I am fairly new in the community and to Django development as well but this ticket seems not so Django specific and I am confident I can implement it. I have done some research already and found that we need to im