Re: Mechanics of the EmailValidator.domain_allowlist rename.

2020-06-18 Thread Carlton Gibson
OK, thanks both — perhaps we're worrying too much. > For example, the get_query_set -> get_queryset rename... I'd managed to suppress that memory.  C. On Thursday, 18 June 2020 19:05:54 UTC+2, Adam Johnson wrote: > > I also lean towards #1. > > I doubt many third party packages use the

Re: Mechanics of the EmailValidator.domain_allowlist rename.

2020-06-18 Thread Adam Johnson
I also lean towards #1. I doubt many third party packages use the argument since it seems quite site specific. I scrolled through 5 random-ish pages of github code search for "domain_whitelist" in python files and found nothing that looked like a django related usage. On Thu, 18 Jun 2020 at

Re: Mechanics of the EmailValidator.domain_allowlist rename.

2020-06-18 Thread Matthias Kestenholz
Hi I have survived a few changes in Django over the last >10 years, and this change is absolutely not comparable to any of the problematic ones. For example, the get_query_set -> get_queryset rename was hard because it was unclear how to properly support subclassing querysets. The on_delete

Mechanics of the EmailValidator.domain_allowlist rename.

2020-06-18 Thread Carlton Gibson
Hi All, We merged the docs changes remove whitelisted last week. https://github.com/django/django/pull/13031 There's a PR now ready to adjust EmailValidator to use domain_allowlist. https://github.com/django/django/pull/13079/ This is all fine *except* it will require editing any historical