Performance-related fixes [was: Ping: Extend "for" tag to allow unpacking of lists]

2007-06-10 Thread Jacob Kaplan-Moss
On 6/10/07, Brian Harring <[EMAIL PROTECTED]> wrote: > Had a nice funny rant typed up related to the general lack of code > efficiency in template code (ticket 4523 is an example) [... snip] Just a heads-up to you and anyone else who notices stuff like this: Performance is near and dear to me, a

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-10 Thread Brian Harring
On Fri, Jun 08, 2007 at 11:05:01PM -, SmileyChris wrote: > > On Jun 9, 9:32 am, Brian Harring <[EMAIL PROTECTED]> wrote: > > Realize it's hit trunk already, > No worries, we can always open another ticket :) Already watching enough tickets ;) > > but noticed an annoying potential > > gotcha

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-08 Thread SmileyChris
On Jun 9, 9:32 am, Brian Harring <[EMAIL PROTECTED]> wrote: > Realize it's hit trunk already, No worries, we can always open another ticket :) > but noticed an annoying potential > gotcha- for single var in a for loop, any changes to the context stay > put- for multiple vars, the context gets wip

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-08 Thread Brian Harring
On Thu, Jun 07, 2007 at 09:53:07PM +0800, Russell Keith-Magee wrote: > > On 6/6/07, SmileyChris <[EMAIL PROTECTED]> wrote: > > > > New patch uploaded, taking into account Brian's thoughts (and fixing a > > small bug): > > > > http://code.djangoproject.com/ticket/3523#comment:11 > > Ok; I've had a

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-07 Thread SmileyChris
On Jun 8, 12:57 pm, "Michael Trier" <[EMAIL PROTECTED]> wrote: > This looks really cool. Thanks SmileyChris. And Honza for the initial work on this ticket :) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-07 Thread Michael Trier
This looks really cool. Thanks SmileyChris. Michael On 6/7/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > On 6/7/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > > On 6/7/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > > Unless there are any objections, I'm happy to check this into

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-07 Thread Adrian Holovaty
On 6/7/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > On 6/7/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > Unless there are any objections, I'm happy to check this into trunk. > > Meh, I'm barely +0, but don't let my apathy stop you :) +0 from me, too. Go for it, if you'd like. Adri

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-07 Thread Jacob Kaplan-Moss
On 6/7/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > Unless there are any objections, I'm happy to check this into trunk. Meh, I'm barely +0, but don't let my apathy stop you :) Jacob --~--~-~--~~~---~--~~ You received this message because you are subscrib

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-07 Thread Russell Keith-Magee
On 6/6/07, SmileyChris <[EMAIL PROTECTED]> wrote: > > New patch uploaded, taking into account Brian's thoughts (and fixing a > small bug): > > http://code.djangoproject.com/ticket/3523#comment:11 Ok; I've had a chance to look at this now. I've made a couple of minor modifications, mostly in docs,

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-05 Thread SmileyChris
New patch uploaded, taking into account Brian's thoughts (and fixing a small bug): http://code.djangoproject.com/ticket/3523#comment:11 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-05 Thread SmileyChris
On Jun 5, 11:48 pm, Brian Harring <[EMAIL PROTECTED]> wrote: > Comments on the patch/syntax at least; Offhand, test > 'for-tag-unpack03' points out some uglyness in the api- > > {% for key value in items %} > {{ key }}:{{ value }}/ > {% endfor %} Regarding the whole comma/space issue, t

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-05 Thread Brian Harring
Personally, I'd like the patch to go in; the support is far easier on the eyes reading wise, and it has the nice side affect of speeding up the access- index access is last in the chain for var resolution, meaning several pricey exceptions/tests occur every access. Faster resolution, and cleane

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-05 Thread Russell Keith-Magee
On 6/5/07, David Larlet <[EMAIL PROTECTED]> wrote: > > 2007/6/5, SmileyChris <[EMAIL PROTECTED]>: > > > > Ticket http://code.djangoproject.com/ticket/3523 has been sitting > > quietly for a couple of months as a design decision and it's a > > reasonably common question in the IRC channel so I thou

Re: Ping: Extend "for" tag to allow unpacking of lists

2007-06-05 Thread David Larlet
2007/6/5, SmileyChris <[EMAIL PROTECTED]>: > > Ticket http://code.djangoproject.com/ticket/3523 has been sitting > quietly for a couple of months as a design decision and it's a > reasonably common question in the IRC channel so I thought I'd ask a > core developer for a decision. > I'm not a cor

Ping: Extend "for" tag to allow unpacking of lists

2007-06-04 Thread SmileyChris
Ticket http://code.djangoproject.com/ticket/3523 has been sitting quietly for a couple of months as a design decision and it's a reasonably common question in the IRC channel so I thought I'd ask a core developer for a decision. The ticket itself relies on a change to context.update, which is pro