Re: Critical ticket: can cause data loss

2007-01-30 Thread David Larlet
2007/1/30, Russell Keith-Magee <[EMAIL PROTECTED]>: > > On 1/30/07, David Larlet <[EMAIL PROTECTED]> wrote: > > I'm +1 on this option. Before making decision what about at least add > > a warning message on the documentation page? > > This is kind of the point. Which documentation page? Generic

Re: Critical ticket: can cause data loss

2007-01-29 Thread Matthew Flanagan
On 30/01/07, James Bennett <[EMAIL PROTECTED]> wrote: > > On 1/29/07, Ned Batchelder <[EMAIL PROTECTED]> wrote: > > I don't know that you need to make a release for this fix, but I think you > > should alert people to it. There is a mailing list for announcing releases > > and security issues,

Re: Critical ticket: can cause data loss

2007-01-29 Thread David Larlet
2007/1/29, James Bennett <[EMAIL PROTECTED]>: > > On 1/29/07, Ned Batchelder <[EMAIL PROTECTED]> wrote: > > I don't know that you need to make a release for this fix, but I think you > > should alert people to it. There is a mailing list for announcing releases > > and security issues, right?

Re: Critical ticket: can cause data loss

2007-01-29 Thread James Bennett
On 1/29/07, Ned Batchelder <[EMAIL PROTECTED]> wrote: > I don't know that you need to make a release for this fix, but I think you > should alert people to it. There is a mailing list for announcing releases > and security issues, right? You should send a message to that list > announcing the

Re: Critical ticket: can cause data loss

2007-01-29 Thread Ned Batchelder
I think it is risky to assume that all potentially affected users will see this information in this thread. I found it, but there was an element of luck involved. I don't read this list religiously, and could easily have missed it. I don't know that you need to make a release for this fix,

Re: Critical ticket: can cause data loss

2007-01-25 Thread Russell Keith-Magee
On 1/23/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > On 1/23/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > > > I've just attached a unit test to the ticket. It seems to be the same > > issue described in #2749 and #3081. I think I understand the problem; > > the patch on #3081 is

Re: Critical ticket: can cause data loss

2007-01-23 Thread Russell Keith-Magee
On 1/23/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > I've just attached a unit test to the ticket. It seems to be the same > issue described in #2749 and #3081. I think I understand the problem; > the patch on #3081 is pretty much correct. I should have this sorted > out by tonight. >

Re: Critical ticket: can cause data loss

2007-01-23 Thread Russell Keith-Magee
On 1/23/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > On 1/23/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > > > Could somebody provide some unit tests that isolate the problem? I've > > never mucked with the GenericForeignKey code -- perhaps Jacob or > > Russell could chime in here

Re: Critical ticket: can cause data loss

2007-01-22 Thread Russell Keith-Magee
On 1/23/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > Could somebody provide some unit tests that isolate the problem? I've > never mucked with the GenericForeignKey code -- perhaps Jacob or > Russell could chime in here for the fix? I've never really played with GenericRelations, so I

Re: Critical ticket: can cause data loss

2007-01-22 Thread Adrian Holovaty
On 1/22/07, SmileyChris <[EMAIL PROTECTED]> wrote: > Deletion of objects with a GenericRelation(X) deletes unrelated X > objects with the same object_id! > http://code.djangoproject.com/ticket/3215 > > This ticket needs developers focus sooner rather than later. The > implications of this patch