Re: Okay to use form field labels in admin history?

2015-08-26 Thread Ramez Ashraf
Yes it worked well enough for over then it should be. So yes i would love to give it a try. So we will be storing json as string in the database? or what would be the recommended path to go about this ?! On Wednesday, August 26, 2015 at 3:34:31 PM UTC+2, Tim Graham wrote: > > The current

Re: Okay to use form field labels in admin history?

2015-08-26 Thread Tim Graham
The current approach has worked "well enough" for 10 years. I think we can wait a little longer for a better solution rather than change the message format twice. Want to give it a try? On Tuesday, August 25, 2015 at 11:07:45 AM UTC-4, Ramez Ashraf wrote: > > Dear devs > I'm the PR mentioned

Re: Okay to use form field labels in admin history?

2015-08-25 Thread Ramez Ashraf
Dear devs I'm the PR mentioned contributor. While I understand your concern about translated content in the database and the other ticket mentioned (having the info stored as Json or yaml) I see that these are different ways and are not mutually exclusive. The issue mentioned regards having

Re: Okay to use form field labels in admin history?

2015-08-25 Thread Claude Paroz
On Tuesday, August 25, 2015 at 1:48:55 AM UTC+2, Tim Graham wrote: > > Do you like the idea to use form field labels in the admin history > messages instead of the form field names themselves? > > It's been implemented here: > https://github.com/django/django/pull/5169 >