Re: Proposal: django.contrib.mysql

> > How about making the package official extension and bring under django org? > I thought about this, but a few parts of Django-MySQL are incredibly hacky and should probably not be "officially supported code".

Re: Proposal: django.contrib.mysql

On Monday, May 8, 2017 at 4:22:04 PM UTC+1, Adam Johnson wrote: > Sérgio, django-mysql already fully supports MySQL 5.7's JSON type with > its JSONField: > https://django-mysql.readthedocs.io/en/latest/model_fields/json_field.html > . Try that. > yes , I'm using it now and works great, many

Re: Proposal: django.contrib.mysql

Hi Adam, How about making the package official extension and bring under django org? Thanks, Asif On Monday, May 8, 2017 at 9:22:04 PM UTC+6, Adam Johnson wrote: > > Update: I decided not to try merge django-mysql as django.contrib.mysql > because I think it's an advantage to have it as a

Re: Proposal: django.contrib.mysql

By the way, just wanted to say thanks for all the hard work on django-mysql - it's a great package. On Monday, 8 May 2017 16:22:04 UTC+1, Adam Johnson wrote: > > Update: I decided not to try merge django-mysql as django.contrib.mysql > because I think it's an advantage to have it as a separate

Re: Proposal: django.contrib.mysql

Update: I decided not to try merge django-mysql as django.contrib.mysql because I think it's an advantage to have it as a separate package. As it stands, it supports Django 1.8 to 1.11 for all features, so people who aren't on cutting edge Django can still use all its features. Contrast that with

Re: Proposal: django.contrib.mysql

i would like to be part and start foundations coding giving back On Friday, March 4, 2016 at 1:09:00 AM UTC+2, Adam Johnson wrote: > > The *django.contrib.postgres* docs state: > > There is no fundamental reason why (for example) a contrib.mysql module >> does not exist > > > *Well...* over the

Re: Proposal: django.contrib.mysql

IMHO Python Django should support MySQL 5.7.x JSON fields , quickly . Thanks -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an

Re: Proposal: django.contrib.mysql

Wow I didn't reply for 11 days (sorry, company a bit crazy right now) and features are already being stolen merged! https://github.com/django/django/pull/6292/files :) > What's your main motivation for wanting to include it in Django itself? > I want Django to work better on MySQL/MariaDB

Re: Proposal: django.contrib.mysql

One of the other reasons why contrib.postgres is in core is that it required some changes to internals of the ORM. It's possible that all of those we need are done now (except custom indexes) - is there anything about contrib.mysql which would benefit from this? I'm happy for JSONField to be made

Re: Proposal: django.contrib.mysql

I agree regarding choosing the most most useful bits. When we discussed this at DUTH I did mention that there were some features that would be very difficult to get included in Django. I guess you'd have to consider whether or not you'd be willing to move features from django-mysql into contrib

Re: Proposal: django.contrib.mysql

Hi Adam, django-mysql has a rather large API surface. I think the first step would be to make a list of the most stable and generally useful bits that are candidate for inclusion in Django and to write that list down in a DEP. The fields, functions, lookups, and aggregates are good candidates.

Re: Proposal: django.contrib.mysql

Nice work, Adam. What's your main motivation for wanting to include it in Django itself? Do you think that including it will simplify the code much? Do you hope to attract new contributors by including it in Django itself? It's a bit concerning to me that the project seems like a one man show