Re: Update on localflavor move

2013-03-11 Thread Tai Lee
Hi Aymeric & Adrian, I didn't see any further discussion or consensus on the issue of the generic localflavor. The 1.5 docs and (accelerated) deprecation of localflavor are a little hazy regarding the generic localflavor. The 1.5 docs say that it hasn't been removed (yet), but doesn't say it

Re: Update on localflavor move

2012-10-16 Thread Carl Meyer
On 10/16/2012 04:00 AM, Łukasz Rekucki wrote: > If we include some form of a test runner in every localflvour, I > suspect they will get out of sync quite quickly. Also, I don't think > there is a good reason for duplicating code. David's pull request seems pretty minimal to me - just a

Re: Update on localflavor move

2012-10-16 Thread Andre Terra
This seems like the most reasonable approach. FWIW, why not name it just django-localflavor? Cheers, AT On Tue, Oct 16, 2012 at 7:00 AM, Łukasz Rekucki wrote: > Maybe we need something like django-localflavour-commons, which would > include the test harness, packaging

Re: Update on localflavor move

2012-10-16 Thread David Winterbottom
Here's another pull request for setting up testing, this time using tox as per Russell's suggestion. https://github.com/django/django-localflavor-gb/pull/2 AFAIK, tox requires the tests to be part of the package. Hence I moved tests.py into the django_localflavor_gb package as well as a test

Re: Update on localflavor move

2012-10-15 Thread Mahdi Yusuf
Hi, I have setup testing in a pull request here . If this solution is acceptable. I can duplicate the process on the other local flavours. I would appreciate feedback. -- Mahdi Yusuf On Mon, Oct 15, 2012 at 4:16 PM, Aymeric Augustin <

Re: Update on localflavor move

2012-10-15 Thread Aymeric Augustin
Hi Adrian, Thanks for taking the lead on this! I reviewed related tickets in Trac and I have a few suggestions. 1) Can we move the fields defined in django.contrib.localflavor.generic.forms to django.forms? Currently the US-biased fields are in django.forms and the non-biased ones in

Re: Update on localflavor move

2012-10-13 Thread ptone
On Friday, October 12, 2012 3:21:16 PM UTC-7, Adrian Holovaty wrote: > > * If you have any existing Trac tickets for localflavor, please close > them and open a pull request on the appropriate django-localflavor-* > project. > Correct me if I'm wrong in interpreting this - Trac won't be

Re: Update on localflavor move

2012-10-13 Thread Shai Berger
On Saturday 13 October 2012, Tomas Ehrlich wrote: > Salut Claude, > > > I can work on this, however I'm wondering if it makes sense to re-add all > > translations in all packages. Is adding Korean translation to Switzerland > > localflavor useful? > > I think it is. If someone translated

Re: Update on localflavor move

2012-10-13 Thread Tomas Ehrlich
Salut Claude, > I can work on this, however I'm wondering if it makes sense to re-add all > translations in all packages. Is adding Korean translation to Switzerland > localflavor useful? I think it is. If someone translated Switzerland localflavor into Korean language it means that he might

Re: Update on localflavor move

2012-10-13 Thread Claude Paroz
Le samedi 13 octobre 2012 00:21:16 UTC+2, Adrian Holovaty a écrit : > > Hi all, > > We've been talking about moving django.contrib.localflavor into > separate packages, outside of Django proper > ( > https://groups.google.com/d/topic/django-developers/OiyEGmXTifs/discussion). > > Today I did

Re: Update on localflavor move

2012-10-12 Thread Russell Keith-Magee
On Sat, Oct 13, 2012 at 6:21 AM, Adrian Holovaty wrote: > Hi all, > > We've been talking about moving django.contrib.localflavor into > separate packages, outside of Django proper > (https://groups.google.com/d/topic/django-developers/OiyEGmXTifs/discussion). > Today I did

Update on localflavor move

2012-10-12 Thread Adrian Holovaty
Hi all, We've been talking about moving django.contrib.localflavor into separate packages, outside of Django proper (https://groups.google.com/d/topic/django-developers/OiyEGmXTifs/discussion). Today I did the work of creating the django-localflavor-* packages and copying code/tests/docs to them.