Claude proposed a PR which simply adds the setting as an AppConfig
attribute: https://github.com/django/django/pull/6460
Feedback would be welcome as to whether this seems sufficient or if we need
something more complex. I imagine this pattern will become fairly common if
we decide to move in
On Thu, Jul 3, 2014 at 3:12 AM, Aymeric Augustin <
aymeric.augus...@polytechnique.org> wrote:
> My concern -- and the reason why I started talking about an API -- is,
> if every app clutters the AppConfig namespace with arbitrary names,
> improvements to AppConfig may create name clashes.
>
On 2 juil. 2014, at 22:14, Tomas Ehrlich wrote:
> The idea of overriding class attributes in AppConfig seems promising.
My concern -- and the reason why I started talking about an API -- is,
if every app clutters the AppConfig namespace with arbitrary names,
OT...just writing down this which came to me on the train this morning as I
read this thread
Does anyone else foresee the practice of having an "appconfig.py" full of
subclasses of AppConfigs becoming common?
Seems like a nice parallel to settings, allowing a project to specify
per-app config
On Wed, Jul 2, 2014 at 5:14 PM, Tomas Ehrlich
wrote:
> I would really like to see app configs with app-specific settings.
> Personally, I don't like flat settings where namespaces are created
> with prefixes (eg. STATICFILES_ ).
>
> The idea of overriding class
Dne Wed, 2 Jul 2014 21:17:52 +0200
Aymeric Augustin napsal(a):
> 2014-07-02 17:21 GMT+02:00 Tomas Ehrlich :
>
> > I'm just a bit confused with final decision.
> >
>
> I don't think we have a decision yet ;-)
Tim Graham made comment
On 02.07.2014, at 21:17, Aymeric Augustin
wrote:
> 2014-07-02 17:21 GMT+02:00 Tomas Ehrlich :
> I'm just a bit confused with final decision.
>
> I don't think we have a decision yet ;-)
>
> As Jannis commented on ticket: "This is
2014-07-02 17:21 GMT+02:00 Tomas Ehrlich :
> I'm just a bit confused with final decision.
>
I don't think we have a decision yet ;-)
> As Jannis commented on ticket: "This is simple, don't add a global setting
> but a parameter to the staticfiles app config. That's
Hi,
thank you for review.
I'm just a bit confused with final decision.
As Jannis commented on ticket: "This is simple, don't add a global setting
but a parameter to the staticfiles app config. That's where such things
belong now."
But according to Aymeric, app config isn't ready for custom
I've carefully deferred this topic until now...
Maybe the answer is just a "get_setting" function analogous to "get_model" :
apps.get_setting('myapp', 'MYSETTING')
app_config.get_setting('MYSETTING')
It could simply defer to class level variables by default.
The first only works once the app
Jannis commented on the ticket, "This is simple, don't add a global setting
but a parameter to the staticfiles app config. That's where such things
belong now."
This makes sense to me. I suppose we should look into whether it makes
sense to move at least some of the other static files settings
I see a point in ignoring hidden and swap files by default. CSV is imo
something which shouldn't be used anymore and as such shouldn't be a
default. Given that ignoring hidden and swap files should cover 80% of the
use cases, I don't see much point in a new setting.
Cheers,
Florian
On
Hi,
ticket #20189 proposes to override default ignore patterns for
collectstatic management command in project's settings.
Patch has been submitted about a year ago, but right now it's waiting
for 'design decision' whether add a new setting or not.
What is your opinion?
Cheers,
Tom
13 matches
Mail list logo