Fellow Report - September 3, 2016

2016-09-03 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27147 - Add support for defining bounds in postgres range fields (accepted) https://code.djangoproject.com/ticket/27148 - Invalid input for UUIDField with ModelMultipleChoiceField throws ValueError, not ValidationError (accepted) https:

Re: Sonar for the Django rpoject

2016-09-03 Thread Sergei Maertens
I kind of like these reports, since they can take away some of the early review work. I would put it on the same level as the `isort` checks we have now. On the other hand, adapting the existing codebase to 'resolve' this code smells will introduce quite some 'stupid' commits, so it might be bes

Re: Sonar for the Django rpoject

2016-09-03 Thread Curtis Maloney
If there will be sweeping commits to remove six and other py2 concessions, can the cleaning be included then? On 4 September 2016 9:38:05 AM AEST, Sergei Maertens wrote: >I kind of like these reports, since they can take away some of the >early >review work. I would put it on the same level as

Re: Exceptions caught by the "include" template tag make it hard to rely on tests

2016-09-03 Thread Sergei Maertens
No, this is actually one of the reasons I keep recommending people to use inclusion tags as opposed to the {% include %} tag, and I see the same recommendation/reasoning in the IRC channel. On Tuesday, July 12, 2016 at 12:36:11 AM UTC+2, Tim Graham wrote: > > Has anyone relied on the exception s

Re: Sonar for the Django rpoject

2016-09-03 Thread Ivan Sevastoyanov
Hi, I'm on a vacation and far from my PC now so it's possible that I'll not be able to answer some of the questions. @Sergei - Sonar can be applied the same way you have Jenkins. It will be easier to track some issues immediately. Sonar combines all the rules from pylint, pep8 plus some other r