Re: Comments system for sprint?

2007-11-15 Thread David Reynolds
On 15 Nov 2007, at 4:24 pm, Ryan K wrote: > > I've just implemented the django.contrib.comments system for my site > which is actually a great package that doesn't seem to be used by many > people. Does anyone have any plans to update the system? Some basic > configuration stuff seems to be

(no subject)

2007-11-15 Thread Adam Findley
smime.p7s Description: S/MIME Cryptographic Signature

Comments system for sprint?

2007-11-15 Thread Ryan K
I've just implemented the django.contrib.comments system for my site which is actually a great package that doesn't seem to be used by many people. Does anyone have any plans to update the system? Some basic configuration stuff seems to be missing like the ability to configure where the comment's

Re: Auto-escaping comitted

2007-11-15 Thread Cedric Rossi
OK, I've submitted both #5953 and #5952. Thanks! Cedric --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To

Comments system for sprint?

2007-11-15 Thread Ryan K
I've just implemented the django.contrib.comments system for my site which is actually a great package that doesn't seem to be used by many people. Does anyone have any plans to update the system? Some basic configuration stuff seems to be missing like the ability to configure where the comment's

Re: Auto-escaping comitted

2007-11-15 Thread Cedric Rossi
> Excuse me for asking, but did you do something like > album.title = mark_safe(...) I would have asked too ;-) But no -- nothing like that. I'll prepare a small example a fill the ticket later tonight. Cedric --~--~-~--~~~---~--~~ You received this message

Re: Auto-escaping comitted

2007-11-15 Thread Cedric Rossi
> Probably best to file a ticket with a short example. Otherwise it will > just be forgotten. Right, will do as soon as possible. > The escape filter documentation does say this. Quoting from the docs: > > Applying ``escape`` to a variable that would normally have >

Re: Auto-escaping comitted

2007-11-15 Thread Michael Radziej
On Thu, Nov 15, Cedric Rossi wrote: > Yes, but: > {% blocktrans with album.title|escape as title %} will not escape at > all, whereas > {% blocktrans with album.title|force_escape as title %} will escape > properly. From the quote, it seems that |escape will always result in > one and only one

Re: Should string constants in template filters should be marked safe?

2007-11-15 Thread Malcolm Tredinnick
On Thu, 2007-11-15 at 10:44 +0100, Michael Radziej wrote: > On Wed, Nov 14, SmileyChris wrote: > > > > > Just noticed an escaped string in my template due to: > > > > {{ image.caption|default:"No caption" }} > > > > It seems like to me that we should trust that string constants in > >

Re: Auto-escaping comitted

2007-11-15 Thread Malcolm Tredinnick
On Thu, 2007-11-15 at 02:20 -0800, Cedric Rossi wrote: > On Nov 14, 2:11 pm, Malcolm Tredinnick <[EMAIL PROTECTED]> > wrote: > > As I've just mentioned on django-users, I finally arrived at a point > > where I'm happy with the forwards-porting of the auto-escaping changes > > and they've been

Re: django-admin.py can't access user-supplied commands, even if --settings option is provided

2007-11-15 Thread Russell Keith-Magee
On 11/15/07, Todd O'Bryan <[EMAIL PROTECTED]> wrote: > > Patch provided in > > http://code.djangoproject.com/ticket/5943 > Thanks, Todd. The patch isn't quite correct - details of the problem I found are attached to the patch. Yours, Russ Magee %-)

Re: Auto-escaping comitted

2007-11-15 Thread Cedric Rossi
On Nov 14, 2:11 pm, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > As I've just mentioned on django-users, I finally arrived at a point > where I'm happy with the forwards-porting of the auto-escaping changes > and they've been committed in r6671. > > There may be a few corner cases in some of

Re: one django command (was: Re: django-admin.py can't access user-supplied commands, even if --settings option is provided)

2007-11-15 Thread Russell Keith-Magee
On 11/15/07, Gary Wilson <[EMAIL PROTECTED]> wrote: > > Joseph Kocherhans wrote: > > Hey Todd, I haven't looked at you patch, but here's what Russ > > mentioned when I asked: > > > >

Re: Should string constants in template filters should be marked safe?

2007-11-15 Thread Michael Radziej
On Thu, Nov 15, Michael Radziej wrote: > > Your logic is right as far as it goes, unfortunately, there is a problem > > with message instruction. If the same string appears in two templates, > > it will only appear once in the PO file. However, that doesn't work if > > one of the templates is an

Re: Should string constants in template filters should be marked safe?

2007-11-15 Thread Michael Radziej
Hi Malcolm! On Thu, Nov 15, Malcolm Tredinnick wrote: > On Thu, 2007-11-15 at 10:44 +0100, Michael Radziej wrote: > > On Wed, Nov 14, SmileyChris wrote: > > > > > > > > Just noticed an escaped string in my template due to: > > > > > > {{ image.caption|default:"No caption" }} > > > ... > > I

Re: Overriding a Model's save() method does not allow proper creation of ManyToMany related objects

2007-11-15 Thread Russell Keith-Magee
On Nov 15, 2007 3:13 PM, Gary Wilson <[EMAIL PROTECTED]> wrote: > > Collin Grady wrote: > > Are you seeing this behavior in admin? If so, I believe that is what is > > actually at fault, since it hard-sets m2ms, which would clear anything > > set in save(). > > I know Russ didn't take much of a

Re: one django command (was: Re: django-admin.py can't access user-supplied commands, even if --settings option is provided)

2007-11-15 Thread Will Hardy
#!/bin/sh if [ -e "./manage.py" ] ; then ./manage.py $@ else django-admin.py $@ fi That way, new users can simply learn the mighty django command, trendy users can switch over to the mighty django command and old users can hang onto their habits and let their fingers type what they always

Re: Should string constants in template filters should be marked safe?

2007-11-15 Thread Michael Radziej
On Wed, Nov 14, SmileyChris wrote: > > Just noticed an escaped string in my template due to: > > {{ image.caption|default:"No caption" }} > > It seems like to me that we should trust that string constants in > template variable tags are safe since they are directly in the > template author's

Re: one django command (was: Re: django-admin.py can't access user-supplied commands, even if --settings option is provided)

2007-11-15 Thread SmileyChris
On Nov 15, 6:02 pm, Gary Wilson <[EMAIL PROTECTED]> wrote: > Would it be crazy if we got rid of django-admin.py and manage.py and replaced > them with one "django" command to rule them all? Sounds great to me! --~--~-~--~~~---~--~~ You received this message