Re: #11834: colorized debug page. Assigned to buriy

2010-08-13 Thread burc...@gmail.com 
On Fri, Aug 13, 2010 at 7:38 PM, Thomas Guettler  wrote:
> burc...@gmail.com wrote:
>> Hi,
>>
>> On Thu, Aug 12, 2010 at 9:54 PM, Thomas Guettler  wrote:
>>> Hi,
>>>
>>> a colorized debug page helps a lot. More than 99% of errors
>>> are in my code, and not in django's. This patch gives "own" code
>>> a different color.
>>>
>>> It is assigned to "buriy" since 6 months.
>>>
>>>  http://code.djangoproject.com/ticket/11834
>>>
>>> Why not commit?
>>
>> I'm buriy. Patch creator.
>>
>> The agreement between core devs and me (or at least how i get it) was
>> that we decided that this patch needs to be a part of larger "debug
>> page usability improvement suite".
>> My decision is that until that, the patch is "incomplete" to allow
>> only in-house use.
>
> Django: The web framework for perfectionists with deadlines
> But where/when is the deadline?
It's for django jobs, not django development itself.
> I think with "release early, release often" you get perfect code
> faster.
Unfortunately,
1) I have a lot of hobbies,
2) typical commit time even for perfect patch is almost a year! and
almost no one applies patches from django tickets.
3) and current state of patch works excellent for my projects.

I had few useful thoughts about changing the way Django development
contributions gets accepted and committed -- but all I get from this
mailing list that all attempts to improve any process is just a waste
of time. Core devs have no time even to accept working & looking good
patches -- and rarely have time to review patches not looking good or
working wrong!
So why should I bother to write patches fast?

But, if I have fans waiting for this feature, this is one good reason!

>> I can do all development changes for all suite (and finish this patch
>> of course), if we discuss how it should be done.
>>
>> My issue needs few improvements:
>>  - docs & tests
>
> AFAIK the current debug page has no docs and tests, too.
At least we need tests for color choosing based on packages paths --
this can be customized by yourself.

>>  - ability to hide some traceback elements, keeping notice they are
>> hidden -- it's so easy to shot yourself in foot otherwise.
>
> Please explain this. What do you want to hide? The page is for developers 
> only.
The most of comments I got when developing this plugin were related to
hiding some non-interesting parts of traceback. While I for myself
tried this and find it confusing, i'm not sure if other should be able
to do this -- and they might already try to do this with current
patch.

>>  - better display for decorators -- i think they either don't deserve
>> separate line or should be displayed as @decorator in the short debug
>> output.
>
> I want to see the stacktrace the way it is (nested function calls)
You get it already.

>>  - grouping template tags together and pretty display for them --
>> please see below.
>>
>> At least, after my issue, there are 2 others:
>>  - DEBUG_SHOW_DJANGO_TRACEBACK option (
>> http://code.djangoproject.com/ticket/13148 )
>>  - output for template tags should be improved, since we're displaying
>> 4 traceback blocks instead of template tag itself. There was a code
>> written for this already somewhere, there was screenshot available,
>> and it was discussed in this group, but i can't find it right now. Can
>> anyone point me at it?
And don't you want pretty output for templates lines?

>> And yes, I don't know where to find designers to get a look at my
>> implemented improvements, I'd like contact them when I'm ready.
>
> I am not a designer, but here is my opinion: Your patch highlights
> own code quite good. But there are too many colors. I like the
> colors of http://www.djangoproject.com/
> Why not use or copy parts if this style?
>
> I would just increase the size of "own" code, no different colors.

> It would be nice if you could define a list of apps that
> you consider "stable" and which should be displayed small.

I'll try this, but colors are usually much better for visual
distinction of items.
I can make a special page, and show you and others resulting
screenshots after your suggestions, and everyone who wants to add
their 2cents.

-- 
Best regards, Yuri V. Baburov, ICQ# 99934676, Skype: yuri.baburov,
MSN: bu...@live.com

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: Getting #14002 (filesizeformat filter only supports up to GB) committed

2010-08-13 Thread Aaron T. Myers 
On Aug 13, 7:39 pm, Russell Keith-Magee 
wrote:

> Looks good -- I've marked RFC; I'll commit when I get a chance.

Thanks a lot!

Best,
Aaron

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: Getting #14002 (filesizeformat filter only supports up to GB) committed

2010-08-13 Thread Russell Keith-Magee 
On Sat, Aug 14, 2010 at 6:44 AM, Aaron T. Myers  wrote:
> Hello all,
> I was very impressed with the responsiveness to my initial patch for ticket
> #14002. However, no one's taken a look at my updated patch addressing the
> review comments. Would some one mind taking a look? Thanks a lot.
> http://code.djangoproject.com/ticket/14002

Looks good -- I've marked RFC; I'll commit when I get a chance.

Yours,
Russ Magee %-)

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Getting #14002 (filesizeformat filter only supports up to GB) committed

2010-08-13 Thread Aaron T. Myers 
Hello all,

I was very impressed with the responsiveness to my initial patch for ticket
#14002. However, no one's taken a look at my updated patch addressing the
review comments. Would some one mind taking a look? Thanks a lot.

http://code.djangoproject.com/ticket/14002

Best,
Aaron

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

#14102 model validation issue in Model._get_unique_checks

2010-08-13 Thread Travis Cline 
Came across this issue that was introduced with model validation:
http://code.djangoproject.com/ticket/14102

Would love a review.

Travis

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: #11834: colorized debug page. Assigned to buriy

2010-08-13 Thread Thomas Guettler 
burc...@gmail.com wrote:
> Hi,
> 
> On Thu, Aug 12, 2010 at 9:54 PM, Thomas Guettler  wrote:
>> Hi,
>>
>> a colorized debug page helps a lot. More than 99% of errors
>> are in my code, and not in django's. This patch gives "own" code
>> a different color.
>>
>> It is assigned to "buriy" since 6 months.
>>
>>  http://code.djangoproject.com/ticket/11834
>>
>> Why not commit?
> 
> I'm buriy. Patch creator.
> 
> The agreement between core devs and me (or at least how i get it) was
> that we decided that this patch needs to be a part of larger "debug
> page usability improvement suite".
> My decision is that until that, the patch is "incomplete" to allow
> only in-house use.

Django: The web framework for perfectionists with deadlines
But where/when is the deadline?
I think with "release early, release often" you get perfect code
faster.


> I can do all development changes for all suite (and finish this patch
> of course), if we discuss how it should be done.
> 
> My issue needs few improvements:
>  - docs & tests

AFAIK the current debug page has no docs and tests, too.

>  - ability to hide some traceback elements, keeping notice they are
> hidden -- it's so easy to shot yourself in foot otherwise.

Please explain this. What do you want to hide? The page is for developers only.

>  - better display for decorators -- i think they either don't deserve
> separate line or should be displayed as @decorator in the short debug
> output.

I want to see the stacktrace the way it is (nested function calls)

>  - grouping template tags together and pretty display for them --
> please see below.
> 
> At least, after my issue, there are 2 others:
>  - DEBUG_SHOW_DJANGO_TRACEBACK option (
> http://code.djangoproject.com/ticket/13148 )
>  - output for template tags should be improved, since we're displaying
> 4 traceback blocks instead of template tag itself. There was a code
> written for this already somewhere, there was screenshot available,
> and it was discussed in this group, but i can't find it right now. Can
> anyone point me at it?


> And yes, I don't know where to find designers to get a look at my
> implemented improvements, I'd like contact them when I'm ready.

I am not a designer, but here is my opinion: Your patch highlights
own code quite good. But there are too many colors. I like the
colors of http://www.djangoproject.com/
Why not use or copy parts if this style?

I would just increase the size of "own" code, no different colors.

It would be nice if you could define a list of apps that
you consider "stable" and which should be displayed small.


  Thomas


-- 
Thomas Guettler, http://www.thomas-guettler.de/
E-Mail: guettli (*) thomas-guettler + de

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: Google Organic Search Results for Documentation

2010-08-13 Thread Reinout van Rees 

On 08/11/2010 09:51 PM, Paul McMillan wrote:

I think this is somewhat ameliorated by being able to link to the
current trunk documents these days. Many incoming links will be going
there. Additionally, for old documents, there is the "these docs are
old" message at the top.


When I google, I always end up at the /dev docs with a big warning on 
top "This document is for Django's development version, which can be 
significantly different from previous releases. Get old docs here:..."


The 1.2 docs have the least scary warning.

Does the website tell google (via the xml sitemap, for instance) to 
prefer the /dev docs over the /1.2 docs?  I'd say the /1.2 links would 
be more user friendly to get for default google incoming traffic.



Reinout

--
Reinout van Rees - rein...@vanrees.org - http://reinout.vanrees.org
Programmer at http://www.nelen-schuurmans.nl
"Military engineers build missiles. Civil engineers build targets"

--
You received this message because you are subscribed to the Google Groups "Django 
developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.