Re: Design discussion: admin alert messages

2013-10-09 Thread Ryan Allen
It doesn't appear that the images I attached are being shown. Imgur instead: Updated error: http://imgur.com/JdoGyqw Updated Error with Protonopia http://imgur.com/Ve1ifAP Deuteranomoly Success Message http://imgur.com/QvqOHuo -- You received this message because you are subscribed to the Googl

Re: Design discussion: admin alert messages

2013-10-09 Thread Ryan Allen
Yes, thank you Russ. The conditions you mentioned were all considered when these screenshots were created, with the exception of Deuteranomoly (reduced sensitivity to green) as the test results were nearly the same as the Protonomaly (reduced sensitivity to red) scree

Re: Dynamic AUTH_USER_MODEL based on modules or routes

2013-10-09 Thread Russell Keith-Magee
On Thu, Oct 10, 2013 at 9:06 AM, Burak Emre Kabakcı wrote: > Again, thanks for the other alternatives. > > Today, I have worked with auth.backends.ModelBackend and it seems it would > be possible to separate user resources (like if the route namespace is > "myapp", then go with Customer table) if

Re: Dynamic AUTH_USER_MODEL based on modules or routes

2013-10-09 Thread Burak Emre Kabakcı
Again, thanks for the other alternatives. Today, I have worked with auth.backends.ModelBackend and it seems it would be possible to separate user resources (like if the route namespace is "myapp", then go with Customer table) if get_user(self, user_id) method is called with request parameter. I

Re: Design discussion: admin alert messages

2013-10-09 Thread Russell Keith-Magee
For the sake of completeness, it's worth pointing out two things: 1) "Color blindness" isn't a single medical condition. It's half a dozen different conditions, all with different colour distortions, ranging from mild colour spectrum distortion (Protanomaly, Deuteranomaly and Tritanomaly), to com

Re: Support POST of application/json content type

2013-10-09 Thread abh2134
Hi all, I would love to be involved with this feature. My suggestion is to do the following: - Check requst.is_ajax() - Check request.META.get('CONTENT_TYPE').count('application/json') - Parse request.body using django.utils.simplejson.loads - ... and set *request.JSON* to the resul

Re: Dynamic AUTH_USER_MODEL based on modules or routes

2013-10-09 Thread Russell Keith-Magee
On Thu, Oct 10, 2013 at 6:00 AM, Burak Emre Kabakcı wrote: > Thanks for the suggestions. > > @Andre Terra I figured out that my solution doesn't work actually. Custom > managers is not useful in my case because underlying auth system is still > same, it means it will also use same same session tab

Re: Design discussion: admin alert messages

2013-10-09 Thread Ryan Allen
Recent commits to improve error messages, particularly for those with color blindness:

Re: Dynamic AUTH_USER_MODEL based on modules or routes

2013-10-09 Thread Burak Emre Kabakcı
Thanks for the suggestions. @Andre Terra I figured out that my solution doesn't work actually. Custom managers is not useful in my case because underlying auth system is still same, it means it will also use same same session tables, cookies etc. @Russell Keith-Magee Sorry, I couldn't understa

Re: Proposal to end the war with flake8 warnings

2013-10-09 Thread Aymeric Augustin
On 9 oct. 2013, at 20:38, Tim Graham wrote: > If accepted, I'll put together a more concrete proposal that includes which > errors we'll ignore, etc. Sure, go ahead! I'm always embarrassed when contributors work on large cleanup patches, because they're especially tedious to review and don't

Re: Merge policy for cleanup commits

2013-10-09 Thread Danilo Bargen
Hm, I'm not sure I understand your e-mail. The link you just posted points to exactly the topic we're discussing right now. Maybe you meant to post another URL? Cheers, Danilo On Wednesday, October 9, 2013 9:11:09 PM UTC+2, Tomáš Ehrlich wrote: > > Relevant discussion > > https://groups.google

Re: Proposal to end the war with flake8 warnings

2013-10-09 Thread Daniele Procida
On Wed, Oct 9, 2013, Tim Graham wrote: >Our docs currently state: "Note, however, that patches which only remove >whitespace (or only make changes for nominal PEP 8 conformance) are likely >to be rejected, since they only introduce noise rather than code >improvement. Tidy up when you're next

Re: Merge policy for cleanup commits

2013-10-09 Thread Tomas Ehrlich
Relevant discussion https://groups.google.com/forum/#!msg/django-developers/tcNVvbAv4-M/bs0zPNLqv48J Cheers, Tom Dne Mon, 8 Jul 2013 09:59:49 -0700 (PDT) Danilo Bargen napsal(a): > Hi there > > (I tried to find previous threads concerning the same topic, but could not > find any. If this i

Re: Proposal to end the war with flake8 warnings

2013-10-09 Thread Anssi Kääriäinen
+1 - Anssi On Wednesday, October 9, 2013 9:38:17 PM UTC+3, Tim Graham wrote: > > I'd like to propose cleaning up Django's codebase so that we can run > flake8 (with some rules ignored) as a presubmit check (for example, hooked > into pull request submissions). > > Our docs currently state: "No

Re: Proposal to end the war with flake8 warnings

2013-10-09 Thread Juan Pablo Martínez
+1 hip hip cleanup! On Wed, Oct 9, 2013 at 4:38 PM, Tim Graham wrote: > things a -- juanpex -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-

Proposal to end the war with flake8 warnings

2013-10-09 Thread Tim Graham
I'd like to propose cleaning up Django's codebase so that we can run flake8 (with some rules ignored) as a presubmit check (for example, hooked into pull request submissions). Our docs currently state: "Note, however, that patches which only remove whitespace (or only make changes for nominal P