Re: Settings: lists or tuples?

2015-01-21 Thread Aymeric Augustin
As explained above and discussed on the #django-dev IRC channel, it's an acceptable choice to use tuples, even though it isn't the default Django chose. Please don't raise warnings or do anything else to discourage using tuples. Writing this patch consists in: - going though the 22 settings

Re: Settings: lists or tuples?

2015-01-21 Thread Sambhav Satija
While I understand that turning it into a deprecation warning would be way out of bounds, That was simply meant to say that maybe we should raise *some* warning at startup time that'll ensure that the developer at least knows what he's up against if he puts in tuples instead of lists. On

Re: Settings: lists or tuples?

2015-01-21 Thread Tom Christie
> So, I've been working on a patch ... Suggestions? Normalizing on lists as the default throughout is good. Warning about using tuples and putting their usage on a deprecation path seems a little unnecessary. I don't think that was discussed in this thread, but I've only scanned through, so I

Re: Settings: lists or tuples?

2015-01-21 Thread Sambhav Satija
So, I've been working on a patch (PFA) . As being discussed, lists are easier for beginners to follow, and tuples provide a false sense of security. With that in mind, I've simply changed pretty much all the tuples in global_settings and template_settings to lists, and warn about the usage of