Re: Django 1.8 has an undocumented change regarding template comments

2015-07-30 Thread charettes
Hi Robert, I don't exactly know which release introduced this change but I'd bet on 1.8.0 since a lot template related logic was refactored during its development. If you want to isolate the exact commit I'd suggest you try bisecting [1] Django's source. I think the change was unintentional

Django 1.8 has an undocumented change regarding template comments

2015-07-30 Thread Robert Rollins
I can't tell which exact release introduced this, since I went directly from 1.7.9 to 1.8.3, but one of my templates suddenly started rendering differently when I did. The template had a typo with one of its {# #}-style template comments; it was accidentally written as: {# comment here %}.

Re: @staff_member_required handling of non-staff users

2015-07-30 Thread Luiz Santos
+1 Sent from my iPad > On Jul 30, 2015, at 6:19 AM, Collin Anderson wrote: > > I like the behavior of showing the login screen if they don't have > permission. It's simple and pretty friendly. The new hint is helpful too. > >> On Tuesday, July 28, 2015 at 4:16:58 PM

Re: @staff_member_required handling of non-staff users

2015-07-30 Thread Collin Anderson
I like the behavior of showing the login screen if they don't have permission. It's simple and pretty friendly. The new hint is helpful too. On Tuesday, July 28, 2015 at 4:16:58 PM UTC-4, Carl Meyer wrote: > > On 07/28/2015 12:36 PM, Tim Graham wrote: > > We received a ticket [1] noting that

Re: Django Admin New Look

2015-07-30 Thread Aymeric Augustin
I am wary of privacy implications (leaking referers) of making it too easy to use a CDN, all the more since the admin is lightweight and not performance-critical. -- Aymeric. > Le 30 juil. 2015 à 11:05, Marc Tamlyn a écrit : > > One thing that might be nice to do with

Re: Making max_length argument optional

2015-07-30 Thread Aymeric Augustin
> Le 29 juil. 2015 à 18:25, Podrigal, Aron a écrit : > > I see models as what defines the database ddl and and not a representation > from a end users perspective. Django models do a bit more than this: see the `validators` argument, EmailField, etc. > And I see the

Re: Django Admin New Look

2015-07-30 Thread Marc Tamlyn
One thing that might be nice to do with the admin, especially in the context of the fonts but also with jQuery, is to give an easy override to use CDN versions of the files. Django still needs to bundle them for offline work, and the default should be to include Django's own ones, but it would be

Re: Django Admin New Look

2015-07-30 Thread Aymeric Augustin
Le 29 juil. 2015 à 13:13, elky a écrit : > > I can create small kit which will contain only icons that used in the project > - it will allow us to save about 70KB. But the question is - how to support > this kit in future if someone decide to add new icons ? Indeed, it