Re: change commit message format to present tense?

2016-06-25 Thread Kevin Christopher Henry
If anyone's put off by the hectoring tone of the imperative mood, it might be better to think of it as the indicative mood. That is: (This will) "add password validation to prevent the usage of...". rather than (You must) "add password validation to prevent the usage of..."! In English

Re: change commit message format to present tense?

2016-06-25 Thread Tim Graham
Reinout, I agree that the imperative mood seems awkward, especially when reading history, but of course I'm influenced by my experience with Django's history. No doubt others find it more natural. I guess if I had my way, we would keep using past tense, although I will say that it gets a bit

Re: change commit message format to present tense?

2016-06-25 Thread Shai Berger
On Saturday 25 June 2016 00:04:30 Tim Graham wrote: > With the idea of saving characters in the first line, would "Fix #XXX: > Message" be better than ""Fix #XXX -- Message" also? This saves two > characters without any loss of readability as far as I see. > Is there a real reason for caring

Re: Adding a database-agnostic JSONField into Django

2016-06-25 Thread Shai Berger
On Friday 24 June 2016 14:49:54 Raphael Hertzog wrote: > > Did my answer clear your doubts? > It moves my opinion of the feature from -0.5 "are we sure we need this" to -0 "I won't stand in your way". Shai.

Re: change commit message format to present tense?

2016-06-25 Thread Reinout van Rees
Op 24-06-16 om 19:48 schreef Carl Meyer: To be clear, the recommended git style is not present tense, it is imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the frobnicator", it should be "Fix #12345 -- Regulate the frobnicator." Everybody seems to be in favour. I'll allow