This makes sense, and the DEP looks great. Just a few thoughts:
- Django has always had dependencies, just external to PyPI. Python itself
is the obvious one. While not absolutely required for Django, a database
driver stack is another (psycopg2, mysql-connector, pyodbc, etc). Perhaps
we can lo
Since general consensus is that this PR is not the best idea in the world
I'm closing it along with corresponding issue on Trac.
On Fri, Nov 11, 2016 at 1:00 PM, Florian Apolloner
wrote:
> Hi Jannis,
>
> this is very much in line with what I would like to see as outcome of DEP
> 201. If you mana
Hi Jannis,
this is very much in line with what I would like to see as outcome of DEP
201. If you manage to find some time, I'd very much like to see your
input/guidance on the DEP (given your hands on experience with
django-hosts)!
Cheers,
Florian
On Friday, November 11, 2016 at 11:14:27 AM U
On Friday, November 11, 2016 at 9:15:30 AM UTC+1, Mislav Cimperšak wrote:
>
> The original PR is just a simple addition (that is still backwards
> compatible) to the `reverse` method; how people choose to use it (and when)
> is up to them.
>
This still does not makes it a good addition, especi
On Friday, November 11, 2016 at 10:16:32 AM UTC+1, Marc Tamlyn wrote:
>
> Given we already have `request.build_absolute_uri(path)`, I'm not 100%
> sure what extra this gives us. It's a bit of syntactic sugar for sure, but
> it solves a pretty narrow use case. The only times I've actually needed
Hi all,
Full disclosure: I’m one of the authors of django-hosts. But I’ve thought about
this problem a lot and maybe that’s useful for this discussion, maybe not :)
# Passing the request to reverse
I'm not convinced that reverse should be directly passed the request to build a
full URL since i
Given we already have `request.build_absolute_uri(path)`, I'm not 100% sure
what extra this gives us. It's a bit of syntactic sugar for sure, but it
solves a pretty narrow use case. The only times I've actually needed this
has been when sending emails and I'm using a `Site` object instead of
reques
Thinking about url tag and threadlocals is a step in the wrong direction.
The original PR is just a simple addition (that is still backwards
compatible) to the `reverse` method; how people choose to use it (and when)
is up to them. Adding something to the `url` tag is almost bound to brake
somethi
