Re: First ASGI pull request is ready for review

2019-04-24 Thread Curtis Maloney
I cannot find emoji enough to express how much I appreciate the work you've put into this :) -- Curtis On 4/25/19 6:50 AM, Andrew Godwin wrote: Hi everyone, Just wanted to drop a note and say that the first pull request in the series needed to enable async in Django is now ready for review:

Re: Proposal to format Django using black

2019-04-24 Thread Josh Smeaton
Whoops, you are correct. It did not at the time I added black to my projects, my information was quite out of date. Sorry for the wrong correction! On Wed, 24 Apr 2019 at 22:51, Florian Apolloner wrote: > > On Wednesday, April 24, 2019 at 1:25:55 PM UTC+2, Josh Smeaton wrote: >> >> Black does n

First ASGI pull request is ready for review

2019-04-24 Thread Andrew Godwin
Hi everyone, Just wanted to drop a note and say that the first pull request in the series needed to enable async in Django is now ready for review: https://github.com/django/django/pull/11209 This is a very minimal amount of work to get Django async-safe and understanding ASGI as an application i

Support for CTAS statement with ORM API?

2019-04-24 Thread Markus Elfring
Hello, I contributed the feature request “Creating database tables from queries based on ORM API” . Today it was requested to continue the clarification for mentioned software aspects in this forum. Can the support for the SQL standard statement “CRE

Re: Proposal to format Django using black

2019-04-24 Thread Florian Apolloner
On Wednesday, April 24, 2019 at 1:25:55 PM UTC+2, Josh Smeaton wrote: > > Black does not support disabling formatting by block with a comment. It > removes all choice except for the upfront choices of length and string > normalisation. > It does, "# fmt: off" and "# fmt: on" can be used -- Y

Re: Proposal to format Django using black

2019-04-24 Thread Josh Smeaton
Black does not support disabling formatting by block with a comment. It removes all choice except for the upfront choices of length and string normalisation. On Wed, 24 Apr 2019 at 20:22, Rene Fleschenberg wrote: > Hi > > > The arguments against a particular code style will never stop. In this >

Re: Proposal to format Django using black

2019-04-24 Thread Rene Fleschenberg
Hi > The arguments against a particular code style will never stop. In this > case it's a big advantage to choose a tool developed by others which > does not allow any bikeshedding. > Will black really stop the arguments (which are not bikeshedding, IMO -- readability counts)? Or will they just be

Fellow Reports -- April 2019

2019-04-24 Thread Carlton Gibson
Hi all. Calendar Week 14 -- ending 07 April. Released Django 2.2. Triaged: https://code.djangoproject.com/ticket/30323 -- Django 2.2 autoreloader is failing intermittently (not using watchman) (Accepted) https://code.djangoproject.com/ticket/30335 -- TypeError: unhashable type: 'list' when

Re: Proposal to format Django using black

2019-04-24 Thread Matthias Kestenholz
On Wed, Apr 24, 2019 at 9:06 AM Carlton Gibson wrote: > On Wednesday, 24 April 2019 08:58:57 UTC+2, Josh Smeaton wrote: >> >> lots of bikeshedding >> > > Yeah. 🙂 > > But we've already got a style guide, so **IF** we can get a YAPF config to > work to that then hopefully the arguments against usin

Re: Proposal to format Django using black

2019-04-24 Thread Carlton Gibson
On Wednesday, 24 April 2019 08:58:57 UTC+2, Josh Smeaton wrote: > > lots of bikeshedding > Yeah. 🙂 But we've already got a style guide, so **IF** we can get a YAPF config to work to that then hopefully the arguments against using a formatter here would be moot. (Note that **IF** — I only said