Re: Beginner-friendly issue to start contributing to codebase

2020-02-07 Thread Carlton Gibson
Yes, you can assign it to yourself. If you get stuck, post of the forum.djangoproject.com Mentorship topic. Welcome aboard! ⛵️ C. On Fri, 7 Feb 2020 at 11:43, Vibhu Agarwal wrote: > Hi Carlton > > Thanks for finding me this issue. > > I've set up django dev. locally. > I'm looking into this

Re: Use "raise from" where appropriate, all over the codebase

2020-02-07 Thread Carlton Gibson
Maybe... it's still more verbose for no gain as I see it. I think the default implicit chaining is correct in the default case. It's only if you want to adjust that (or suppress is with `from None`) that the extra clause comes in handy. I think using the default unless there's a reason not to

Re: Use "raise from" where appropriate, all over the codebase

2020-02-07 Thread Ram Rachum
On Fri, Feb 7, 2020 at 12:23 PM Carlton Gibson wrote: > > I'm basing it on the fact that Carlton approved this PR for the style > guide: https://github.com/django/django/pull/12350 > > No. I don't think we should merge that change. (It's "approved" qua itself > before reviewing, and dependent on

Re: Beginner-friendly issue to start contributing to codebase

2020-02-07 Thread Vibhu Agarwal
Hi! Thanks for the heads up. I'll remember to reproduce the bug locally, working on latest dev. branch and also ping the owner of ticket before starting to work for the patch. On Thursday, February 6, 2020 at 2:27:00 PM UTC+5:30, Adam Johnson wrote: > > Hi Vibhu > > Thank you for your

Re: Beginner-friendly issue to start contributing to codebase

2020-02-07 Thread Vibhu Agarwal
Hi Carlton Thanks for finding me this issue. I've set up django dev. locally. I'm looking into this issue now and I'll try to submit a patch asap :) Should I claim this ticket? On Thursday, February 6, 2020 at 2:25:08 PM UTC+5:30, Carlton Gibson wrote: > > Hi Vibhu > > Take a look at:

Re: Use "raise from" where appropriate, all over the codebase

2020-02-07 Thread Carlton Gibson
> I'm basing it on the fact that Carlton approved this PR for the style guide: https://github.com/django/django/pull/12350 No. I don't think we should merge that change. (It's "approved" qua itself before reviewing, and dependent on the main PR.) To be clear. I think the default implicit

Re: Use "raise from" where appropriate, all over the codebase

2020-02-07 Thread Ram Rachum
On Fri, Feb 7, 2020 at 12:27 AM Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > Hello Ram, > > On 6 Feb 2020, at 19:08, Ram Rachum wrote: > > In other words, "raise from" is the inevitable future, it's just that > we're not in a rush to get there. > > > I'm not sure how you came