Re: [Feature Request] Having an middleware to be able to force authentication on views by default

2020-03-14 Thread Mehmet Ince
Hi Tobias, Thanks for your comments > On 14 Mar 2020, at 11:43, Tobias Bengfort wrote: > > Hi Mehmet, > > On 13/03/2020 21.47, Mehmet Ince wrote: >> - We must forcefully enable session validation for every endpoint. >> - Developers must do something to make the unauthenticated endpoint >>

Re: [Probably BUG] set_password and check_password accept values other than string as parameters

2020-03-14 Thread Dawid Czeluśniak
Tom, The behavior of the make_password method is quite surprising to be honest > I'd go even further and say that currently the behaviour of the make_password function is *wrong* and *unsafe*. Again, let's look at hashing functions from other libraries. None of them fails silently and casts

Re: [Feature Request] Having an middleware to be able to force authentication on views by default

2020-03-14 Thread Tobias Bengfort
On 14/03/2020 09.43, Tobias Bengfort wrote: > Another option could be to add system checks for this: Instead of > silently "fixing" missing code it would inform developers about missing > decorators/mixins. (If I have time I might try to come up with a > prototype of this.)

Re: New Merger nomination.

2020-03-14 Thread James Bennett
On Sat, Mar 14, 2020 at 5:00 AM Markus Holtermann wrote: > Claude has been contributing to Django for almost a decade. His roles in i18n > related matters has been a constant help to the project. Providing Claude > with commit access to github.com/django/django and giving him the MERGER role >

Re: New Merger nomination.

2020-03-14 Thread Markus Holtermann
Thanks James for summarizing the process. Thanks Mariusz for the suggestion. Let's make it official, then. I'd like to nominate Claude Paroz (https://github.com/claudep) to be a Merger for the Django project and ask my fellow Technical Board members to cast their votes. Claude has been

Re: New Merger nomination.

2020-03-14 Thread Claude Paroz
Hey! Thanks for suggesting me as a merger! However, I'd like to clarify that I'm not requesting this commit bit. If the project thinks it's good that I get it, I'll accept that and do my best to use it as the new DEP suggests. If not, I can certainly continue to contribute as I've done in the

Re: [Feature Request] Having an middleware to be able to force authentication on views by default

2020-03-14 Thread Tobias Bengfort
Hi Mehmet, On 13/03/2020 21.47, Mehmet Ince wrote: > - We must forcefully enable session validation for every endpoint. > - Developers must do something to make the unauthenticated endpoint > instead of making it authentication protected! I agree with you that this would be a better situation

Re: [Feature Request] Having an middleware to be able to force authentication on views by default

2020-03-14 Thread Mehmet Ince
Hi, Actually, middlewares can access to the mapped view function/class with process_view() method. Within the function we need to decide that view is function or class. Easiest way to do it check existence of view_class attribute of view_func variable. While __global__ exist on every object,