Re: Order of INSTALLED_APPS

2013-09-01 Thread Kevin Christopher Henry
Sorry to be late to this thread, I just came across it. There's another place where the order of INSTALLED_APPS matters: management commands. Management commands associated with apps that come later in INSTALLED_APPS will replace those with the same name that are listed earlier. I can't find

Re: Order of INSTALLED_APPS

2013-09-03 Thread Kevin Christopher Henry
1 Sep 2013 21:31, "Kevin Christopher Henry" > <k...@severian.com> > wrote: > >> Sorry to be late to this thread, I just came across it. >> >> There's another place where the order of INSTALLED_APPS matters: >> management commands. Management command

Re: [GSoC] Revamping validation framework and merging django-secure once again

2013-09-12 Thread Kevin Christopher Henry
> > > We probably cannot move checks of `primary_key` and `unique` living in > `FileField.__init__`. We test if one of these two parameters was passed; we > don't check their values. Consider that an user passes unique=False. This > is > the default value, but nevertheless, this should result in

Re: Revert 165f44aa?

2013-09-21 Thread Kevin Christopher Henry
To summarize the possible approaches here: 1) Combine multiple with statements into one wherever possible. This seems to be the approach of the commit in question. 2) Group with statements based on whether they logically belong together, regardless of line length. This will involve backslashes,

TestCase can produce surprising failures

2013-12-05 Thread Kevin Christopher Henry
I recently upgraded one of my projects to 1.6 and was surprised to find that some of my tests were failing. I filed a ticket [1], and the subsequent discussion with Aymeric makes me think that there is a tricky issue here, worth discussing. The basic problem is that when using TestCase you

Re: Renaming apps.has_app

2014-01-05 Thread Kevin Christopher Henry
+1 for "is_installed" I don't find the grammar objectionable here, just think of it as "is_(each one of these apps)_installed" On Sunday, January 5, 2014 3:50:45 PM UTC-6, Aymeric Augustin wrote: > > On 5 janv. 2014, at 22:38, Raffaele Salmaso > > wrote: > > > Should

Re: [GSoC] Switching to Jinja2 proposal

2014-02-09 Thread Kevin Christopher Henry
Russell makes the very good point that Jinja2 isn't just a faster version of the Django template engine - it's philosophically at odds with the original design and intent of the Django template engine. Personally, I prefer Jinja2's approach and would love to see it become the standard. (The

Re: [GSoC] Switching to Jinja2 proposal

2014-02-21 Thread Kevin Christopher Henry
Hi Christopher, > ... checks the template extension and dispatch to > corresponding function from `django.dtl` or `jinja2`. > The mechanism for distinguishing the two kinds of template needs to be more flexible. For example, let's say I want to override a third-party template with my own

Re: [GSoC] Switching to Jinja2 proposal

2014-02-25 Thread Kevin Christopher Henry
> > What kind of support do you except for third-party template tags? Suppose, > that > `cycle` tag is not builtin. Would it be acceptable to write sth like that: > > dtl cycle '1' '2' as rows > > It could be quite easily implemented as a Jinja2 extensions. Of course, I > guess > that you'd

Re: Unneeded index created with unique=True and db_index=False in TextField

2015-04-15 Thread Kevin Christopher Henry
This issue was the subject of https://code.djangoproject.com/ticket/24082. There, the accepted (but not implemented) solution is the same as suggested here: allowing the user to opt out of the creation of the additional index with `db_index=False`. On Wednesday, April 15, 2015 at 2:11:25 PM

GitHub Issues for DEP repository?

2016-05-10 Thread Kevin Christopher Henry
Hello, With all the talk of DEPs flying around I thought I'd finally take a look at one in detail. I wanted to make a suggestion about it and realized that there wasn't really a good place to do so. The issue was too minor for a mailing list discussion, and there was no open pull request to

Re: change commit message format to present tense?

2016-06-25 Thread Kevin Christopher Henry
If anyone's put off by the hectoring tone of the imperative mood, it might be better to think of it as the indicative mood. That is: (This will) "add password validation to prevent the usage of...". rather than (You must) "add password validation to prevent the usage of..."! In English

Re: Improving Windows users experience at the command line

2017-07-14 Thread Kevin Christopher Henry
Regarding venv and bash, I filed a ticket [1] three years ago to have the bash script included with the Windows venv installation, and it looks like that change is in from 3.5 on. So in any case we shouldn't need to suggest virtualenv any more. Although I personally use bash, I definitely