Re: #7666: Default managers should not restrict access to single related objects

2008-07-20 Thread Nick Lane
On Jul 8, 3:34 pm, "James Bennett" <[EMAIL PROTECTED]> wrote: > On Mon, Jul 7, 2008 at 8:29 PM, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > Currently, ReverseSingleRelatedObjectDescriptor uses _default_manager, > > which is the problem (line 239 in django/db/models/related/fields.py). > > One c

Re: ModelChoiceField's clean() uses default manager instead of query set

2007-08-07 Thread Nick Lane
On Aug 7, 4:14 pm, oggie rob <[EMAIL PROTECTED]> wrote: > I'm not sure of the intent, but something to keep in mind is that if > you have previously-valid information and wish to save it again, it > may become invalid. > For example, I have a list of "active" employees for selection in the > filte

Re: Solution to problems with newforms BooleanField

2007-08-07 Thread Nick Lane
On Aug 7, 6:10 am, SmileyChris <[EMAIL PROTECTED]> wrote: > The main problem people have with BooleanField is that it raises a > ValidationError if its checkbox widget is left unchecked. here is a > problem, but it's not with BooleanField - *it's with the CheckboxInput > (widget)*. > > CheckboxInp

Re: ModelChoiceField's clean() uses default manager instead of query set

2007-08-07 Thread Nick Lane
On Aug 7, 6:55 pm, David Danier <[EMAIL PROTECTED]> wrote: > > However, I'm a little confused now. I > > thought the problem was only validation, and not the actual data that > > was added to the choice list. > > The problem is, that validation does not use the actual data of the > choice list. >

Re: ModelChoiceField's clean() uses default manager instead of query set

2007-08-08 Thread Nick Lane
On Aug 9, 5:49 am, oggie rob <[EMAIL PROTECTED]> wrote: > > That could work. The main point of this thread was to see if there are > > use cases for using the default manager for validation instead of the > > query set because I couldn't really think of any - but I'm sure there > > could well be s

Re: Admin and Related Models/Fields

2007-08-26 Thread Nick Lane
On Aug 26, 9:44 am, "Yuri Baburov" <[EMAIL PROTECTED]> wrote: > > That being said if you could point me to the patch (if it exists) so > > that I can try to help get it going again in or just lend another pair > > of eyes that would be really useful. If not, and if the admin isn't in > > too much

Writing tests for #6191 (admin delete view not listing all items)

2007-12-12 Thread Nick Lane
Hi, I had a quick look at writing some tests for #6191[1], and have a few queries. Should I be testing the admin delete view to make sure the response contains the expected items, or should I just test the "private" _get_deleted_objects() method, to check the items are returned in that list? Te

Re: Writing tests for #6191 (admin delete view not listing all items)

2007-12-12 Thread Nick Lane
On Dec 13, 1:42 pm, "Joseph Kocherhans" <[EMAIL PROTECTED]> wrote: > Just testing _get_deleted_objects() is fine by me if you can. I think > the AdminSite object might be intertwined with things in the > newforms-admin branch, so there may still be a bunch of setup. I've updated the patch to test

Re: newsform Addition

2008-02-13 Thread Nick Lane
On Feb 14, 7:10 am, Collin Grady <[EMAIL PROTECTED]> wrote: > Rock said the following: > > > Some thoughts: > > > Inplementing form.as_items returning a list of form lines would be > > nice. > > This allows a variety of custom formatting options. Examples: > > > > > {% for item in forms.as_items