Re: authentication by email

2012-03-09 Thread Tino de Bruijn
My django-email-login app ( https://bitbucket.org/tino/django-email-login/overview) does this by putting a hash of the email adress in the username field. It isn't as nice as it could be, but it works. I would really like to see this solved another way, but it is a hard problem with the current

Re: A.objects.getdefault

2012-10-09 Thread Tino de Bruijn
+1 on a method that returns non upon not finding. We don't need to do: try: val = some_dict.get('key') except KeyError: val = None either. A nget or get_or_none would save me a lot of boilerplate code in my views as well. Tino On Tue, Oct 9, 2012 at 8:48 PM, Wim Feijen

Re: Custom user models in 1.5, not flexible/dry enough?

2012-11-07 Thread Tino de Bruijn
+1 for the mixin approach. I needed to copy 90% of the AbstractUser model just to make the email field unique and remove the username field. The permission requirements I usually have are compatible with the one's used by the admin, but the username field is superfluous. As soon as your permission

Re: ClearableFileInput doesn't render a currently value when invalid

2012-11-12 Thread Tino de Bruijn
Hi Hiroki, On Mon, Nov 12, 2012 at 12:31 PM, Hiroki Kiyohara wrote: > Hi, all. > > Problem > === > In updating objects(UpdateView and so on), > django.forms.widgets.ClearableFileInput doesn't render a currently value > when the POSTed data was invalid(for example,

Re: Not calling things twice in templates

2013-06-05 Thread Tino de Bruijn
I think Shai correctly seperates the concerns. On Tue, Jun 4, 2013 at 11:03 PM, Shai Berger wrote: > But I think that most suggestions focused more on the other issue: How to > enable the only-do-pre-and-post-if-body-not-empty semantics with a > succinct, > clear syntax. >

Re: Add strutctured settings module to django 1.7?

2013-10-01 Thread Tino de Bruijn
To all of you who don't see benefit in putting certain (definitely not all!) settings in the environment, I would like to say: try it. It will finally make sense that you set DJANGO_SETTINGS_MODULE in the first place. I never understood why anybody would want that until this :D. I was sceptical

Re: Add strutctured settings module to django 1.7?

2013-10-02 Thread Tino de Bruijn
On Wed, Oct 2, 2013 at 11:16 AM, Tom Evans wrote: > Tracking what login keys are assigned to a specific instance of an > application is the entire purpose of configuration management. The > reason we keep code in VCS is so that we can be assured what is > deployed is

Re: Working towards a simpler GCBV implementation?

2013-10-05 Thread Tino de Bruijn
On Thu, Oct 3, 2013 at 11:09 AM, Tom Christie wrote: > * If a simpler GCBV implementation along the lines of django-vanilla-views > is something we think we should working towards. > Hells yes, +1. I love CBV, but when it gets a little more complex, I get dazzled. > *

Re: Creating a minimal custom user model. Seems last_login is required. Should it be?

2013-10-20 Thread Tino de Bruijn
On Mon, Oct 21, 2013 at 12:25 AM, Harry Percival wrote: > I don't care about last_login! Can this be circumvented? Should that > signal be optional, or gracefully handle the case where the user model has > no last_login field? Should I log this as a bug? No, this is

Re: Creating a minimal custom user model. Seems last_login is required. Should it be?

2013-10-21 Thread Tino de Bruijn
On Mon, Oct 21, 2013 at 2:13 AM, Russell Keith-Magee < russ...@keith-magee.com> wrote: > > On Mon, Oct 21, 2013 at 7:17 AM, Tino de Bruijn <tin...@gmail.com> wrote: > >> >> On Mon, Oct 21, 2013 at 12:25 AM, Harry Percival < >> harry.perci...@gmail.com>

Re: Should AdminSite be able to handle different namespace?

2013-11-22 Thread Tino de Bruijn
Hmm, I still find it confusing. I have used namespaced urls when making a reusable app, by using reverse(':"), but that does enforce someone to use the correct application namespace when including my app. I think this look more logical than prefixing all my urlnames with '_'. Is this the right

Re: Should there be a "is" comperator: {% if A is B %}?

2014-04-10 Thread Tino de Bruijn
Wouldn't this be easier?: {'required': "", 'name': 'fieldname'} => {% for name, value in attrs.items %} {{ name }}{% if value %}="{{ value }}"{% endif %}{% endfor %} Tino On Wed, Apr 9, 2014 at 11:53 PM, Gregor Müllegger wrote: > Hi, > > I recently had the need to

Re: feature request - use logging in WSGIRequestHandler

2014-05-29 Thread Tino de Bruijn
On Thu, May 29, 2014 at 3:40 AM, Russell Keith-Magee < russ...@keith-magee.com> wrote: > However, there's a cost - we'd be adding the requirement for a logging > configuration for something that is only ever used during development. So > we'd end up complicating the process of deploying the

Re: Form Model Validation Error

2014-11-09 Thread Tino de Bruijn
Hi Aman, This list is for discussing development of Django itself. Please post to django-users for questions about your own applications. On a side note, it is a bit unwieldy to attach your code files as attachments. Please use a service like pastebin or Github's Gists to post it online and link

Re: status of 1.8 release blockers

2015-01-12 Thread Tino de Bruijn
Congratulations! Looks like you've steadily moved it through. Tino On Tue, Jan 13, 2015 at 3:25 AM, Tim Graham wrote: > We did it -- all features are in or out for alpha. Please consider master > frozen for new features until we cut the stable/1.8.x branch later this >

Re: Fellow Report - January 16, 2015

2015-01-23 Thread Tino de Bruijn
Hi Tim, Here a non-core-team perspective. Although I haven't worked on any Django bugs or code lately, I do frequently read this mailinglist. It was nice to see your weekly status updates (and Berker's), the updates and work on release blockers and the releases themselves. I got the feeling

Re: Drop the TEMPLATE_DEBUG setting

2015-02-15 Thread Tino de Bruijn
+1, sounds logical to me. On Sun, Feb 15, 2015 at 4:42 PM, Marc Tamlyn wrote: > +1 to removing it > On 15 Feb 2015 14:16, "Aymeric Augustin" < > aymeric.augus...@polytechnique.org> wrote: > >> Hello, >> >> During the multiple template engines refactor, I didn’t touch >>

Re: Feature proposal: Conditional block tags

2015-02-18 Thread Tino de Bruijn
Hi, On Tue, Feb 17, 2015 at 9:04 PM, Preston Timmons wrote: > After looking at this, there's nothing special about blocks compared to > any other node. They could just as well be evaluated at render time. > > Here's a branch that implements this change: > > >

Re: Password validation in Django revisited

2015-03-11 Thread Tino de Bruijn
Hi Erik, I like the way this is going! I do want to emphasise the point that Josh made: you have to be able to aggregate all ValidationErrors, otherwise things can become quite frustrating. (Try to change your Skype password and you know why...) Tino On Wed, Mar 11, 2015 at 1:44 AM, Josh

Re: Idea/request for help: Django Developers Community Survey

2015-04-27 Thread Tino de Bruijn
Hi, Mark, I tend to do the same. Your proposed split of that question makes sense to me. Maybe a bit onto the details, but the last question about leaving an email adres ("If you'd like to enter your name and email address so we can follow-up if we have any questions about your responses. Please

Re: URL dispatcher API

2015-05-17 Thread Tino de Bruijn
Hi Marten, I am a little less acquainted with the internals of resolving and reversing than the people above, and I must say that I have a hard time understanding your new syntax when looking at the example gist. That might also have to do with the indentation style. Would the (blog_detail,

Re: django.channels: "async" for Django

2015-07-02 Thread Tino de Bruijn
Hi Andrew, >From reading your proposal, I really like this idea. I did not got around to trying django-channels yet, but it will in August when I start a new project (it's a PoC, so I can try out new stuff :). I hope to be able to give you more feedback then! Thanks so far, Tino On Thu, Jul

Re: Future of the development server's auto-reloading

2015-08-09 Thread Tino de Bruijn
Hi Aymeric, While I have wondered from time to time why runserver could not just continue after certain syntax errors, and wished it could do so, I think what you are proposing makes a lot of sense. I think having to manually reload after installing a new package is really acceptable (and more an

Re: Making the test suite run faster

2015-08-31 Thread Tino de Bruijn
Hi Aymeric, Really cool that you pushed this further. Out of curiosity I have two questions: - What happens when two SerializeMixin tests try to lock the same file? Does one wait for the other (probably not), or is a lockfile exception raised? - How does this work in combination with the

Re: #25582: Add a way to build URLs with query strings

2015-11-14 Thread Tino de Bruijn
Would it be an idea to have QueryDict accept a dictionary to construct it? Then you could use it’s urlencode method to create the querysting. Seems like a logical place to implement this to me. Tino > On 09 Nov 2015, at 14:30, Merijn Bertels wrote: > > I think