Re: Requiring GitHub login for actions on Trac

2014-08-09 Thread Luke Granger-Brown
My only concern with this is the thing with the usernames, whereby some people don't use the same username on Trac as on GitHub, and that accounts are automatically munged together if they have the same username. As a demonstration, I found someone with the core developer tag on Trac (lukeplant)

Re: Proposal: deprecate and remove django.contrib.comments

2013-03-07 Thread Luke Granger-Brown
+1 from me too - I've only tried using django.contrib.comments once, and it ended up not being what I needed anyway, so I had to write my own comments module (Disqus was out of the question) On Thu, Mar 7, 2013 at 5:11 PM, Carlos Aguilar wrote: > I think i can maintain

Re: Future url tag behaves unexpectedly

2012-08-29 Thread Luke Granger-Brown
ly continue when the url's first param fails to > evaluate properly only to fail 3 lines later with an incomprehensible > error message. > That smells like it should be filed as a bug to me. Regards, Luke Granger-Brown -- You received this message because you are subscribed to

Re: Proposal: use SQLAlchemy Core for query generation

2012-07-03 Thread Luke Granger-Brown
On Jul 3, 2012 1:59 PM, "Chris Wilson" wrote: > > Hi Reinout, > > > On Tue, 3 Jul 2012, Reinout van Rees wrote: > >> On 30-06-12 16:22, Luke Plant wrote: >>> >>> Also, in Django to date we've eschewed external dependencies. That has >>> been partly due to the poor and

Re: GitHub migration planning

2012-04-18 Thread Luke Granger-Brown
On Wed, Apr 18, 2012 at 11:55 PM, Dalton Barreto wrote: > Em 18 de abril de 2012 19:46, Dalton Barreto > escreveu: > > Em 18 de abril de 2012 18:44, philipn escreveu: > > Hmm, this would probably disable pull requests too. Not a

Re: Revisiting multiline tags

2012-02-24 Thread Luke Granger-Brown
+1 from me too - I've used {# #} across line boundaries before and wondered why it didn't work, since it didn't seem especially clear that this doesn't work nor why it doesn't work - I'd just substituted for the obvious and eventually just deleted the offending HTML. On Feb 24, 2012 9:30 AM,

Re:Improving docs for User.is_authenticated()

2012-02-23 Thread Luke Granger-Brown
> > > > Obviously, this function cannot change in behaviour or name, so I > > suggest altering the docs, dropping the clause about indicating that > > the user has provided username and password to make it clearer what > > this method does. > > It does prove that they've authenticated, in that

Re:Improving docs for User.is_authenticated()

2012-02-23 Thread Luke Granger-Brown
On Feb 23, 2012 3:41 PM, "Tom Evans" wrote: > > Hi all > > I don't like this function that much. It doesn't actually check > whether users are authenticated - which is to say, they have presented > credentials which we have accepted and authorized them to use to the >

Why recommend to include project name in settings?

2012-02-10 Thread Luke Granger-Brown
On Feb 10, 2012 3:47 PM, "Adam "Cezar" Jenkins" wrote: > > On Fri, Feb 10, 2012 at 9:50 AM, Carl Meyer wrote: >> >> "import .module" > > > Not arguing one way or another, but the above has always worked for me from a Python standpoint. It shouldn't work