Re: Upcoming Contributing to the Django Docs Workshops
Thanks On Sun, Jun 13, 2021 at 10:44 PM Carlton Gibson wrote: > We’ll send out a link for the first workshop this Tuesday. > > On Sun, 13 Jun 2021 at 18:44, moshe nahmias wrote: > >> Thanks for the reply, when are we supposed to get a link to connect to >> for the workshop? >> >> On Sun, Jun 13, 2021 at 6:17 PM Daniele Procida wrote: >> >>> moshe nahmias wrote: >>> >>> >Can you check to make sure I registered for the workshop? I didn't get >>> >any confirmation or link to where I should connect. >>> >I registered with the email I sent this message. >>> >Or should I register again to make sure? I assume duplicates are less >>> welcome >>> >>> The form doesn't send out confirmations I think. >>> >>> Daniele >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Django developers (Contributions to Django itself)" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to django-developers+unsubscr...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/django-developers/20210613151659.1113552412%40mail.gandi.net >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-developers+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/CACf8pw7iN3ajH%2Bu1kBBpV_P3yHNhqaTNoTReD-q-1RmWYQ0%2B4w%40mail.gmail.com >> <https://groups.google.com/d/msgid/django-developers/CACf8pw7iN3ajH%2Bu1kBBpV_P3yHNhqaTNoTReD-q-1RmWYQ0%2B4w%40mail.gmail.com?utm_medium=email_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAJwKpyTHtSkr%2BnWtfukch%2BbAqNvsB1buNJ%3DnpwMMVZwS5C7qCg%40mail.gmail.com > <https://groups.google.com/d/msgid/django-developers/CAJwKpyTHtSkr%2BnWtfukch%2BbAqNvsB1buNJ%3DnpwMMVZwS5C7qCg%40mail.gmail.com?utm_medium=email_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CACf8pw6iJOTGeTrVFoztzvRLCvJzN9TE2b3egWEbAYs4bJt3SQ%40mail.gmail.com.
Re: Upcoming Contributing to the Django Docs Workshops
Thanks for the reply, when are we supposed to get a link to connect to for the workshop? On Sun, Jun 13, 2021 at 6:17 PM Daniele Procida wrote: > moshe nahmias wrote: > > >Can you check to make sure I registered for the workshop? I didn't get > >any confirmation or link to where I should connect. > >I registered with the email I sent this message. > >Or should I register again to make sure? I assume duplicates are less > welcome > > The form doesn't send out confirmations I think. > > Daniele > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/20210613151659.1113552412%40mail.gandi.net > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CACf8pw7iN3ajH%2Bu1kBBpV_P3yHNhqaTNoTReD-q-1RmWYQ0%2B4w%40mail.gmail.com.
Re: Upcoming Contributing to the Django Docs Workshops
Hi Daniele, Can you check to make sure I registered for the workshop? I didn't get any confirmation or link to where I should connect. I registered with the email I sent this message. Or should I register again to make sure? I assume duplicates are less welcome Best, Moshe On Sun, Jun 13, 2021 at 2:06 PM Daniele Procida wrote: > Carlton Gibson wrote: > > >Daniele Procida will be leading a couple of free workshops on > >contributing to the Django docs, and learning the Diátaxis framework for > >documentation. > > > >These will be over the next two Wednesdays, the 16th and 23rd of June, > >at different times to be available as many timezones as possible. > > > >There's a sign-up form, with more information here: > > > > > https://docs.google.com/forms/d/1WC0mXNEf7kwDaS_3Q1d5WeQz5dJM8A1fWvna-_UrkNw > > Hi folks. Thanks for the interest in these workshops. There has been very > good take-up but we have room for a few more people on each day without the > risk of having too many. > > I'll be starting a new job in early July, but before then I'll have some > extra time to dedicate to people working on Django documentation, and I'd > be really pleased to make as much impact with this as possible - so please > sign up with the link above if you're interested. > > Daniele > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/20210613110600.1514326671%40mail.gandi.net > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CACf8pw5iT%3Dtht%3Du%2BzPt4aMH8u1ERhBtDQ%3DSnGuMpCwwrd5z-2w%40mail.gmail.com.
Re: about ticket 28588- has_perm hide non-existent permissions
Thanks for the corrections and input. If I will keep the check and return False if the permission doesn't exist, will it be OK? If yes I think I have a good solution, I will return on the check if perm in Permission.all() So instead of: return True we will have: return perm in Permission.objects.all() What do you think? If this seems reasonable I will make the PR in the next few days. On Sat, Sep 30, 2017 at 1:45 PM, Florian Apolloner <f.apollo...@gmail.com> wrote: > Hi, > > On Friday, September 29, 2017 at 7:00:41 PM UTC+2, moshe nahmias wrote: >> >> 3. Return False if the permission doesn't exist means that we go through >> the same path as a regular user, since (at least on >> auth.backends.ModelBackend) we check already if the user is superuser and >> if so we return all the permissions (I suppose it's only permissions that >> exist) it means we only need to remove the check at the start to see if the >> user is superuser. >> > > Removing this check would be highly backwards incompatible for 3rd party > permission backends. > > I don't think the performance will be that much of a problem, but since >> you think it might I think i will need to check it and report the results >> back unless there is a preference for one of the other solutions. either >> way it will be a good thing to check. >> > > There will probably not be a big performance drop for the builtin ones, > but we do not know anything about 3rd party (ie ldap etc) > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/django-developers/e14b6ff5-598d-4605-9e76- > 26df86971366%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/e14b6ff5-598d-4605-9e76-26df86971366%40googlegroups.com?utm_medium=email_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CACf8pw7joMt29d%2Br9y3E6Kxfj9Jvm3g5J%2B1gqw6vmDWz1H5h2Q%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: about ticket 28588- has_perm hide non-existent permissions
Florian, now the implementation is if the backend doesn't implement the has_perm we use continue so the code is not checked at all and return False for a regular user. The solutions suggested here are logging, raise an error on DEBUG = True and return False if the permission doesn't exist (if I missed anything let me know). I numbered the options suggested so far for easy reference. 1. The way I see it if we use logging the user will have to check if it got an error when working with has_perm, and if the problem started with the programmer is not doing tests well I don't think he/she will check the logs if they have them, and they might not have logs enabled, but it's a nice solution that won't need anything except this change (which i can implement as a function . 2. Raise an error on DEBUG = True is my favorite, if there is a bug it will jump on the first time the user is working on it when running the app but it's not backwards compatible. 3. Return False if the permission doesn't exist means that we go through the same path as a regular user, since (at least on auth.backends.ModelBackend) we check already if the user is superuser and if so we return all the permissions (I suppose it's only permissions that exist) it means we only need to remove the check at the start to see if the user is superuser. I don't think the performance will be that much of a problem, but since you think it might I think i will need to check it and report the results back unless there is a preference for one of the other solutions. either way it will be a good thing to check. Thanks, Moshe On Thu, Sep 28, 2017 at 4:10 PM, Shai Berger <s...@platonix.com> wrote: > Can we define a new API on the permission backend, > "verify_permission_exists()" > or some such, and just call it if settings.DEBUG and it is provided? That > doesn't seem very complex to me, and doesn't necessarily imply a huge > performance hit (even in DEBUG). > > On Thursday 28 September 2017 15:50:04 Tim Graham wrote: > > I suppose we can tentatively accept the ticket, but I looked at the code > > briefly and agree with Florian's assessment. If someone proposes a patch, > > we can evaluate it, however, I don't see a simple way forward that > wouldn't > > have a security risk or an adverse effect on performance. Given the > > philosophy, "complexity is the enemy of security," I'd lean toward > keeping > > the permissions checking code simple instead of adding some other logic > > based on DEBUG. > > > > On Wednesday, September 27, 2017 at 9:48:24 AM UTC-4, Florian Apolloner > > > > wrote: > > > I do not think it would be feasible to check existing permissions. For > > > one, not every backend uses the Permission class Django supplies and > > > get_all_permissions can cause performance issues so it should be used > > > sparingly. > > > > > > Cheers, > > > Florian > > > > > > On Sunday, September 24, 2017 at 4:56:40 PM UTC+2, moshe nahmias wrote: > > >> Hi, > > >> I am a python developer and like to use Django for web development. > > >> Since I like the framework I want to contribute back, so I looked at > the > > >> open tickets to find something I can start with contributing and found > > >> ticket 28588. > > >> > > >> This ticket is about when checking if the user has permission for some > > >> action if the user is super user he/she gets it all the time, even > when > > >> the permission doesn't exist, and this is not developer friendly > > >> because the developer can mistakenly think that everything is fine > even > > >> when the permission doesn't exist. > > >> > > >> As I understand (and correct me if I'm wrong) there should be a > > >> discussion about if we want to do this. > > >> > > >> If accepted I would like to do this, I think it's an easy enough > change > > >> for a new contributor like me. > > >> > > >> As I understand the ticket the problem is that a developer gets > confused > > >> on this behaviour (and it's illogical) that the super user is having a > > >> permission that doesn't exist. > > >> > > >> What do you think? (I think I will discuss my solution or optional > > >> solutions after we decide if we want to change this behaviour) > > >> > > >> [1] https://code.djangoproject.com/ticket/28588 > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CACf8pw6j0sGjDEkNJuxtwDbtmrWiTHrfVJWJW4uCJLrgXTx2kA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
about ticket 28588- has_perm hide non-existent permissions
Hi, I am a python developer and like to use Django for web development. Since I like the framework I want to contribute back, so I looked at the open tickets to find something I can start with contributing and found ticket 28588. This ticket is about when checking if the user has permission for some action if the user is super user he/she gets it all the time, even when the permission doesn't exist, and this is not developer friendly because the developer can mistakenly think that everything is fine even when the permission doesn't exist. As I understand (and correct me if I'm wrong) there should be a discussion about if we want to do this. If accepted I would like to do this, I think it's an easy enough change for a new contributor like me. As I understand the ticket the problem is that a developer gets confused on this behaviour (and it's illogical) that the super user is having a permission that doesn't exist. What do you think? (I think I will discuss my solution or optional solutions after we decide if we want to change this behaviour) [1] https://code.djangoproject.com/ticket/28588 -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CACf8pw6GUaH3%3D5wDnbQmxuDVF9Es6Y6hrGOE%2BNQQdmuEupQ7UA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
