Re: App-loading reloaded - custom app names in the admin

2013-12-23 Thread Aymeric Augustin
After the merge, some Selenium tests (which I don’t run locally in general) failed on Jenkins. That’s a test isolation issue: an AppDirectoriesFinder instance kept a cache of an incomplete list of applications, preventing later tests from finding static files correctly. I wanted to review the

Re: App-loading reloaded - custom app names in the admin

2013-12-22 Thread Aymeric Augustin
I’ve updated the pull request with these changes as well as a few minor comments made by reviewers. https://github.com/django/django/pull/2089 I think it’s worth merging in that state. I still have a list of about 20 things to check, but none of them is likely to change anything fundamental.

Re: App-loading reloaded - custom app names in the admin

2013-12-21 Thread Aymeric Augustin
Hello, Based on the feedback I received through several channels (GitHub, IRC, private email) I’m planning to make two API changes before merging this pull request. (1) Remove auto-discovery of AppConfig in application modules I implemented this shim to make it possible to take advantage of

App-loading reloaded - custom app names in the admin

2013-12-20 Thread Aymeric Augustin
Merge request I sent a pull request implementing my second goal: https://github.com/django/django/pull/2089. It allows customizing application names in the admin. A handful of core developers were kind enough to oversee my efforts. Their feedback on the design has been positive. However, as