Re: No 'Content-Type' header in response

2016-12-27 Thread Tim Graham
Don't worry about the unrelated failures, hopefully we'll get that other PR merged soon. On Tuesday, December 27, 2016 at 12:01:36 AM UTC-5, roboslone wrote: > > Okay, so I've submitted a pull-request > resolving this issue. But > tests for timesince

Re: No 'Content-Type' header in response

2016-12-26 Thread roboslone
Okay, so I've submitted a pull-request resolving this issue. But tests for timesince, timeuntil are still broken. I believe #27637 (PR ) fixes them. Do I need t

Re: No 'Content-Type' header in response

2016-12-26 Thread roboslone
Oh, nevermind. Instructions are attached to the ticket. I'll start to work on this. > On 27 Dec 2016, at 06:33, roboslone wrote: > > So how can I help resolve this? Should I just fork Django on GitHub and make > a pull-request? > >> On 26 Dec 2016, at 15:45, Curtis Maloney >

Re: No 'Content-Type' header in response

2016-12-26 Thread roboslone
So how can I help resolve this? Should I just fork Django on GitHub and make a pull-request? > On 26 Dec 2016, at 15:45, Curtis Maloney wrote: > > From what I can see in the rfc, it is permitted but not required. > > Only a body in a 204 response is proscribed. > > Any metadata (I.e. headers)

Re: No 'Content-Type' header in response

2016-12-26 Thread Curtis Maloney
>From what I can see in the rfc, it is permitted but not required. Only a body in a 204 response is proscribed. Any metadata (I.e. headers) are about the resource just accessed... So a Content-Type would, IMHO, be acceptable but not essential. On 26 December 2016 9:47:02 PM AEDT, roboslone w

Re: No 'Content-Type' header in response

2016-12-26 Thread roboslone
Thanks, that was an old setting in Mail.app =/ I've made a pull-request to DRF: https://github.com/tomchristie/django-rest-framework/pull/4768 But it seems to me that fixing it in Django would be more appropriate. On the subject o

Re: No 'Content-Type' header in response

2016-12-26 Thread Adam Johnson
Hi GMail! (you might want to fix your name used on google groups, I had the same problem ;) ) This seems to be a legitimate bug in the __repr__ to me - SO informs me that DRF is correct in not defining a Content-Type for a 204 as it has no body: https://stackoverflow.com/questions/21029351/what-co

No 'Content-Type' header in response

2016-12-25 Thread GMail
Hi! I'm using Django 1.10.2 and Django-Rest-Framework 3.5.3. I noticed, that HttpRequest.__repr__ method relies on 'Content-Type' header: > class HttpResponse(HttpResponseBase): > ... > > def __repr__(self): > return '<%(cls)s status_code=%(status_code)d, "%(content_type)s">' % {