Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2017-06-01 Thread Tim Graham
Maybe the LiveServerTestCase.port attribute added in Django 1.11.2 will help, https://code.djangoproject.com/ticket/28212. At this point, the original change is released, so we would open a new ticket for further changes. On Thursday, June 1, 2017 at 10:50:54 AM UTC-4, Tom Forbes wrote: > >

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2017-06-01 Thread Tom Forbes
Shouldn't A.url be a relative URL in this case? I agree the ticket should be re-opened though, we had some pains working around this, but it was surmountable. On 1 Jun 2017 15:31, "Francis Mwangi" wrote: please reopen the ticket, we are having a pain testing code that

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2017-06-01 Thread Francis Mwangi
please reopen the ticket, we are having a pain testing code that generating code. For instance class A(object): url = "some_url" test.py class TestingA(LiveserverTestcase): def test_a() "we can't override the url defined in object A since its initialized even before we

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-11-08 Thread Alex Riina
I use --liveserver for a slightly different case and had missed the original conversation. I'm not sure if mine justifies the code either, but for consideration: My company's authentication layer includes a homebrewed google oauth2 endpoint. I've added localhost:8000 to the valid redirect_uris

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-11-08 Thread Tim Graham
Take a look at the commit that made the removal: https://github.com/django/django/commit/81cdcb66bc74a0768d13f0e18872d46739028e64 --liverserver was only a shortcut for setting the DJANGO_LIVE_TEST_SERVER_ADDRESS environment variable, so that could be done without a command line argument,

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-11-03 Thread Andrew Wall
Thanks everyone. I guess my Django skills aren't advanced enough to figure out how this will work without the --liveserver command. Would it be easy to retain this command-line arg or would it require a significant change to the implementation? It seems like a useful command. On Tuesday,

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-10-18 Thread Harry Percival
Hi everyone, thanks for cc'ing me! I'm relaxed about this -- my use of the --liveserver command-line arg was always a hack, and i'm happy to figure out a different hack as and when i come to update the book for 1.11. A custom test runner that only does FTs, and maybe hacks the class to no

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-10-17 Thread Tim Graham
Good points -- given the existing subclassing needed to get LiverServerTestCase to support that use case, it might be reasonable not to worry about backwards-compatibility here. I'd be interested to hear Harry's (the author) thoughts about it. On Sunday, October 16, 2016 at 1:44:02 PM UTC-4,

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-10-16 Thread Alex Riina
Thanks for including a link to the TDD tutorial! As far as I can tell, the author wants to use `--liveserver` to point his functional tests at an external server so he can run his tests through nginx after running the same tests in his normal test environment. Based on the shell prompts in

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-10-15 Thread Tim Graham
At the time of the implementation [0], no one raised that use case. Probably we can reopen the ticket and add it back. [0] https://groups.google.com/d/topic/django-developers/_TD8IkSLgqE/discussion On Saturday, October 15, 2016 at 9:32:54 AM UTC-4, Andrew Wall wrote: > > Very much appreciate