Re: #13914 Add natural keys to contrib.auth.User and Group models
Thanks for the help and reviews! I will work on some tests for it. I will probably need some help with the documentation since English is not my first language :) Cesar Canassa 2010/10/5 Gabriel Hurley > You've got two sets of feedback on the ticket now. Basically the code > is good but it needs tests and docs before getting committed. If > you're unsure how to go about writing those, then you can certainly > ask for help here. > > All the best, > > - Gabriel > > On Oct 4, 4:57 pm, Cesar Canassa wrote: > > I am currently using the patch provided in the tickethttp:// > code.djangoproject.com/ticket/13914in my Django project. It's a > > small change, but I find it to be very helpful. > > > > Since the ticket seems to be be inactive I decided to come here and ask > for > > someone to review it. I am not very familiar with Django internals so I > > don't fell very confident in reviewing it myself. > > > > I will be more than happy in writing tests or improving the patch if > > the reviewer find it to be required! > > > > Thanks! > > Cesar Canassa > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-develop...@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com > . > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
Re: #13914 Add natural keys to contrib.auth.User and Group models
You've got two sets of feedback on the ticket now. Basically the code is good but it needs tests and docs before getting committed. If you're unsure how to go about writing those, then you can certainly ask for help here. All the best, - Gabriel On Oct 4, 4:57 pm, Cesar Canassa wrote: > I am currently using the patch provided in the > tickethttp://code.djangoproject.com/ticket/13914in my Django project. It's a > small change, but I find it to be very helpful. > > Since the ticket seems to be be inactive I decided to come here and ask for > someone to review it. I am not very familiar with Django internals so I > don't fell very confident in reviewing it myself. > > I will be more than happy in writing tests or improving the patch if > the reviewer find it to be required! > > Thanks! > Cesar Canassa -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
#13914 Add natural keys to contrib.auth.User and Group models
I am currently using the patch provided in the ticket http://code.djangoproject.com/ticket/13914 in my Django project. It's a small change, but I find it to be very helpful. Since the ticket seems to be be inactive I decided to come here and ask for someone to review it. I am not very familiar with Django internals so I don't fell very confident in reviewing it myself. I will be more than happy in writing tests or improving the patch if the reviewer find it to be required! Thanks! Cesar Canassa -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
