Re: Bacwards incompatibility of #20346 cache middleware should vary on full URL

2013-10-22 Thread Curtis Maloney
If all it meant was that currently cached content would effectively be
expired, I wouldn't see this as being anything more than an strong note.

But as I'm sure people have created their own tools for building the page
cache keys to forcibly expire them [and not yet taken advantage of that
function being separated to a util module] I'm guessing it'd warrant a
warning to catch up.

Just my 2c.

--
Curtis


On 23 October 2013 05:34, j l  wrote:

> Ticket #20346 is the request that cache keys should be generated from a
> request's full URL rather than path, and the proposed implementation of
> this is backwards-incompatible.
>
> Because the existing keys are a hash of the path, and so, so far as I
> know, we do not have the original path needed to migrate keys, I do not see
> how we can migrate existing keys.
>
> I am alerting everyone to this and wondering if anyone has ideas which
> preserve backwards compatibility.
>
> If a backwards-incompatible change is necessary, I wonder if it would be
> appropriate to change cache keys to be more compatible with looking up
> directly via reverse proxies and webservers. Django cache keys are
> Django-specific module names and hashes, but it might be desireable to have
> them be in a simple, readable format such as
> http://www.example.com/path/to;method=GET;locate=en-us;Vary=Pony;etc.
> Other programs can easily generate those keys in order to fulfill cache
> hits.
>
> Thanks.
>
> Ticket at https://code.djangoproject.com/ticket/20346.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at http://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CAKkhZKz9Q58b%3DdS%3DEw7w6ivqk-Q_Eb_Qeh8N_R9o%2BDZMX%2B1v-A%40mail.gmail.com
> .
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAG_XiSDXwiCSUJi%2BpFpNKHbCdn_NAz3as4-kyzchMp_-f6EcSg%40mail.gmail.com.
For more options, visit https://groups.google.com/groups/opt_out.


Bacwards incompatibility of #20346 cache middleware should vary on full URL

2013-10-22 Thread j l
Ticket #20346 is the request that cache keys should be generated from a
request's full URL rather than path, and the proposed implementation of
this is backwards-incompatible.

Because the existing keys are a hash of the path, and so, so far as I know,
we do not have the original path needed to migrate keys, I do not see how
we can migrate existing keys.

I am alerting everyone to this and wondering if anyone has ideas which
preserve backwards compatibility.

If a backwards-incompatible change is necessary, I wonder if it would be
appropriate to change cache keys to be more compatible with looking up
directly via reverse proxies and webservers. Django cache keys are
Django-specific module names and hashes, but it might be desireable to have
them be in a simple, readable format such as
http://www.example.com/path/to;method=GET;locate=en-us;Vary=Pony;etc. Other
programs can easily generate those keys in order to fulfill cache hits.

Thanks.

Ticket at https://code.djangoproject.com/ticket/20346.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAKkhZKz9Q58b%3DdS%3DEw7w6ivqk-Q_Eb_Qeh8N_R9o%2BDZMX%2B1v-A%40mail.gmail.com.
For more options, visit https://groups.google.com/groups/opt_out.