Re: Decision needed on formfield_callback

2013-02-27 Thread Shai Berger
On Wednesday 27 February 2013, poswald wrote:
> I'm wondering if we can open a quick discussion on the `formfield_callback`
> method of django ModelForms..
> 
> The basic issue boils down to the fact that we have an undocumented (and
> thus unsupported) method on ModelForm that would benefit greatly from a
> small change in behavior and an official blessing in the form of some
> documentation:
> 
> https://code.djangoproject.com/ticket/12915
> 
> This would be very helpful to developers who want to ensure that all of the
> model forms extending their form get a certain overridden field, or for a
> project like django-floppyforms. In the ticket Russ mentions not being 100%
> happy with the patches. Is there a better way to define the standard field
> type to use for a given type?

I took a glance, and it seems like the formfield_callback belongs in the opts 
object (and the Meta inner class), not the form class itself.

My 2 cents,

Shai.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Decision needed on formfield_callback

2013-02-27 Thread poswald
I'm wondering if we can open a quick discussion on the `formfield_callback` 
method 
of django ModelForms..

The basic issue boils down to the fact that we have an undocumented (and 
thus unsupported) method on ModelForm that would benefit greatly from a 
small change in behavior and an official blessing in the form of some 
documentation:

https://code.djangoproject.com/ticket/12915

This would be very helpful to developers who want to ensure that all of the 
model forms extending their form get a certain overridden field, or for a 
project like django-floppyforms. In the ticket Russ mentions not being 100% 
happy with the patches. Is there a better way to define the standard field 
type to use for a given type? I'm wondering if we can discuss what we would 
like to see changed in that code to make it acceptable for a merge...

Thanks!
-Paul

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.