Re: Feature idea: forms signals

2017-04-17 Thread David Seddon
Hi JP, That's a good point, sorry I didn't make it clear. The fork is installed from within the requirements file but you can also see it here, on the ticket_27923 branch: https://github.com/seddonym/django/tree/ticket_27923 I've updated the README to help. I'd be interested to hear if anyone

Re: Feature idea: forms signals

2017-04-16 Thread jpic
Hello David, Is it possible to try to use it as part of the Django fork you mention, instead of the app ? I couldn't find any link on your github profile, your website and google but perhaps I've missed it. Thanks ! Best <3 -- You received this message because you are subscribed to the Goog

Re: Feature idea: forms signals

2017-03-14 Thread David Seddon
I've put together a brief proof of concept here: https://github.com/seddonym/formsignals It demonstrates what you could do with post_init, post_clean and post_save signals, which I've also implemented in a fork of Django (no test coverage or documentation yet though). The concept it demonstrat

Re: Feature idea: forms signals

2017-03-10 Thread Aymeric Augustin
Hello, > On 10 Mar 2017, at 10:25, Florian Apolloner wrote: > > On Friday, March 10, 2017 at 10:12:54 AM UTC+1, David Seddon wrote: > What are the next steps? Shall I create a pull request, or does this need > more consensus first? > > Imo absolutely more consensus, especially (to minimize th

Re: Feature idea: forms signals

2017-03-10 Thread Florian Apolloner
On Friday, March 10, 2017 at 10:12:54 AM UTC+1, David Seddon wrote: > > What are the next steps? Shall I create a pull request, or does this need > more consensus first? > Imo absolutely more consensus, especially (to minimize the work for you), please do not just suggest the signals but also t

Re: Feature idea: forms signals

2017-03-10 Thread David Seddon
I've created a ticket for this here: https://code.djangoproject.com/ticket/27923#ticket What are the next steps? Shall I create a pull request, or does this need more consensus first? David On Wednesday, 8 March 2017 17:46:12 UTC, Melvyn Sopacua wrote: > > On Wednesday 08 March 2017 18:18:26

Re: Feature idea: forms signals

2017-03-08 Thread Melvyn Sopacua
On Wednesday 08 March 2017 18:18:26 Melvyn Sopacua wrote: > On Monday 06 March 2017 10:10:41 David Seddon wrote: > > Hi all, > > > > One thing I've always found challenging with Django is to adjust the > > functionality of forms from other apps. An example might be to add > > an extra field to a

Re: Feature idea: forms signals

2017-03-08 Thread Melvyn Sopacua
On Monday 06 March 2017 10:10:41 David Seddon wrote: > Hi all, > > One thing I've always found challenging with Django is to adjust the > functionality of forms from other apps. An example might be to add an > extra field to a login form provided by a third party module. > > What I end up doing

Re: Feature idea: forms signals

2017-03-07 Thread Adam Johnson
I'm +1 on adding some signals to forms, because I feel it's weird for Django to have several signals for models, and none for forms. However I don't really have an opinion on what the useful signal points are, because I don't touch forms that often. On 7 March 2017 at 11:13, James Pic wrote: > S

Re: Feature idea: forms signals

2017-03-07 Thread James Pic
Seems similar to this discussion: https://groups.google.com/forum/#!searchin/django-developers/forms%7Csort:relevance/django-developers/zG-JvS_opi4/wS-4PBfPBwAJ Yes, signal/slot is a pattern that allows quick and easy decoupling of components that have to work on the same payload, and I've been us

Re: Feature idea: forms signals

2017-03-07 Thread Aymeric Augustin
Hi David, It's good to hear that you did significant research in this area (which I couldn't tell from your original email). I get how this feature can come in handy and I won't stand in the way if it gets implemented. Improving the guidance about when (not) to use signals in the process would

Re: Feature idea: forms signals

2017-03-07 Thread David Seddon
I totally agree that signals are open to misuse, and I take your points. Inexperienced developers often seem to use them just because they're there, rather than to encapsulate their apps and avoid circular dependencies. The Django signals documentation could probably do with a bit more guidan

Re: Feature idea: forms signals

2017-03-06 Thread Aymeric Augustin
Hello, My experience with Django — and not just with inexperienced developers — is that signals are a footgun. I've seen them misused as workarounds for badly structured code and unclear dependency trees too often. I'm not eager to encourage their use. Fundamentally, signals in Django allow a

Feature idea: forms signals

2017-03-06 Thread David Seddon
Hi all, One thing I've always found challenging with Django is to adjust the functionality of forms from other apps. An example might be to add an extra field to a login form provided by a third party module. What I end up doing is often overriding the urlconf, view and form class. Or, worse