Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-04-24 Thread charettes
I'm also -1 on removing the form field for the same reasons as Adam. Le vendredi 24 avril 2020 06:39:06 UTC-4, Mariusz Felisiak a écrit : > > `models.NullBooleanField` is now deprecated [1]. > > I would like to ask again about opinions on deprecating `forms. > NullBooleanField` because I'm not

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-04-24 Thread Adam Johnson
I'm -1 on deprecating the form field. The different widgets make sense. Forms are decoupled from models for reasons like this. On Fri, 24 Apr 2020 at 11:39, Mariusz Felisiak wrote: > `models.NullBooleanField` is now deprecated [1]. > > I would like to ask again about opinions on deprecating

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-04-24 Thread Mariusz Felisiak
`models.NullBooleanField` is now deprecated [1]. I would like to ask again about opinions on deprecating `forms. NullBooleanField` because I'm not convinced that it's necessary and expected. `forms.NullBooleanField` and `forms.BooleanField` use different widgets and their behavior is slightly

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-03-17 Thread Markus Holtermann
Makes sense. We'd have the deprecation shims around for a while anyway. /Markus On Tue, Mar 17, 2020, at 11:10 AM, Carlton Gibson wrote: > Ok, that’s pretty quick and conclusive, so let’s progress. Thanks all. > > On Tue, 17 Mar 2020 at 11:00, Shrawan Poudel wrote: > > +1 from me > > > > On

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-03-17 Thread Carlton Gibson
Ok, that’s pretty quick and conclusive, so let’s progress. Thanks all. On Tue, 17 Mar 2020 at 11:00, Shrawan Poudel wrote: > +1 from me > > On Tue, Mar 17, 2020 at 3:00 PM Adam Johnson wrote: > >> +1 from me. >> >> On Tue, 17 Mar 2020 at 07:59, Aymeric Augustin < >>

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-03-17 Thread Shrawan Poudel
+1 from me On Tue, Mar 17, 2020 at 3:00 PM Adam Johnson wrote: > +1 from me. > > On Tue, 17 Mar 2020 at 07:59, Aymeric Augustin < > aymeric.augus...@polytechnique.org> wrote: > >> Hello, >> >> I'm inclined to Accept as well. >> >> -- >> Aymeric. >> >> >> >> On 17 Mar 2020, at 08:49, Carlton

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-03-17 Thread Adam Johnson
+1 from me. On Tue, 17 Mar 2020 at 07:59, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > Hello, > > I'm inclined to Accept as well. > > -- > Aymeric. > > > > On 17 Mar 2020, at 08:49, Carlton Gibson wrote: > > Hi all. > > > https://code.djangoproject.com/ticket/31369 > Proposes

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-03-17 Thread Mariusz Felisiak
Agreed, it's time to deprecate NullBooleanField. Best, Mariusz -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-03-17 Thread Aymeric Augustin
Hello, I'm inclined to Accept as well. -- Aymeric. > On 17 Mar 2020, at 08:49, Carlton Gibson wrote: > > Hi all. > > > https://code.djangoproject.com/ticket/31369 > Proposes to deprecate NullBooleanField. > > > https://code.djangoproject.com/ticket/29227 > Allowed BooleanField to be

Proposal to deprecate NullBooleanField (and remove in Django 4.0)

2020-03-17 Thread Carlton Gibson
Hi all. https://code.djangoproject.com/ticket/31369 Proposes to deprecate NullBooleanField. https://code.djangoproject.com/ticket/29227 Allowed BooleanField to be null=True. Introduced in Django 2.1. I'm inclined to Accept. Wonder if folks consider it a little too fast? (We could