Re: Request for comments: custom admin filters

2011-04-13 Thread Julien Phalip
On Apr 14, 8:46 am, Julien Phalip wrote: > Thanks a lot for your feedback. I agree with all your points and have > made the corresponding amendments in a new > patch:http://code.djangoproject.com/attachment/ticket/5833/5833.custom-filt... Sorry, just in case you've already

Re: Request for comments: custom admin filters

2011-04-13 Thread Julien Phalip
On Apr 14, 3:11 am, Jacob Kaplan-Moss wrote: > Hi Julien -- > > Thanks for your work on this! I'm working my way through the patch, > and it's looking good. I'm pretty happy with the internals, though I > do have some questions about the public API: > > * I'm rather unhappy

Re: Request for comments: custom admin filters

2011-04-13 Thread Julien Phalip
Hi Mikhail, On Apr 14, 4:56 am, Mikhail Korobov wrote: > Will your patch simplify creating filters not based on choices? E.g. > min/max filters where exact minimun and maximum values can be entered > (using form with method=GET and input fields for values)? I want a >

Re: Request for comments: custom admin filters

2011-04-13 Thread Mikhail Korobov
Hi Julien, Thanks for working on this! Will your patch simplify creating filters not based on choices? E.g. min/max filters where exact minimun and maximum values can be entered (using form with method=GET and input fields for values)? I want a pony ;) It would also be good to make

Re: Request for comments: custom admin filters

2011-04-13 Thread Jacob Kaplan-Moss
Hi Julien -- Thanks for your work on this! I'm working my way through the patch, and it's looking good. I'm pretty happy with the internals, though I do have some questions about the public API: * I'm rather unhappy with the `SimpleListFilter`/`FieldListFilter` breakdown, and especially the way

Request for comments: custom admin filters

2011-04-13 Thread Julien Phalip
Hello there, I've just posted a patch with a suggested implementation of custom admin filters: http://code.djangoproject.com/attachment/ticket/5833/5833.custom-filterspecs.3.diff I've written some pretty comprehensive tests and have also had a stab at writing some documentation. You should find