Re: View permissions to admin

2016-02-08 Thread Tim Graham
I think a view permission is reasonably within the scope of the admin, although I'm a bit nervous that we'll forget about it in some future feature and end up introducing a security issue. Since the topic comes up from time to time, I submitted a PR to remove "production-ready interface" from t

Re: View permissions to admin

2016-02-01 Thread Olivier Dalang
Hi, +1 for view permission and Petr's rationale There's one use case where missing the view permission should even be considered a bug: when you have foreign key with the raw id widget, currently the user gets a 403 error in the popup if he doesn't have edit permission on the related model. Best

Re: View permissions to admin

2016-01-31 Thread Petr Dlouhý
Hi Markus, Adam, I looked to Django admin documentation ( https://docs.djangoproject.com/en/1.9/ref/contrib/admin/). I don't see anything discouraging from such usage, but rather I see encouraging for usage as interface for content managers: "One of the most powerful parts of Django is the automa

Re: View permissions to admin

2016-01-31 Thread Adam Johnson
Hi, At YPlan we've hacked in view permissions to the admin, exactly because of the reasons Markus talked about - it's the front end we've built for employees, done rather than building a proper process-based interface. I think it could just about be done in a third-party package (It might rely

Re: View permissions to admin

2016-01-27 Thread Markus Holtermann
Hi Petr, all, I managed to find some time to look into your PR (updated link: https://github.com/django/django/pull/5297) and the related issue: https://code.djangoproject.com/ticket/8936 . Also, related discussion: https://groups.google.com/d/topic/django-developers/rZ5Pt9R94d4/discussion an

Re: View permissions to admin

2015-08-26 Thread petr . dlouhy
Hello all, I am still waiting for some information about what should I do next to get this pulled into Django. Isn't here somebody willing to take a look at this? PR is at https://github.com/django/django/pull/5108 -- You received this message because you are subscribed to the Google Groups "

Re: View permissions to admin

2015-08-05 Thread petr . dlouhy
Hi Josh, thanks for your reply. I was a little bit afraid of making PRs of interviewed code. So I made it now and the PR is here: https://github.com/django/django/pull/5108 Dne středa 5. srpna 2015 3:15:22 UTC+2 Josh Smeaton napsal(a): > > Hi Petr, > > Thanks for working on that ticket. I'm pro

Re: View permissions to admin

2015-08-04 Thread Josh Smeaton
Hi Petr, Thanks for working on that ticket. I'm probably not the person to be reviewing work in the admin, but here are a few ideas for getting your patch noticed. 1. Create a pull request against the Django repository. Even if it's not ready to be merged, a pull request makes it a lot easier

View permissions to admin

2015-08-04 Thread petr . dlouhy
Hi, 4 months ago, I have implemented view permissions for Django admin and posted it under following ticket: https://code.djangoproject.com/ticket/8936 The patch in my branch contains tests and documentation. I am willing to give my time to make this commited to official Django branch. But I w