Re: WOULD LIKE TO CONTRIBUTE TO DJANGO

2017-10-03 Thread Дилян Палаузов
Hello Brice, Here is the query I sent today, which improves my first suggestion: 1. WITH 2. maybe_found AS (SELECT * FROM t WHERE t.name='nameD'), 3. to_be_inserted AS (SELECT 'nameD' as "name", 'comment13' as "comment"), 4. just_inserted AS ( 5. INSERT INTO t (name, comment) SELEC

Re: WOULD LIKE TO CONTRIBUTE TO DJANGO

2017-10-03 Thread Tom Forbes
Your idea about ignoring conflicts in bulk_create is a great idea, i've made a merge request that attempts to implements this. If anyone has any time to review it it would be much appreciated. I couldn't find a very elegant way of adding it though - Sqlite and mysql need something added just after

Re: WOULD LIKE TO CONTRIBUTE TO DJANGO

2017-10-03 Thread Дилян Палаузов
Hello, Qui tacet consentire videtur. I agree there is still a concurrency problem with the approach I suggested. INSERT ON CONFLICT DO UPDATE might not work, if the simultaneously inserted object has for some reason other default values, that the current object, so that DO UPDATE will overwr

Re: WOULD LIKE TO CONTRIBUTE TO DJANGO

2017-10-03 Thread Adam Johnson
Also you posted this in https://groups.google.com/forum/#!msg/django-developers/r7JP_YHsIhM/jmof68XFBAAJ . Please don't repost, keep the conversation in one place. On 3 October 2017 at 17:00, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > Hello, > > Since I haven't seen positive

Re: WOULD LIKE TO CONTRIBUTE TO DJANGO

2017-10-03 Thread Aymeric Augustin
Hello, Since I haven't seen positive feedback from a committer, I'm not convinced there's consensus about this change. Also this doesn't look like a particularly easy topic for a beginner. It raises the following questions: - INSERT ON CONFLICT UPDATE would likely be a better option on Postgres

Re: WOULD LIKE TO CONTRIBUTE TO DJANGO

2017-10-03 Thread Дилян Палаузов
Hello Muhereza, I assume you understand by now Django quite well and are willing to give something "in return". Currently QuerySet.get_or_create() consists of two SQL commands: SELECT + optional INSERT. They cause a concurrent problem, if another get_or_create() is called between the SQL st

WOULD LIKE TO CONTRIBUTE TO DJANGO

2017-10-03 Thread Muhereza Herman
Hello, anyone reading this please help me out. am a new developer but i would like to contribute to* django*. please guide me on how to do that. thank you. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)&q