Re: lazy auth context processor

2009-10-15 Thread Luke Plant
On Wednesday 14 October 2009 16:39:31 Luke Plant wrote: > On Wednesday 14 October 2009 15:54:25 Russell Keith-Magee wrote: > > > * the output of {{ user }} in a template will be different. I > > > think this is acceptable, because only things like {{ > > > user.username }} are actually useful,

Re: lazy auth context processor

2009-10-14 Thread Luke Plant
On Wednesday 14 October 2009 15:54:25 Russell Keith-Magee wrote: > > * the output of {{ user }} in a template will be different. I > > think this is acceptable, because only things like {{ > > user.username }} are actually useful, apart from when debugging. > > I disagree. User.__unicode__()

Re: lazy auth context processor

2009-10-14 Thread Russell Keith-Magee
On Wed, Oct 14, 2009 at 8:24 PM, Luke Plant wrote: > > I want to fix #6552 (also #12031), and I've attached a patch that > makes the auth context processor lazy. > > I'm pretty sure this is the right thing to do, but I'd like to check > for any gotchas people might be

Re: lazy auth context processor

2009-10-14 Thread Paul McLanahan
On Wed, Oct 14, 2009 at 10:34 AM, Jacob Kaplan-Moss wrote: > Eh, I don't think it's a big deal. I just grepped through a *lot* of > Django code and can't find that use anywhere. So now I know I'm an edge case :) I do use that, but only because I'm using a proxy model for

Re: lazy auth context processor

2009-10-14 Thread Luke Plant
On Wednesday 14 October 2009 15:32:11 Jacob Kaplan-Moss wrote: > On Wed, Oct 14, 2009 at 7:24 AM, Luke Plant wrote: > > I want to fix #6552 (also #12031), and I've attached a patch that > > makes the auth context processor lazy. > > The patch looks good to me. The

Re: lazy auth context processor

2009-10-14 Thread Jacob Kaplan-Moss
On Wed, Oct 14, 2009 at 7:30 AM, Alex Gaynor wrote: > I think changing the result of {{ user }} in the template is a bad > idea. Eh, I don't think it's a big deal. I just grepped through a *lot* of Django code and can't find that use anywhere. > Luckily it can easily be

Re: lazy auth context processor

2009-10-14 Thread Jacob Kaplan-Moss
On Wed, Oct 14, 2009 at 7:24 AM, Luke Plant wrote: > I want to fix #6552 (also #12031), and I've attached a patch that > makes the auth context processor lazy. The patch looks good to me. The approach is a bit hard to follow what with the multiple types of lazyness

lazy auth context processor

2009-10-14 Thread Luke Plant
I want to fix #6552 (also #12031), and I've attached a patch that makes the auth context processor lazy. I'm pretty sure this is the right thing to do, but I'd like to check for any gotchas people might be aware of. Some behavioural changes: * user.get_and_delete_messages() will not be