Re: Running flake8 on pull requests

2014-11-13 Thread Tim Graham
Yes, I think so. It's been on my list of things to look into for some time. Thanks for the nudge. On Tuesday, November 11, 2014 10:41:02 PM UTC+1, Aymeric Augustin wrote: > > Hello, > > Since we started using flake8, we made many small commits to fix glitches. > > Would it be possible to run

Adding checks for common URLpattern configuration errors

2014-11-13 Thread Julian Wachholz
Hi Django-Developers I would like to add additional system checks to the existing bunch. In particular, checks regarding common configuration errors around URLpatterns. An example check is described in the ticket here: https://code.djangoproject.com/ticket/23813 Please suggest any other common

Re: Explicit relative imports

2014-11-13 Thread Tom Christie
Contrary voice here, but I don't dig explicit relative imports, it's just adds an extra decision point for no real benefit. Personally I always recommend full absolute imports, ordered strictly alphabetically - there's then never any room for confusion or decision making around how the imports

Re: Explicit relative imports

2014-11-13 Thread Marc Tamlyn
Whilst I think it's a bit nicer to be explicit in smaller projects, there are a few places where django's structure can result in long import paths - e.g. django.contrib.gis.db.backends where I think relative imports would actually add clarity. I tend to separate the relative section as the last

Re: Explicit relative imports

2014-11-13 Thread Tai Lee
I also don't see much benefit in using relative imports. Code is read many more times than it is written, and I find having the full path makes it much easier to sort and visually scan imports, and to easily see at a glance exactly where to find what you need. If they are to be used, I would