Re: GitHub Actions

2019-11-07 Thread Johannes Hoppe
Hey Tom, Good to hear for you and very good points. I'll leave you a couple of inline comments: On Friday, November 8, 2019 at 1:04:50 AM UTC+9, Tom Forbes wrote: > > This is fantastic! Thank you Johannes! Regarding sqlite MacOS and Windows > tests, this is historical AFAIK (we don’t have the

Re: GitHub Actions

2019-11-07 Thread Carlton Gibson
Please open an issue for the macOS failure. It’s been passing for me all week so... 樂 On Thu, 7 Nov 2019 at 17:31, Johannes Hoppe wrote: > Hey Tom, > > Good to hear for you and very good points. I'll leave you a couple of > inline comments: > > On Friday, November 8, 2019 at 1:04:50 AM UTC+9,

Re: GitHub Actions

2019-11-07 Thread Tom Forbes
This is fantastic! Thank you Johannes! Regarding sqlite MacOS and Windows tests, this is historical AFAIK (we don’t have the resources). With this we should test MacOS and Windows as part of the Sqlite matrix (i.e all python versions). A few notes: 1. We need to change the test runner output

Re: Python version support for LTS Django (in particular v2.2)

2019-11-07 Thread Mariusz Felisiak
> I see. Well, I think I would be for supporting Python 3.8 in that case. > Maybe it makes sense to add Python nightly build tests to those braches to > make sure we catch issues early and it doesn't become an overwhelming task. > We have such jobs https://djangoci.com/view/Main/ -- You

Re: GitHub Actions

2019-11-07 Thread Johannes Hoppe
Ok, I have one more insight. I added all databases (except Oracle) and altered the job matrix to reflect the current setup (why don't we test on macOS again?) Results can be found here:

Re: GitHub Actions

2019-11-07 Thread Johannes Hoppe
I put in a little effort and tried a couple of conceptual things. 1. YAML anchors, inheritance and includes are not yet supported by GitHub actions. 2. You can build dependent builds, or build stages, but you will need to keep everything in one file. (This gets messy without anchors & co). 3.

Re: Python version support for LTS Django (in particular v2.2)

2019-11-07 Thread Johannes Hoppe
I see. Well, I think I would be for supporting Python 3.8 in that case. Maybe it makes sense to add Python nightly build tests to those braches to make sure we catch issues early and it doesn't become an overwhelming task. On Fri, Nov 1, 2019, 05:02 Jani Tiainen wrote: > Problem is that

Re: GitHub Actions

2019-11-07 Thread Johannes Hoppe
Good idea Carlton, here you go https://code.djangoproject.com/ticket/30964#ticket On Friday, November 8, 2019 at 3:03:58 AM UTC+9, Carlton Gibson wrote: > > Please open an issue for the macOS failure. It’s been passing for me all > week so... 樂 > > On Thu, 7 Nov 2019 at 17:31, Johannes Hoppe >

Re: GitHub Actions

2019-11-07 Thread Johannes Hoppe
@Tom, I stared to adapt some of your suggestions. Not done yet, I need to wait for more log output from PostgeSQL to identify why it's stuck. I'll put in more work later today (UTC+9). I'll also open up a pull-request somewhere to allow line wise comments and suggestions. @Matematica, good

Re: GitHub Actions

2019-11-07 Thread Matemática A3K
On Thu, Nov 7, 2019 at 11:31 AM Johannes Hoppe wrote: > Hey Tom, > > Good to hear for you and very good points. I'll leave you a couple of > inline comments: > > On Friday, November 8, 2019 at 1:04:50 AM UTC+9, Tom Forbes wrote: >> >> This is fantastic! Thank you Johannes! Regarding sqlite MacOS