Re: The blacklist / master issue

2020-06-16 Thread Fran Hrženjak
Meaning "owner of slaves" is only one of many meanings of the word, and not its primary meaning: https://dictionary.cambridge.org/dictionary/english/master https://www.merriam-webster.com/dictionary/master Renaming the master branch would mean we agree that this one meaning is somehow more

Re: Proposal - Warn user when creating or applying a delete migration?

2020-06-16 Thread Carlton Gibson
Looking at the proposed ticket here #31700 , I'm *Meh* at best: * - + ~ * Green, yellow, red I'm not sure I want to look at either of those. Visual noise for X benefit, where I think X is likely very small. Not sure it's worth the complication.

Re: Overriding template blocks without copy/pasting entire template files

2020-06-16 Thread Josh Smeaton
Upon reflection, would you agree that this should be documented a little better? The release notes at the time had a vague deprecation note about ` supports_recursion` being removed, and the main docs https://docs.djangoproject.com/en/3.0/ref/templates/builtins/#std:templatetag-extends have no

Re: The blacklist / master issue

2020-06-16 Thread Claude Paroz
Note that the term "blacklist" only appears twice in the Django tree and only in comments/docs, as shown by David's patch. The first one can be omitted while the second one can be replaced by "exclude". That is trivial to do and shouldn't even require a discussion. About replacing "whitelist"

Re: What's wrong with the jenkins testrun failing on ASGI (I think?)

2020-06-16 Thread Mariusz Felisiak
It's an issue with the asgiref==3.2.8, see https://github.com/django/asgiref/issues/170. We temporarily pinned asgiref==3.2.7 [1]. Best, Mariusz [1] https://github.com/django/django/commit/dcb4d79ef719d824431a8b3ff8ada879bbab21cc -- You received this message because you are subscribed to

Re: What's wrong with the jenkins testrun failing on ASGI (I think?)

2020-06-16 Thread Florian Apolloner
Ok, so rebasing PRs to current master will fix this (leaving this here as note for others who run into this). On Tuesday, June 16, 2020 at 10:39:13 AM UTC+2, Mariusz Felisiak wrote: > > It's an issue with the asgiref==3.2.8, see > https://github.com/django/asgiref/issues/170. We temporarily

Re: The blacklist / master issue

2020-06-16 Thread Jure Erznožnik
+1 on this discussion progression. I too struggled with certain expressions in my earlier English-learning days, but today the used expressions don't carry any unnecessary baggage for me as my understanding of them is purely technical. So, while I myself don't have a problem with them, I can

What's wrong with the jenkins testrun failing on ASGI (I think?)

2020-06-16 Thread Florian Apolloner
Hi, do we have any idea what is happening on https://djangoci.com/job/pr-mariadb/database=mysql,label=mariadb,python=python3.8/6459/ ? It seems as if (mostly) the same set of tests is failing over and over. Is this ASGI/concurrency related? Cheers, Florian -- You received this message

Re: The blacklist / master issue

2020-06-16 Thread Sanskar Jaiswal
Just my 2 cents on this discussion as a junior contributor. I am very fond of how inclusive and progressive the Django community is. With that said, I believe that we shall definitely try to stop using the term blacklist for “bad/unwanted” things. If this change makes even only a few contributors,

Re: The blacklist / master issue

2020-06-16 Thread Kye Russell
Git’s default branch name is a bit of a misnomer, however it refers to a master-slave relationship: https://mail.gnome.org/archives/desktop-devel-list/2019-May/msg00066.html Kye On 16 June 2020 at 4:24:32 pm, Fran Hrženjak (fran.hrzen...@gmail.com) wrote: Meaning "owner of slaves" is only one

Re: Overriding template blocks without copy/pasting entire template files

2020-06-16 Thread Carlton Gibson
Yes! Absolutely. There's even a ticket for that: https://code.djangoproject.com/ticket/29336 There was a PR, but we couldn't get it down to size... (Review ) On Tuesday, 16 June 2020 08:29:27 UTC+2, Josh Smeaton wrote: > > Upon

Re: Overriding template blocks without copy/pasting entire template files

2020-06-16 Thread Arvind Nedumaran
Could you elaborate on how this is different from extending a base template and re-defining the necessary blocks? #base.html {% block title %}{{ section.title }}{% endblock %} . {% extends "base.html" %}{% block title %} My custom title that isn't section.title {% endblock %} This much

Re: Proposal - Warn user when creating or applying a delete migration?

2020-06-16 Thread sourav tiwari
I m in search of job Can any one help me to find out a job On Tue, 16 Jun 2020, 12:00 Carlton Gibson, wrote: > Looking at the proposed ticket here #31700 > , I'm *Meh* at best: > > * - + ~ > * Green, yellow, red > > I'm not sure I want to look at

Re: The blacklist / master issue

2020-06-16 Thread Jorge Gimeno
I would suggest that this a relatively small change that would provide the community with a large return in being more inclusive. -Jorge On Monday, June 15, 2020 at 9:28:23 AM UTC-7, Tom Carrick wrote: > > This ticket was closed wontfix > as

Re: Proposal - Warn user when creating or applying a delete migration?

2020-06-16 Thread Tobias McNulty
I'm +1 to doing *something.* Absent a louder reminder, I think it's unrealistic to expect everyone to read the output of makemigrations all the time. As others have said, I'm not sure `manage.py migrate` is the right time. I think it's too late. The code may have already been committed, who knows

Re: The blacklist / master issue

2020-06-16 Thread אורי
I think *master* is the default branch name in any Git repository. It's not about Django and even not GitHub. Do you want to change the default branch name in Git? אורי u...@speedy.net On Mon, Jun 15, 2020 at 7:28 PM Tom Carrick wrote: > This ticket was closed wontfix >

Re: Overriding template blocks without copy/pasting entire template files

2020-06-16 Thread Florian Apolloner
Ah, might be that you got hold up in a moderation queue or similar. Google groups is weird sometimes -- sorry! On Tuesday, June 16, 2020 at 3:20:25 PM UTC+2, Arvind Nedumaran wrote: > > Something must be faulty with my email delivery I suppose. I sent that > email a good 8 hours ago. :) > >

Re: Proposal - Warn user when creating or applying a delete migration?

2020-06-16 Thread René Fleschenberg
Hi, During makemigrations, on the other hand, I don't see anything wrong with formatted text or +/-, but I might go a step further. This sounds like a good idea to me. It would break cases where makemigrations is run non-interactively, which might be a good thing. It's a common mistake to

Re: Overriding template blocks without copy/pasting entire template files

2020-06-16 Thread Florian Apolloner
If you look at the mails beyond the first one, you will see that Josh & Carlton already came to that conlusion ;) On Tuesday, June 16, 2020 at 2:16:31 PM UTC+2, Arvind Nedumaran wrote: > > Could you elaborate on how this is different from extending a base > template and re-defining the

Re: The blacklist / master issue

2020-06-16 Thread Arvind Nedumaran
The "default" is name is just a convention. It can be other things and after a few days of "teething" issues, and everyone will be back to being as productive as they are right now. Sent from Outlook Mobile From:

Re: The blacklist / master issue

2020-06-16 Thread Roger Gammans
Funny you should say that but the git developers mailing list in is awash with patches and shouting about just this at the moment. It looks likely the patches will go in too - so that's not much of an arguement against. On Tue, 2020-06-16 at 16:35 +0300, אורי wrote: > I think master is the

Re: Overriding template blocks without copy/pasting entire template files

2020-06-16 Thread Arvind Nedumaran
Something must be faulty with my email delivery I suppose. I sent that email a good 8 hours ago. :) Onward, Arvind Sent from Outlook Mobile From: django-developers@googlegroups.com on behalf of Florian Apolloner Sent: Tuesday, June 16,

Re: Overriding template blocks without copy/pasting entire template files

2020-06-16 Thread Arvind Nedumaran
No worries  Sent from Outlook Mobile From: django-developers@googlegroups.com on behalf of Florian Apolloner Sent: Tuesday, June 16, 2020 7:40:56 PM To: Django developers (Contributions to Django itself) Subject: Re: Overriding

Re: What's wrong with the jenkins testrun failing on ASGI (I think?)

2020-06-16 Thread Andrew Godwin
Yup, I'm seeing if we can get asgiref fixed today, otherwise I'll revert the change that broke Django and issue 3.2.9. Andrew On Tue, Jun 16, 2020, at 2:48 AM, Florian Apolloner wrote: > Ok, so rebasing PRs to current master will fix this (leaving this here as > note for others who run into

Re: The blacklist / master issue

2020-06-16 Thread Adam Johnson
On the branch rename, right now I'd rather wait to see what GitHub builds that could help with this. It might allow aliasing master->main so that existing PR's don't need targeting, local clones don't need updating, etc. It also seems Git will make a change and it might be worth waiting to see

Re: The blacklist / master issue

2020-06-16 Thread Tom Carrick
On moving away from the master branch, it would be a lot of effort (not just in the repo, but docs, Trac, etc.), but I think it's worth doing regardless. I think there is often some reluctance to do something time-consuming because it takes someone's time away from technical issues. I don't think

Re: The blacklist / master issue

2020-06-16 Thread Andrew Godwin
I've definitely in favour of fixing all of the problematic word usage - after all, we eliminated master/slave from the database documentation years ago, we've just been a bit negligent at fixing the others. Agreed with Adam, though, about seeing what GitHub builds - they announced they're