Re: [5-for-1] Review request

[Aymeric Augustin]

Hello,

I would like a core dev's opinion on #11555.

The tickets I reviewed are listed here: http://myks.org/stuff/django_5-for-1.txt

Thanks,

-- 
Aymeric Augustin.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Jonas H.]

On 04/25/2011 05:33 PM, Jacob Kaplan-Moss wrote:

On Mon, Apr 25, 2011 at 10:28 AM, Jonas H.  wrote:

I'd like you to look into http://code.djangoproject.com/ticket/15696.


Done. Unfortunately, the result's probably not what you wanted. If
you'd like to re-use your review wuffie I'd happily take a look at
something else instead; just let me know.


That's nice, then please have a look at 
http://code.djangoproject.com/ticket/15799.


--
You received this message because you are subscribed to the Google Groups "Django 
developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Jacob Kaplan-Moss]

On Mon, Apr 25, 2011 at 10:28 AM, Jonas H.  wrote:
> I'd like you to look into http://code.djangoproject.com/ticket/15696.

Done. Unfortunately, the result's probably not what you wanted. If
you'd like to re-use your review wuffie I'd happily take a look at
something else instead; just let me know.

Jacob

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

[5-for-1] Review request

[Jonas H.]

Here's what I reviewed:

http://code.djangoproject.com/ticket/15783
http://code.djangoproject.com/ticket/15774
http://code.djangoproject.com/ticket/15801
http://code.djangoproject.com/ticket/15896
http://code.djangoproject.com/ticket/15895

I'd like you to look into http://code.djangoproject.com/ticket/15696.

Thanks!
Jonas

--
You received this message because you are subscribed to the Google Groups "Django 
developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Gabriel Hurley]

I noticed the "TODO" on the bottom of that page you linked... if you 
actually want to write something up for the docs about reviewing tickets 
(based on the discussion that's happened on the list the last few days) I'd 
suggest adding it to the /docs/howto/contribute section. Feel free to ping 
me if you get a patch written and I'll work with you on getting it in.

- Gabriel

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Jacob Kaplan-Moss]

On Fri, Apr 22, 2011 at 3:26 AM, Aymeric Augustin
 wrote:
> I have retroactively added 5 tickets for Alex's review, plus 5 tickets that
> I'd like to trade against a review of #15255, especially the second comment.

Done!

BTW, I'm pretty sure Alex was joking about you needing to do five
more, so double thanks. I really appreciate it - let's keep it up!

Jacob

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Aymeric Augustin]

2011/4/21 Alex Gaynor 

> As did I, do we have to retroactively require more reviews ;)
>

I'm now tracking my 5-for-1 deals here:
http://myks.org/stuff/django_5-for-1.txt

I have retroactively added 5 tickets for Alex's review, plus 5 tickets that
I'd like to trade against a review of #15255, especially the second comment.
Thanks!

By the way, we're down to 6 unreviewed tickets. Not everyone claims his
reviews :)

-- 
Aymeric Augustin.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Alex Gaynor]

On Thu, Apr 21, 2011 at 11:46 AM, Jacob Kaplan-Moss wrote:

> On Thu, Apr 21, 2011 at 8:05 AM, Aymeric Augustin
>  wrote:
> > I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd
> like
> > someone to take a look at #14091.
>
> Done - thank you! I left comments on the ticket.
>
> Jacob
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/django-developers?hl=en.
>
>

As did I, do we have to retroactively require more reviews ;)

Alex


-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Jacob Kaplan-Moss]

On Thu, Apr 21, 2011 at 8:05 AM, Aymeric Augustin
 wrote:
> I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd like
> someone to take a look at #14091.

Done - thank you! I left comments on the ticket.

Jacob

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

[5-for-1] Review request

[Aymeric Augustin]

Hello,

I suggest we gather review requests on this thread to make the core devs'
job easier (that is, until the thread becomes too long).

I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd like
someone to take a look at #14091.

Best regards,

-- 
Aymeric Augustin.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.