Re: Can we remove FILE_CHARSET?

2018-10-05 Thread Jon Dufresne
> Is that always available these days? (I'd guess yes.) I too would guess yes. I believe any reasonably modern text editor will support UTF-8 and even likely default to saving in that encoding. I know mine does. > Is is something we want to impose? Not sure. Are there people doing > otherwise?

Re: Can we remove FILE_CHARSET?

2018-10-04 Thread Vasili Korol
I guess, my statement doesn't apply if FILE_CHARSET only affects Django text files, so disregard. My point was that non-UTF data is still actively used despite the fact that "the whole world moved to Unicode". -- You received this message because you are subscribed to the Google Groups

Re: Can we remove FILE_CHARSET?

2018-10-03 Thread Carlton Gibson
Thanks for the follow-up Jon. I'll let Vasili follow-up on his use-case if possible/relevant. TBH I'm not at all sure about the SQL data files bit, which is in part why I asked here. (Encoding issues!) > Maybe that sentence should be rephrased to "template files, static files, and

Re: Can we remove FILE_CHARSET?

2018-10-03 Thread Jon Dufresne
> So Jon, are you basically saying that Vasili's concern shouldn't come up? Yeah, I think it shouldn't come up. But I'm not sure I fully understand Vasili's concern . Maybe if it was more specific with more details, I could better understand it. Django's documentation states:

Re: Can we remove FILE_CHARSET?

2018-10-03 Thread Adam Johnson
Jon's logic seems right to me. I find the lack of tests disturbing, and I wouldn't be surprised if there were other places where django loaded files from disk without using FILE_CHARSET when a user of that setting would expect it to be. On Wed, 3 Oct 2018 at 15:55, Carlton Gibson wrote: >

Re: Can we remove FILE_CHARSET?

2018-10-03 Thread Carlton Gibson
Thanks for the input everyone. So Jon, are you basically saying that Vasili's concern shouldn't come up? (That the whole "SQL data files" bit is misleading...?) -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)"

Re: Can we remove FILE_CHARSET?

2018-10-03 Thread Jon Dufresne
I'm the one that proposed this setting be removed. The settings is used in the following areas: > ./django/template/backends/django.py:23: options.setdefault('file_charset', settings.FILE_CHARSET) I suppose this is its main use case. The Django template engine defaults to loading files from

Re: Can we remove FILE_CHARSET?

2018-10-03 Thread Claude Paroz
We are not talking about general data encodings here, FILE_CHARSET is used to read Django text files from disk (template files, static files (css, js) or translation catalogs). So the question is mainly about encoding usage in text editors. Claude -- You received this message because you are

Re: Can we remove FILE_CHARSET?

2018-10-03 Thread Vasili Korol
Some Russian companies still store their old data (in databases and/or files) in KOI8-R. I'm not sure how many of them may be using Django, but I personally worked for a company in 2014-2015, that maintained a huge database of articles stored in KOI8-R. I can assume that, similarly, KOI8-U may