Re: GSoC 2020 Proposal for ModelStates in Migrations

Hey Simon I have made some more changes yet again. I would love for you to take one final look at it and again give me your valuable feedback before I make the final submission on the GSoC portal. Looking forward to hearing from you and working with everyone in the summer. 😁 https://gist.github.co

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hey Simon, Thank you for this clarification, I shall make some changes to my proposal accordingly. Again, my apologies if I seemed impatient. Kind regards Sanskar On Sun, Mar 29, 2020 at 3:02 AM charettes wrote: > Hey Sanskar, > > As Daryl mentioned don't expect an immediate response from me o

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hey Sanskar, As Daryl mentioned don't expect an immediate response from me or anyone on this list. > I still fail to understand how this would help ModelState get access to related db_types, (the problem that the mapping in my proposal aims to solve). If project state maintains a map of (app_

Re: GSoC 2020 Proposal for ModelStates in Migrations

Sorry, I didn’t mean to sound impatient . I understand that this pandemic is disrupting life everywhere and I hope everyone is safe and healthy. I will keep this in mind next time. Again, my apologies. Kind regards Sanskar On Sun, 29 Mar 2020 at 01:15, Daryl wrote: > Hi Sanskar, > > Please be p

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hi Sanskar, Please be patient with everyone - during this time, some countries are in terrible shape, others are coping well. In addition, even without Covid19, it is impossible to know what is going on with anybodies situation, and we are (almost) all donating our time. Regards. D On Sun, 29 Ma

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hey Simon, Could you kindly reply? 😅 Thanks Kind regards Sanskar On Fri, 27 Mar 2020 at 12:58, Sanskar Jaiswal wrote: > Hey Simon, > > While I certainly see the benefits of this, I still fail to understand how > this would help ModelState get access to related db_types, (the problem > that the

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hey Simon, While I certainly see the benefits of this, I still fail to understand how this would help ModelState get access to related db_types, (the problem that the mapping in my proposal aims to solve). Am I missing something here? Some more clarification/explanation would be highly helpful. K

Re: GSoC 2020 Proposal for ModelStates in Migrations

Thanks for the examples Sanskar. I think the mapping should be kept ProjetState instances and invalidated when state alterations are performed. In an ideal world I think that ProjectState should have methods mapping to all Operation subclasses state_forwards and these state_forwards methods sho

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hi Simon Taking advice into account, I have made some more changes to my proposal . Please check it out and criticize it wherever you think I could improve it as always. :) Also, could you kindly give some kind of idea as to when

Re: GSoC 2020 Proposal for ModelStates in Migrations

Thanks Sanskar, this iteration is much better. Now that you have a bit more details about your proposed changes breakdown I'd give a bit more examples of what a particular operation currently looks like now and you plan to change it. For example, you could describe how an AlterField operation c

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hey Simon I have made some changes to the proposal. I kindly request you to take a look at it and give any feedback you can :) https://gist.github.com/aryan9600/b1c2eaf445006c17e02e7677cf1098d5 Kind Regards Sanskar On Wed, 25 Mar 2020 at 23:57, charettes wrote: > Are you thinking about the

Re: GSoC 2020 Proposal for ModelStates in Migrations

Are you thinking about the Operation.state_forwards logic? I guess it would make it easier to test state alterations in isolation but I don't think it's necessary for this already large project. Cheers, Simon Le mercredi 25 mars 2020 06:05:22 UTC-4, Sanskar Jaiswal a écrit : > > Hey Simon > > J

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hey Simon Just so that I am more clear, is it favourable to move all logic that ModelOperations and FieldOperations implement right now to ProjectState and ModelState? Kind regards Sanskar On Tue, 24 Mar 2020 at 04:20, Sanskar Jaiswal wrote: > Hey Simon, > > Thank you for your feedback! It hel

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hey Simon, Thank you for your feedback! It helps a lot. I shall look into your doubts right now, and edit my proposal accordingly. Kind regards Sanskar On Tue, Mar 24, 2020 at 3:37 AM charettes wrote: > Hello Sanskar, > > Thank you for your submission, from a quick look it seems to be heading

Re: GSoC 2020 Proposal for ModelStates in Migrations

Understood. Thanks. On Monday, March 23, 2020 at 5:48:43 PM UTC-4, charettes wrote: > > Javier > > > I don't see how this solves anything. At the end of the day these "real" > models, or at the very least, not "fake" models will not have any custom > queryset/manager/properties/ > method you add

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hello Sanskar, Thank you for your submission, from a quick look it seems to be heading in the right direction. Would it be possible to break the large overview section into more granular sections where you describe how you roughly plan to tackle each of the point mention? I personally have do

Re: GSoC 2020 Proposal for ModelStates in Migrations

Hey Javier! So currently, during migrations, specifically during the state_forwards and database_forwards methods, Django renders a fake model and passes it down to the SchemEditor which is an expensive operation and slows down the process. The idea is to use ModelStates instead of Models, as thei

Re: GSoC 2020 Proposal for ModelStates in Migrations

Javier > I don't see how this solves anything. At the end of the day these "real" models, or at the very least, not "fake" models will not have any custom queryset/manager/properties/ method you add to it. Can you explain what it is you're trying to accomplish? I don't think that's the goal of

Re: GSoC 2020 Proposal for ModelStates in Migrations

I don't see how this solves anything. At the end of the day these "real" models, or at the very least, not "fake" models will not have any custom queryset/manager/properties/method you add to it. Can you explain what it is you're trying to accomplish? On Monday, March 23, 2020 at 12:59:55 PM UT