Re: Should the docs suggest namespace packages?

2020-07-20 Thread Florian Apolloner
There are also various issues in python itself like https://bugs.python.org/issue23882 -- so I strongly recommend against namespace packages unless you actually need them. On Monday, July 20, 2020 at 1:14:41 AM UTC+2 re...@fleschenberg.net wrote: > Hi, > > On 7/19/20 10:25 PM, Tim Graham

Re: Should the docs suggest namespace packages?

2020-07-19 Thread René Fleschenberg
Hi, On 7/19/20 10:25 PM, Tim Graham wrote: > Another commenter remarked, "We had a similar issue with test discovery. > One of our developers read an article that __init__.py files are not > required on Python3 and started removing them. Everything seemingly > worked but some tests were not

Re: Should the docs suggest namespace packages?

2020-07-19 Thread Tim Graham
(It was already reverted in 578b3046e3b4adc43655bb5dd955054b7bf19f89. Sorry if raising a related issue on this thread was confusing.) On Sunday, July 19, 2020 at 4:27:59 PM UTC-4 Aymeric Augustin wrote: > I was still planning to revert ccc25bf. It's just a matter of finding time. > > -- >

Re: Should the docs suggest namespace packages?

2020-07-19 Thread Aymeric Augustin
I was still planning to revert ccc25bf. It's just a matter of finding time. -- Aymeric. > On 19 Jul 2020, at 22:25, Tim Graham wrote: > > On the topic of namespace packages, I noticed this line in the 3.1 release > notes: "Migrations are now loaded also from directories without __init__.py

Re: Should the docs suggest namespace packages?

2020-07-19 Thread Tim Graham
On the topic of namespace packages, I noticed this line in the 3.1 release notes: "Migrations are now loaded also from directories without __init__.py files." https://code.djangoproject.com/ticket/30300 The ticket's rationale seems to be "We've just finished migrating our codebase to

Re: Should the docs suggest namespace packages?

2020-05-21 Thread Adam Johnson
+1 for reverting ccc25bf . On Wed, 20 May 2020 at 19:54, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > Hello, > > Commit ccc25bf refers to ticket #23919 in the commit message. In that > ticket, I argued that the __init__.py files should be kept: >

Re: Should the docs suggest namespace packages?

2020-05-20 Thread Aymeric Augustin
Hello, Commit ccc25bf refers to ticket #23919 in the commit message. In that ticket, I argued that the __init__.py files should be kept: https://code.djangoproject.com/ticket/23919#comment:102 . No one brought a counter argument. It's

Re: Should the docs suggest namespace packages?

2020-05-20 Thread James Bennett
The use case for namespace packages is the ability to fragment portions of a single package across multiple disparate locations on the filesystem. And, potentially, to install or selectively enable/disable access to only certain sub-portions of the package by choosing which parts are present or by

Re: Should the docs suggest namespace packages?

2020-05-20 Thread Carlton Gibson
As far as I can see, standard packages are what users want in almost every case. So +1. (Q:What is the use-case for namespace packages?) > On 20 May 2020, at 12:44, René Fleschenberg wrote: > > Hi, > > https://github.com/django/django/pull/12939 > > My opinion on this is not particularly