Re: URL dispatching framework: feedback requested

2016-05-11 Thread Tim Graham
I'm not targeting this for 1.10. The patch hasn't been under review and is likely too much to review in a couple days. Also documentation remains outstanding. On Wednesday, May 11, 2016 at 12:52:33 PM UTC-4, Asif Saifuddin wrote: > > Can we expect this to be merged on 1.10 alpha? after that the

Re: URL dispatching framework: feedback requested

2016-05-11 Thread Asif Saifuddin
Can we expect this to be merged on 1.10 alpha? after that the minor imporvements could be take place. Thanks On Monday, December 28, 2015 at 10:23:19 PM UTC+6, Marten Kenbeek wrote: > > Hi everyone, > > This past week I've made some great progress in rewriting the URL > dispatcher framework and

Re: URL dispatching framework: feedback requested

2016-03-07 Thread Tim Graham
Hi Marten, How are things going? Do you plan to make a push to merge this for 1.10? The alpha is scheduled for May 16. Are you still waiting for feedback? I think writing documentation would certainly facilitate that. Also, if there's any chance to break the existing commit into some smaller lo

Re: URL dispatching framework: feedback requested

2016-01-14 Thread James Addison
Marten, As you likely remember, I've been running your code for a few months now, overall it's been pretty good. I mentioned some time ago that the list of URLs displayed with `DEBUG=True` when triggering a 404 is sometimes empty, or partially empty. This still happens for me, and I believe

Re: URL dispatching framework: feedback requested

2016-01-08 Thread Marten Kenbeek
The first argument to Constraint.construct() is a URL helper object which allows you to set the scheme, host, path, querystring and fragment separately. So reversing a domain constraint is as simple as this: class DomainConstraint(Constraint): ... def construct(self, url_object, *args, *

Re: URL dispatching framework: feedback requested

2016-01-04 Thread Aymeric Augustin
On 4 janv. 2016, at 13:24, Tim Graham wrote: > It looks to me like the rationale for the existing organization is that > everything in that module is designed to be used in a URLconf. I believe it is. However, as I said on the pull request, most users won’t reverse engineer this subtlety. I th

Re: URL dispatching framework: feedback requested

2016-01-04 Thread Tim Graham
It looks to me like the rationale for the existing organization is that everything in that module is designed to be used in a URLconf. Do you propose to make everything importable from "django.urls" or from "django.urls.conf" or some other organization? If we remove urls from django.conf, then