Re: What do you think about unify templates feature?

2019-01-19 Thread J . Pablo Martín Cobos
Bonus track: If you have a template with complete HTML (without blocks). You can add to this command another features like compress HTML or use line styles (using pyliner[1]) and win more time yet :-) Because this feature does not consume run time, but this feature waste preprocessing time, like co

Re: What do you think about unify templates feature?

2019-01-19 Thread J . Pablo Martín Cobos
I reply between lines, El sáb., 19 ene. 2019 a las 12:31, Adam Johnson () escribió: > I agree, I'd like to see a third party package too. > If I have any time I will do it. And I will say something in this thread. > > I'm all up for seeing improvements in template rendering speed but working

Re: What do you think about unify templates feature?

2019-01-19 Thread J . Pablo Martín Cobos
I reply between lines, El sáb., 19 ene. 2019 a las 11:00, Jani Tiainen () escribió: > Hi. > > Unfortunately Django is already big. Every new feature requires careful > consideration since it adds maintenance burden to already loaded > maintainers. > Yes, I know it. > > So best and pretty much

Re: What do you think about unify templates feature?

2019-01-19 Thread Adam Johnson
I agree, I'd like to see a third party package too. I'm all up for seeing improvements in template rendering speed but working code in a third party package is way more valuable than more discussion. Many of Django's major features in the past (e.g. SecurityMiddleware, Migrations) were third party

Re: What do you think about unify templates feature?

2019-01-19 Thread Jani Tiainen
Hi. Unfortunately Django is already big. Every new feature requires careful consideration since it adds maintenance burden to already loaded maintainers. So best and pretty much only way to make your feature appear in Django itself is to prove that your solution is widely adopted in everyday use

Re: What do you think about unify templates feature?

2019-01-19 Thread J . Pablo Martín Cobos
El sáb., 19 ene. 2019 7:08, Jani Tiainen escribió: > Hi, > > You said that this doesn't require any change in Django at all. > > So this doesn't need to be in Django at all, it can survive as its own and > that way it should be. > > So make your enhancement as reusable app and release it to publi

Re: What do you think about unify templates feature?

2019-01-18 Thread Jani Tiainen
Hi, You said that this doesn't require any change in Django at all. So this doesn't need to be in Django at all, it can survive as its own and that way it should be. So make your enhancement as reusable app and release it to public. Get people to use it. Fix the bugs that appears. Write a good d

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
I reply beetween lines, El vie., 18 ene. 2019 a las 21:25, Jani Tiainen () escribió: > Hi, > > Lets try this again. > > Your system could be nice if it really helps rendering speed. > Yes we get several miliseconds per request. > > But does it require changes in Django core itself, or is it co

Re: What do you think about unify templates feature?

2019-01-18 Thread Jani Tiainen
Hi, Lets try this again. Your system could be nice if it really helps rendering speed. But does it require changes in Django core itself, or is it completely standalone package that doesn't require changing Django itself to operate? If it requires changes in Django itself, it would be useful to

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
Sorry, I reply beetween lines El vie., 18 ene. 2019 16:32, J. Pablo Martín Cobos escribió: > Hi another time, > > I am tring to reply every people in this email: > > Josh > > I was not using django.template.loaders.cached.Loader, but the result are > very similar i.e: > > App Template Num templa

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
Hi another time, I am tring to reply every people in this email: Josh I was not using django.template.loaders.cached.Loader, but the result are very similar i.e: App Template Num templates rendered before unify Num templates rendered after unify AVG Time render template before unify (ms) AVG Ti

Re: What do you think about unify templates feature?

2019-01-18 Thread Jani Tiainen
Hi. Does this require changes to django internals or can it work as an external package? Also you should release it as a package so people can start using it, also preferably releasing it with BSD license like Django itself is. Otherwise there are very little chances that your solution would make

Re: What do you think about unify templates feature?

2019-01-18 Thread Pavlos Georgiadis
Hi, I guess the reason you wrote to this list about your unify command, is because you don't mind contributing it to the django project. So maybe you could show the code of this command, so people can understand what improvements it can offer. I am not sure I understood anything so far. Are you

Re: What do you think about unify templates feature?

2019-01-18 Thread Josh Smeaton
Are you using https://docs.djangoproject.com/en/2.1/ref/templates/api/#django.template.loaders.cached.Loader in your tests? And you should find a way to test rendering from the command line, which will allow you to get much better timing information. On Friday, 18 January 2019 20:40:29 UTC+11

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
I answer between lines El vie., 18 ene. 2019 a las 5:03, shiva kumar (< kannamshivakumar...@gmail.com>) escribió: > Could you please explain about it. I hadn't understood ur idea. > 1. Currently: with you render a view, this render a template. But usually, this template extends of anothe

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
I answer between lines El jue., 17 ene. 2019 a las 18:42, Maciek Olko () escribió: > Did you try to measure the difference in time of rendering standard and > your way? > > Yes. I have several examples: App Template Num templates rendered before unify Num templates rendered after unify Time rend

Re: What do you think about unify templates feature?

2019-01-17 Thread shiva kumar
Could you please explain about it. I hadn't understood ur idea. On Thu 17 Jan, 2019 2:32 pm J. Pablo Martín Cobos Hi, > > From one year ago, I am using an own command for Django templates that > unify them. With an example it is easy to see. If I am to render for > example a template call news.ht

Re: What do you think about unify templates feature?

2019-01-17 Thread Maciek Olko
Did you try to measure the difference in time of rendering standard and your way? Regards, Maciej czw., 17.01.2019, 10:02 użytkownik J. Pablo Martín Cobos napisał: > Hi, > > From one year ago, I am using an own command for Django templates that > unify them. With an example it is easy to see. I