Re: e-mail changed to email in email validator

[Skylar Saveland]

right-0, thanks guys. I must be getting old- I remember the style 
guidelines saying hyphen and thinking the hyphen was a little weird :)

Cheers!

On Wednesday, December 19, 2012 1:33:09 PM UTC-8, Mark Lavin wrote:
>
> This was changed as part of https://code.djangoproject.com/ticket/17899
>
> Best,
>
> Mark
>
> On Wednesday, December 19, 2012 4:23:24 PM UTC-5, Skylar Saveland wrote:
>>
>> I checked out 1.5 branch today and found a change that I can't find the 
>> debate/announcement for: e-mail to email in
>>
>> django/core/validators.py:validate_email = EmailValidator(email_re, 
>> _('Enter a valid email address.'), 'invalid')
>>
>> This change has me with
>>
>> # in 1.4.x it is:
>> #error = 'Enter a valid e-mail address.'
>> # in 1.5.x it is:
>> #error = 'Enter a valid email address.'
>> #self.assertFormError(res, 'form', 'email', error)
>>
>> ❯ git checkout 1.4.3
>> ❯ grep -r "Enter a valid email address." *
>> (Nothing there)
>> ~/Code/github/django (1f0af3c) ...
>>
>> > git checkout master
>> ~/Code/github/django (master) ↑
>> ❯ grep -r "Enter a valid email address." *
>>  (lot's of stuff)
>>
>> I'm sure this was discussed and noted somewhere; but, where?
>>
>> -Skylar
>>
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/django-developers/-/T0F0ChaastQJ.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: e-mail changed to email in email validator

[Russell Keith-Magee]

On Thu, Dec 20, 2012 at 5:23 AM, Skylar Saveland
wrote:

> I checked out 1.5 branch today and found a change that I can't find the
> debate/announcement for: e-mail to email in
>
> django/core/validators.py:validate_email = EmailValidator(email_re,
> _('Enter a valid email address.'), 'invalid')
>
> This change has me with
>
> # in 1.4.x it is:
> #error = 'Enter a valid e-mail address.'
> # in 1.5.x it is:
> #error = 'Enter a valid email address.'
> #self.assertFormError(res, 'form', 'email', error)
>
> ❯ git checkout 1.4.3
> ❯ grep -r "Enter a valid email address." *
> (Nothing there)
> ~/Code/github/django (1f0af3c) ...
>
> > git checkout master
> ~/Code/github/django (master) ↑
> ❯ grep -r "Enter a valid email address." *
>  (lot's of stuff)
>
> I'm sure this was discussed and noted somewhere; but, where?
>

As Mark noted, this is all a result of ticket #17899; however, there really
wasn't a "discussion" per se. Django comes from a journalism background,
and as such, we follow the Associated Press (AP) stylebook for language
rules. In early 2011, AP announced they were changing their rules regarding
email vs e-mail [1]; this was reported in a ticket, but a little too late
for the 1.4 release, so it has been integrated into 1.5.

[1] https://twitter.com/APStylebook/status/48798366980780033

Yours,
Russ Magee %-)

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: e-mail changed to email in email validator

[Mark Lavin]

This was changed as part of https://code.djangoproject.com/ticket/17899

Best,

Mark

On Wednesday, December 19, 2012 4:23:24 PM UTC-5, Skylar Saveland wrote:
>
> I checked out 1.5 branch today and found a change that I can't find the 
> debate/announcement for: e-mail to email in
>
> django/core/validators.py:validate_email = EmailValidator(email_re, 
> _('Enter a valid email address.'), 'invalid')
>
> This change has me with
>
> # in 1.4.x it is:
> #error = 'Enter a valid e-mail address.'
> # in 1.5.x it is:
> #error = 'Enter a valid email address.'
> #self.assertFormError(res, 'form', 'email', error)
>
> ❯ git checkout 1.4.3
> ❯ grep -r "Enter a valid email address." *
> (Nothing there)
> ~/Code/github/django (1f0af3c) ...
>
> > git checkout master
> ~/Code/github/django (master) ↑
> ❯ grep -r "Enter a valid email address." *
>  (lot's of stuff)
>
> I'm sure this was discussed and noted somewhere; but, where?
>
> -Skylar
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/django-developers/-/llep9CQUXqwJ.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.