Re: how to deal with inspect.getargspec() deprecation?

2015-06-13 Thread Tim Graham
I ended up abstracting our usage of inspect.getargspec() into some utility methods in a django.utils.inspect module. Each method has a separate branch for Python 2 and Python 3. It's not ideal, but I think it's preferable to adding a short-lived dependency or vendored copy, considering that

Re: how to deal with inspect.getargspec() deprecation?

2015-06-10 Thread Tim Graham
The APIs are rather different. I will keep working on the conversions (we'll need them no matter which option we pick), but here's a flavor: https://github.com/django/django/pull/4846 On Wednesday, June 10, 2015 at 3:50:52 PM UTC-4, Carl Meyer wrote: > > On 06/10/2015 01:48 PM, Berker Peksağ

Re: how to deal with inspect.getargspec() deprecation?

2015-06-10 Thread Berker Peksağ
On Wed, Jun 10, 2015 at 9:49 PM, Tim Graham wrote: > inspect.getargspec() was deprecated in Python 3.0 and will be removed in 3.6 > (ETA late 2016). It started throwing a deprecation warning in Python 3.5 > which causes some test failures when we check the number of

Re: how to deal with inspect.getargspec() deprecation?

2015-06-10 Thread Carl Meyer
On 06/10/2015 01:48 PM, Berker Peksağ wrote: > On Wed, Jun 10, 2015 at 9:49 PM, Tim Graham wrote: >> inspect.getargspec() was deprecated in Python 3.0 and will be removed in 3.6 >> (ETA late 2016). It started throwing a deprecation warning in Python 3.5 >> which causes some

Re: how to deal with inspect.getargspec() deprecation?

2015-06-10 Thread Marc Tamlyn
I'm not sure how similar the return values are, is it possible to write (and contribute upstream) a six move? Perhaps this is impossible without funcsigs though. Marc On 10 June 2015 at 20:09, Carl Meyer wrote: > On 06/10/2015 12:49 PM, Tim Graham wrote: > >

Re: how to deal with inspect.getargspec() deprecation?

2015-06-10 Thread Carl Meyer
On 06/10/2015 12:49 PM, Tim Graham wrote: > inspect.getargspec() was deprecated in Python 3.0 and will be removed in > 3.6 (ETA late 2016). It started throwing a deprecation warning in Python > 3.5 which causes some test failures when we check the number of > deprecation warnings so I'd like to