[Django] #28349: Release notes should detail which version they're 'coming from' and LTS release notes should include/link all changes since previous LTS

2017-06-29 Thread Django
#28349: Release notes should detail which version they're 'coming from' and LTS
release notes should include/link all changes since previous LTS
-+
   Reporter:  eduvik |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  1.11
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 If I want to upgrade from the previous LTS (1.8) to the current (1.11)
 (presumably a common upgrade path) and go to the release
 notes/incompatible changes for 1.11
 (https://docs.djangoproject.com/en/1.11/releases/1.11/#backwards-
 incompatible-changes-in-1-11) then it doesn't specify which version the
 changes are incompatible with. Firstly, (for LTS releases at least) it
 would be good to say something like 'changes since version 1.10'.
 Secondly, for LTS releases, it would be ideal to 'roll up' all backwards
 incompatible changes (or even all changes) since the last LTS, or, failing
 that, include links to all of the release notes since the previous LTS.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.64e75cf665fc286f0b367a9d69c14e19%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #56: Primary key columns should be UNSIGNED

2017-06-29 Thread Django
#56: Primary key columns should be UNSIGNED
-+-
 Reporter:  Manuzhai |Owner:  (none)
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  mysql| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.3c0c996d6109bf7ecb2d52d01328894d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28347: Allow custom attributes for model fields

2017-06-29 Thread Django
#28347: Allow custom attributes for model fields
-+-
 Reporter:  Tom Turner   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Someday/Maybe


Comment:

 Please write to the DevelopersMailingList to see if there's consensus.
 Perhaps someone will have an idea about a more elegant approach.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.92462dffd11997dde488be28ad59c608%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28348: runtests.py fails if xgettext utility is not on system path

2017-06-29 Thread Django
#28348: runtests.py fails if xgettext utility is not on system path
-+-
 Reporter:  Evan Grim|Owner:  Evan Grim
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  testing skip | Triage Stage:
  xgettext runtests  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Evan Grim):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Fixed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8173052f8fc0306cda3f930eacf56e01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #28348: runtests.py fails if xgettext utility is not on system path

2017-06-29 Thread Django
#28348: runtests.py fails if xgettext utility is not on system path
-+-
   Reporter:  Evan Grim  |  Owner:  Evan Grim
   Type:  Bug| Status:  assigned
  Component:  Testing|Version:  1.11
  framework  |   Keywords:  testing skip
   Severity:  Normal |  xgettext runtests
   Triage Stage: |  Has patch:  1
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Running the tests (with {{{runtests.py}}}) fails if the {{{xgettext}}}
 utility is not on the system path.

 Error report:
 {{{
 ==
 ERROR: i18n.test_extraction (unittest.loader._FailedTest)
 --
 Traceback (most recent call last):
   File
 
"/usr/local/Cellar/python3/3.6.1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py",
 line 59, in testPartExecutor
 yield
   File
 
"/usr/local/Cellar/python3/3.6.1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py",
 line 601, in run
 testMethod()
   File
 
"/usr/local/Cellar/python3/3.6.1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/loader.py",
 line 34, in testFailure
 raise self._exception
 ImportError: Failed to import test module: i18n.test_extraction
 Traceback (most recent call last):
   File
 
"/usr/local/Cellar/python3/3.6.1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/loader.py",
 line 428, in _find_test_path
 module = self._get_module_from_name(name)
   File
 
"/usr/local/Cellar/python3/3.6.1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/loader.py",
 line 369, in _get_module_from_name
 __import__(name)
   File "/Users/egrim/scratch/django/tests/i18n/test_extraction.py", line
 28, in 
 requires_gettext_019 = skipIf(gettext_version < (0, 19), 'gettext 0.19
 required')
 TypeError: '<' not supported between instances of 'NoneType' and 'tuple'


 --
 Ran 11482 tests in 83.136s

 FAILED (errors=1, skipped=734, expected failures=4)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.866b2293d9d056c4bc47bb5b669ae29b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28347: Allow custom attributes for model fields

2017-06-29 Thread Django
#28347: Allow custom attributes for model fields
-+-
 Reporter:  Tom Turner   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tom Turner):

 I would have to write a custom field for all the different types of models
 that i use CharField, FloatField, ForeignKey, PositiveSmallIntegerField,
 IntegerField etc

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.01774e46ff21294a9c3fb2f2497b6525%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28347: Allow custom attributes for model fields (was: Adding custom attributes to django model field)

2017-06-29 Thread Django
#28347: Allow custom attributes for model fields
-+-
 Reporter:  Tom Turner   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  Uncategorized => New feature
 * component:  Uncategorized => Database layer (models, ORM)


Comment:

 What's the problem with writing a custom model field? My inclination is
 that allowing a dictionary of arbitrary options isn't a good design as it
 can be used and abused for any purpose and different Django applications
 might choose conflicting key names for different purposes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.aa1a696abf38780b3536e07e047b16b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28347: Adding custom attributes to django model field

2017-06-29 Thread Django
#28347: Adding custom attributes to django model field
---+--
 Reporter:  Tom Turner |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.11
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Description changed by Tom Turner:

Old description:

> I want to add a custom attributes to a Django model field
>

> {{{
> name = models.CharField(max_length=255, data_merge=True)
> }}}
>

> I want to do this so i can loop round my fields and see if this field is
> set.
>
> {{{
> for field in Project._meta.get_fields(include_parents=False,
> include_hidden=False):
> if field.extra_info.data_merge:
>// do something here
> }}}
>
> I haven't been the first to ask for this see
> [https://stackoverflow.com/questions/20679057/adding-custom-attributes-
> to-django-model-field]
>
> I understand that you might say if you allow any attribute won't be good
> as it could have error. So one could do
>
> {{{
> name = models.CharField(max_length=255, meta_data={'data_merge':True})
> }}}
>

> If you accept this enhancement I am happy to write a patch, test and
> documentation. Please let me know.

New description:

 I want to add a custom attributes to a Django model field


 {{{
 name = models.CharField(max_length=255, data_merge=True)
 }}}


 I want to do this so i can loop round my fields and see if this field is
 set.

 {{{
 for field in Project._meta.get_fields(include_parents=False,
 include_hidden=False):
 if field.extra_info.data_merge:
// do something here
 }}}

 I haven't been the first to ask for this see
 [https://stackoverflow.com/questions/20679057/adding-custom-attributes-to-
 django-model-field]

 I understand that you might not won't any attribute won't be good as it
 could hide error. So one could do

 {{{
 name = models.CharField(max_length=255, meta_data={'data_merge':True})
 }}}


 If you accept this enhancement I am happy to write a patch, test and
 documentation. Please let me know.

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9f5aea91ab63388593ee1ebca6732fb3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28347: Adding custom attributes to django model field

2017-06-29 Thread Django
#28347: Adding custom attributes to django model field
---+--
 Reporter:  Tom Turner |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.11
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Old description:

> I want to add a custom attributes to a Django model field
>

> {{{
> name = models.CharField(max_length=255, data_merge=True)
> }}}
>

> I want to do this so i can loop round my fields and see if this field is
> set.
>
> {{{
> for field in Project._meta.get_fields(include_parents=False,
> include_hidden=False):
> if field.extra_info.data_merge:
>// do something here
> }}}
>
> I haven't been the first to ask for this see
> [https://stackoverflow.com/questions/20679057/adding-custom-attributes-
> to-django-model-field]
>
> If you accept this enhancement I am happy to write a patch, test and
> documentation. Please let me know.

New description:

 I want to add a custom attributes to a Django model field


 {{{
 name = models.CharField(max_length=255, data_merge=True)
 }}}


 I want to do this so i can loop round my fields and see if this field is
 set.

 {{{
 for field in Project._meta.get_fields(include_parents=False,
 include_hidden=False):
 if field.extra_info.data_merge:
// do something here
 }}}

 I haven't been the first to ask for this see
 [https://stackoverflow.com/questions/20679057/adding-custom-attributes-to-
 django-model-field]

 I understand that you might say if you allow any attribute won't be good
 as it could have error. So one could do

 {{{
 name = models.CharField(max_length=255, meta_data={'data_merge':True})
 }}}


 If you accept this enhancement I am happy to write a patch, test and
 documentation. Please let me know.

--

Comment (by Tom Turner):

 Replying to [ticket:28347 Tom Turner]:
 > I want to add a custom attributes to a Django model field
 >
 >
 > {{{
 > name = models.CharField(max_length=255, data_merge=True)
 > }}}
 >
 >
 > I want to do this so i can loop round my fields and see if this field is
 set.
 >
 > {{{
 > for field in Project._meta.get_fields(include_parents=False,
 include_hidden=False):
 > if field.extra_info.data_merge:
 >// do something here
 > }}}
 >
 > I haven't been the first to ask for this see
 [https://stackoverflow.com/questions/20679057/adding-custom-attributes-to-
 django-model-field]
 >
 > If you accept this enhancement I am happy to write a patch, test and
 documentation. Please let me know.
 >

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6183cf089a6fa4d2c7523d8c735d7de7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28347: Adding custom attributes to django model field

2017-06-29 Thread Django
#28347: Adding custom attributes to django model field
---+--
 Reporter:  Tom Turner |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.11
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Description changed by Tom Turner:

Old description:

> I want to add a custom attributes to a Django model field
>

> {{{
> name = models.CharField(max_length=255, **data_merge=True**)
> }}}
>

> I want to do this so i can loop round my fields and see if this field is
> set.
>
> {{{
> for field in Project._meta.get_fields(include_parents=False,
> include_hidden=False):
> if field.extra_info.data_merge:
>// do something here
> }}}
>
> I haven't been the first to ask for this see
> [https://stackoverflow.com/questions/20679057/adding-custom-attributes-
> to-django-model-field]
>
> If you accept this enhancement I am happy to write a patch, test and
> documentation. Please let me know.

New description:

 I want to add a custom attributes to a Django model field


 {{{
 name = models.CharField(max_length=255, data_merge=True)
 }}}


 I want to do this so i can loop round my fields and see if this field is
 set.

 {{{
 for field in Project._meta.get_fields(include_parents=False,
 include_hidden=False):
 if field.extra_info.data_merge:
// do something here
 }}}

 I haven't been the first to ask for this see
 [https://stackoverflow.com/questions/20679057/adding-custom-attributes-to-
 django-model-field]

 If you accept this enhancement I am happy to write a patch, test and
 documentation. Please let me know.

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0a44523b6323acd4509c65d270924197%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28010: Add support for SELECT...FOR UPDATE OF

2017-06-29 Thread Django
#28010: Add support for SELECT...FOR UPDATE OF
-+-
 Reporter:  Ran Benita   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b9f7dce84b7ab5e198129030eae6c1a4aec83d24" b9f7dce8]:
 {{{
 #!CommitTicketReference repository=""
 revision="b9f7dce84b7ab5e198129030eae6c1a4aec83d24"
 Fixed #28010 -- Added FOR UPDATE OF support to
 QuerySet.select_for_update().
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.024ec28ae41261b7bc915f47a0525088%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #28347: Adding custom attributes to django model field

2017-06-29 Thread Django
#28347: Adding custom attributes to django model field
-+
   Reporter:  Tom Turner |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  1.11
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 I want to add a custom attributes to a Django model field


 {{{
 name = models.CharField(max_length=255, **data_merge=True**)
 }}}


 I want to do this so i can loop round my fields and see if this field is
 set.

 {{{
 for field in Project._meta.get_fields(include_parents=False,
 include_hidden=False):
 if field.extra_info.data_merge:
// do something here
 }}}

 I haven't been the first to ask for this see
 [https://stackoverflow.com/questions/20679057/adding-custom-attributes-to-
 django-model-field]

 If you accept this enhancement I am happy to write a patch, test and
 documentation. Please let me know.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.94bd91b97501357c30d217067abe0ef4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27670: Loading shell crashes when pythonrc file contains error

2017-06-29 Thread Django
#27670: Loading shell crashes when pythonrc file contains error
-+-
 Reporter:  Peter Inglesby   |Owner:  Peter
 |  Inglesby
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  1.10
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 [https://github.com/django/django/pull/8688 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ac9be2d25cdd3de1d584bd270339cf87%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28280: numberformat.format() incorrectly formats large/tiny floats in scientific notation

2017-06-29 Thread Django
#28280: numberformat.format() incorrectly formats large/tiny floats in 
scientific
notation
---+
 Reporter:  Wil Tan|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Utilities  |  Version:  1.11
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"b94d99af5b6692476ad1722682eedbe076985654" b94d99af]:
 {{{
 #!CommitTicketReference repository=""
 revision="b94d99af5b6692476ad1722682eedbe076985654"
 Refs #28280 -- Added more tests for utils.numberformat.format().
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.539d5d3679672a78dbf968c6264c61a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28346: Misleading error message when validator cannot be serialized

2017-06-29 Thread Django
#28346: Misleading error message when validator cannot be serialized
-+-
 Reporter:  Peter Inglesby   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.11
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Peter Inglesby):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Poking about at this some more, I think it is possible to serialize the
 validator in my example, because the `validate_max_words(300)` returns a
 function object that has a `__closure__` attribute which contains bindings
 to the environment in which the function object was created.

 I'm not sure though how reliable this would be for less simple examples,
 and given how easy it is to work around, I think the new error message is
 good enough.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1de0a43649728746a34f787a7790%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28277: Validate that annotate() and aggregate() args and kwarg values are expressions

2017-06-29 Thread Django
#28277: Validate that annotate() and aggregate() args and kwarg values are
expressions
-+-
 Reporter:  Tim Graham   |Owner:  felixxm
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6e228d0b659c9779da7d392a75c7d2fbb42fb3cb" 6e228d0b]:
 {{{
 #!CommitTicketReference repository=""
 revision="6e228d0b659c9779da7d392a75c7d2fbb42fb3cb"
 Fixed #28277 -- Added validation of QuerySet.annotate() and aggregate()
 args.

 Thanks Tim Graham and Nick Pope for reviews.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f392c5122a172c06866d8012c38a4539%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26522: Non-deterministic crash in django.db.models.sql.Query.combine()

2017-06-29 Thread Django
#26522: Non-deterministic crash in django.db.models.sql.Query.combine()
-+-
 Reporter:  Ole Laursen  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"f7f5edd50d03e8482f8a6da5fb5202b895d68cd6" f7f5edd]:
 {{{
 #!CommitTicketReference repository=""
 revision="f7f5edd50d03e8482f8a6da5fb5202b895d68cd6"
 Removed obsolete Query.tables attribute.

 Obsolete since Query.alias_map became an OrderedDict (refs #26522).
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.caa6d8139cb58aa79f719f52282e2860%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28346: Misleading error message when validator cannot be serialized

2017-06-29 Thread Django
#28346: Misleading error message when validator cannot be serialized
-+-
 Reporter:  Peter Inglesby   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  Uncategorized => Cleanup/optimization


Comment:

 That error message is gone in master because Python 2 support is removed.
 The new error is something like "ValueError: Could not find function
 validator in app.models." I'm not sure if it's possible to serialize this
 case, if the error message could be improved, or if we can close this
 ticket. What do you think?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3d3f9cf3be46d8a48b4eedb40e95a8ef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28334: contrib.postgresql overwhelms database with "select from pg_type" queries on each request

2017-06-29 Thread Django
#28334: contrib.postgresql overwhelms database with "select from pg_type" 
queries
on each request
-+-
 Reporter:  Igor Gumenyuk|Owner:  Igor
 Type:   |  Gumenyuk
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.postgres |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * needs_tests:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fc8af1d1f91062f048580b8766545b23%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27670: Loading shell crashes when pythonrc file contains error (was: Genuine ImportError masked by exception handling code when loading shell)

2017-06-29 Thread Django
#27670: Loading shell crashes when pythonrc file contains error
-+-
 Reporter:  Peter Inglesby   |Owner:  Peter
 |  Inglesby
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  1.10
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Peter Inglesby:

Old description:

> When I run `./manage.py shell`, I get `ImportError: Couldn't load any of
> the specified interfaces.`
>
> It turns out that there's a problem with my readline installation which
> causes an `ImportError`.  This `ImportError` is caught and discarded by
> the `except ImportError` in
> `django.core.management.commands.shell.Command.handle`.
>
> Pull request incoming.

New description:

 If a pythonrc file (either `~/.pythonrc`, or `$PYTHONHOME`) causes an
 exception, then `./manage.py shell` crashes.

 By contrast, CPython prints the exception and continues.

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.7f705a10c14efc6510a3cd9e6a9cd45d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28297: Same queryset result in two different queries on ORM

2017-06-29 Thread Django
#28297: Same queryset result in two different queries on ORM
-+-
 Reporter:  Marcus Renno |Owner:  Marcus
 |  Renno
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  join, annotation, F  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Marcus Renno):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.2ea9c6e3e66efd9196b4e58f9e72cc8c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #28346: Misleading error message when validator cannot be serialized

2017-06-29 Thread Django
#28346: Misleading error message when validator cannot be serialized
--+
   Reporter:  Peter Inglesby  |  Owner:  nobody
   Type:  Uncategorized   | Status:  new
  Component:  Migrations  |Version:  1.11
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 I have a validator factory that looks like this:

 {{{
 def validate_max_words(max_words):
 def validator(value):
 num_words = len(value.split())
 if num_words > max_words:
 raise ValidationError(f'Field is too long: {num_words} words /
 {max_words} limit')
 return validator
 }}}

 and I would like to use it in a field definition like this:

 {{{
 description = models.TextField(validators=[validate_max_words(300)])
 }}}

 However, when running a migration to create the model in question, I get
 the following error:

 {{{
 ValueError: Could not find function validator in myapp.validators.
 Please note that due to Python 2 limitations, you cannot serialize unbound
 method functions (e.g. a method declared and used in the same class body).
 Please move the function into the main module body to use migrations.
 For more information, see
 https://docs.djangoproject.com/en/1.11/topics/migrations/#serializing-
 values
 }}}

 The error message is misleading, in that it assumes that because the
 validator cannot be serialized, it must be an unbound method.  However,
 this is not the case -- the validator is instead a function that's
 returned by another function.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.e79eaa9572e0e0fce40fb8abe76e7892%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.