subject:"\[Django\] #14370\: Adding support for Autocomplete in contrib.admin"

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  Germano Gabbianelli  |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by James Pic):

 Ok so I was wrong, here's the new ticket for this issue:
 https://github.com/select2/select2/issues/4733

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.61665c7acfa90591e4ac1630b6d9869d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  Germano Gabbianelli  |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by James Pic):

 This is the code that does the trick for me: https://github.com/yourlabs
 /django-autocomplete-
 light/blob/master/src/dal_select2/static/autocomplete_light/select2.js#L91-L97

 {{{
 // Remove this block when this is merged upstream:
 // https://github.com/select2/select2/pull/4249
 $(document).on('DOMSubtreeModified', '[data-autocomplete-light-
 function=select2] option', function() {
 $(this).parents('select').next().find(
 '.select2-selection--single .select2-selection__rendered'
 ).text($(this).text());
 });
 }}}


 Just replace `[data-autocomplete-light-function=select2]` by your own
 select tag selector and you should be good to go.

 However, it was meant as a temporary fix even for DAL, so I'm not sure if
 this is of any help to you. I would suggest to add a breakpoint somewhere
 in the code that Kevin's patch adds or changes and hopefully if it's
 executed at all then the solution should be easy to find.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.df11953dabe5888ab682d7085446b877%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  Germano Gabbianelli  |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Johannes Hoppe):

 @James

 yes, but that only works for actual option tags doesn't it? In this case
 the we are only using a JSON API and the dynamic options.
 I haven't looked into that yet. You are a better JS coder than me. I would
 greatly appreciate a patch or suggestion form your side.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1300434addf1ba93a1db6618cc03eba5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  Germano Gabbianelli  |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by James Pic):

 I thought this was supported upstream:
 
https://github.com/select2/select2/commit/ea79a197e0ffe55aa600eed6d18cbd1c804c3176

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.64403872357dab3298fed037118028b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  Germano Gabbianelli  |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


Comment:

 As Florian noted on the PR, "Using the "edit"-icon next to a FK does not
 update the autocomplete widget."

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.128707c32b4e943c6937680bfef23faa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-10-11 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  Germano Gabbianelli  |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Johannes Hoppe):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2db31706db8f7832d2b40345a7766bdb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-08-07 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by codingjoe):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.725ef62687a19a27c1c1c61b7df4aaf8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-06-28 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7e19f31277e015ba1cb9f601c47da773%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-05-13 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Not an extensive review yet, but I left some comments for improvement on
 the PR.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0c319ab2dd093f58b595a5039e6ddaa1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-05-09 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by haras):

 * cc: djangoproject.com@… (removed)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d52dac7525f7bc0474890e36d3e8a9d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-05-09 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by collinanderson):

 yeago: I think codingjoe is saying that his autocomplete is implemented
 differently from raw_id_fields. In his implementation, you need change
 permission on the model the you are currently editing not the related
 object. (Try it out and see if you agree.)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fc4301554f38304c91977be5692383ac%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-05-04 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by yeago):

 @codingjoe I'm not sure that you understood properly what I am saying,
 because I'm not wrong. Go look at a raw_id_fields to a user object then,
 as a user without the user.change permission, try to edit that field. You
 will get a Forbidden error. You need the user.change permission in order
 to pull up the eyeglass required to populate a raw_id_field. The only
 argument is whether this is a feature and not a bug.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9fbd697e0f974609fcd3b3b2a72aae84%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-05-03 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by codingjoe):

 Since there are so many people following this ticket. Please review. From
 where I'm standing this ticket is only shy of a review to be merged into
 1.10. So please, please, please :)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.41a9579a329dcc0cfb658a110ce0e1ea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-05-03 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by codingjoe):

 Replying to [comment:50 yeago]:
 > I'd like to raise something else for discussion...
 >
 > Regarding permission checks, I think matching the way raw_id_fields
 would just be building in unwanted limitations in many cases. Firstly, the
 permission says 'change' where no change is occurring. It just seemed like
 the original implementation was taking a short-cut by using that
 permission (since it was effectively a pop-out changeview).
 >
 > In many cases, someone may want to grant access to a form that has an
 autocomplete list of users but that doesn't mean they want to grant change
 access to their user list. Moreover, we're already granting a permission
 when we are allowing access to the admin form the autocomplete would be
 used on. I'm not sure what case we are covering by granting access to a
 form but not granting access to the autocomplete we explicitly added.

 It's not implemented that way. In fact you need change permission on the
 model the you are currently editing not the related object. e.g. If you
 have access to groups but not to users, the groups m2m autocomplete would
 still work.
 Does that solve the issue for you?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3737d22202b25169baa82010a6185b3d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-05-03 Thread Django

Comment (by yeago):

I'd like to raise something else for discussion...

Regarding permission checks, I think matching the way raw_id_fields would
just be building in unwanted limitations in many cases. Firstly, the
permission says 'change' where no change is occurring. It just seemed like
the original implementation was taking a short-cut by using that
permission (since it was effectively a pop-out changeview).

In many cases, someone may want to grant access to a form that has an
autocomplete list of users but that doesn't mean they want to grant change
access to their user list. Moreover, we're already granting a permission
when we are allowing access to the admin form the autocomplete would be
used on. I'm not sure what case we are covering by granting access to a
form but not granting access to the autocomplete we explicitly added.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.2c469a1056351426a6f2b10842af63c8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-04-30 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e996d854391be641810923af1fd0bf69%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-04-07 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by kevin-brown):

 * cc: kevin-brown (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d5e663e0adee9021250f0dea76728c68%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-04-04 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by airstrike):

 * cc: andreterra@… (removed)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7f806085df9d149e1d46ec8533eb06f6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-04-03 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by eduardocereto):

 * cc: eduardocereto (removed)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.504b7b87d6ee14302ba374104db63376%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-04-02 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  codingjoe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by codingjoe):

 Patch can be found here: https://github.com/django/django/pull/6385
 There are still some implementation details to be discussed.

 - Is this going to replace the RawIdWidget?
 - Do we add a new `autocomplete_fields` attribute?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c6f1c21932204eea2e3422efcb225941%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-04-02 Thread Django

* owner: nobody => codingjoe
* status: new => assigned

Comment:

James and me just discussed selectize.js vs select2.
We agreed that selectize is promising but doesn't have all the features
yet, to be implemented in django without much JS work.
Select2 seems to be the better choices because it supports html data
attributes.

We also discussed how to support `limit_choices_to` for the AJAX result
set. We're probably going to send the field reference to the AJAX endpoint
to figure out the `QuerysetChoices`.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.cc5550502cc99887c91a415cee703bb2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-03-02 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by guettli):

 Just for the records. This comparison grid can help to find a matching
 library: https://www.djangopackages.com/grids/g/auto-complete/

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c0245ccc3dcceb00b01716ac08d93098%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-02-20 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by xliiv):

 * cc: tymoteusz.jankowski@…, tymoteusz.jankowski@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fa11769320a09a32f3eb78786d73b663%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2016-02-04 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by zachborboa):

 * cc: zachborboa@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.88c2f63fec6be2e3a0f6d0b5215653f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2015-11-19 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by jpic):

 * cc: jpic (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4688417b2fc47cc5dffb40286807642e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2015-11-19 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by jpic):

 Since codingjoe told me a couple of days ago that he didn't know about
 django-autocomplete-light (which i maintain) before he took over on
 django-select2, it should be mentioned that django-autocomplete-light also
 has support for generic foreign key which we might want in django admin as
 well (and it supports django-generic-m2m too), supports add-another (even
 outside the admin) and so on. While django-select2 might be lucky enough
 that it gets its features inside contrib.admin, I'm affraid that DAL will
 still require maintainance even in future versions of django. Anyway,
 autocompletion is a really rich subject and I recommend to write the
 documentation before the implementation itself, which use cases do you
 want to support and so on.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a0cdbcc4cb2c17276f03c9496701cd47%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2015-11-10 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by charettes):

 I also think Select2 is one if not the best JavaScript autocomplete
 library around at the moment.

 I've tried alternative such as Chosen and multiple jQuery/Bootstrap
 alternatives in the past and but just like @codingjoe said since version 4
 Select2 is quite solid. It's a great shim that binds correctly to the DOM
 state of the  it's attached to and doesn't require any extra
 manipulation to be marked as disabled, focused, etc

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3d485f0e4aaff745cdfdd1dae6bda56b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2015-11-10 Thread Django

* cc: info@… (added)

Comment:

I'm maintaining `django-select2` and wrote the current version. Let me
share my thoughts on integrating something similar in
`django.conrtib.admin`.

`django-select2` pickels the query and stores it in `django.core.cache`,
to work as a drop in widget. I think this would be a bit over the top. I
would suggest using `app_name`, `model_name` and `field_name` to uniquely
identify the relation.
From that point it should be possible to determine the queryset including
`limit_choices_to` constraints.

I think that `select2` is a great choice, I worked with other libraries,
but since `select2` version 4, I'd recommend it over other solutions.

If you want I could give it a shot. In any case feel free to use code from
`django-select2`.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.2295b0912b1b09491af3b63c302f5cc8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2015-11-09 Thread Django

Comment (by collinanderson):

'''why select2 ?''' It seems like a popular and mature library. I have to
admit I've never used an autocomplete library before so I'm a bit of an
imposter here. :) I'm a little scared that it just got major breaking
changes. What would you use? jQuery UI? Typeahead?

'''changing the default''' It's opt-in. You have to specify
`ajax_autocomplete = ['user']` or maybe you'll have to use
`formfield_overrides`. 3rd-parties could re-use the backend view.

'''vendoring / distributing with django''' I think it's a necessary evil.
I'm a little scared that we went from vendoring just jQuery to including
xregexp and Roboto in just 6 months. The native html5 `datalist` doesn't
seem good enough for the job, and I tried hand-writing autocomplete
javascript in django and quickly realized a dependency is a must.
Currently vendoring is the only option for django, and it's a reasonable
size (slightly smaller than jQuery, 80k vs 84k). I see this as the main
hurdle to getting this merged. We would need to run it by the
DevelopersMailingList for sure.

'''reusing django-select2''' I think the widget code in django-select2 is
much better than what I have, and of course django-select2 actually has
tests. I'd be interested in re-using those. I'm a bit worried about the
backend code. Currently I'm trying to implement this as similar to
raw_id_fields as possible. If we reuse the admin code we get permissions,
to_field, limit_choices_to, search, get_queryset, urls, etc for free. What
would it take to add the missing features to django-select2?

'''next steps''' I mostly made this pull request as a discussion starter
and to show what I think is a good way forward. I don't actually have the
energy right now to push this to completion, but I'd help review pull
requests.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.fae7c4914b460e4b9606a5c456370100%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by RamezIssac):

 * cc: ramezashraf@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b70cda1dfd6d14603ef39ca98612c6fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

Comment (by carljm):

And a third argument for not using a CDN -- we'd be quietly introducing
another point of failure into people's projects.

That said, the "or some build method" idea is probably a better one. It
might be nice if we used bower or something similar to automate pulling in
the outside JS dependencies, instead of manually vendoring them. But it's
also not really a big deal. Vendored dependencies are more easily
auditable, and everyone can figure out how to upgrade them when necessary.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.191a328b2391621a898499491a898477%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

Comment (by aaugustin):

Not using a CDN is a conscious choice.

There are at least two reasons for this:

* privacy (avoid leaking info through the Referer header)
* offline use (download the tar.gz and the docs once and use them for
local development: not everyone on Earth has convenient access to a high-
speed, permanent Internet connection, in doubt we'd rather favor the use
case of the least privileged people)

I'm aware that these are social arguments, not technical ones, and I stand
by them.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.2bd48d90b582dfaaf4ec7db8562abef6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by codingjoe):

 I don't know, this is `django.contrib.admin` not `core` were're talking
 about. I don't see why we should improve it using more javascript
 libraries.
 I don't like the fact tho, that it is being distributed within our repo. I
 would go for a CDN or some build method.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ffcde8e3500b1817599a171a4a1fd8a6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by RamezIssac):

 May i ask why select2 ?!

 Can this patch be done in a way that ease 3rd party integration , (or make
 it optional to use select2) rather then changing the default ?!

 Thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.dff83f4b5ff4938c13b5749700dc91d2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2015-11-07 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by collinanderson):

 patch using select2: https://github.com/django/django/pull/5609

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d3b84539b7f83e204c5fbaf2214b9573%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2015-11-07 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by collinanderson):

 * cc: cmawebsite@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.523eb8dd84b7e2e8aa2cddb8ac97c0e4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2013-01-16 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |  Needs documentation:  1
  admin  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  1
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by 4glitch@…):

 * cc: 4glitch@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2012-09-12 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |  Needs documentation:  1
  admin  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  1
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by guettli):

 * cc: hv@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2012-03-16 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |  Needs documentation:  1
  admin  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  1
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by etienned):

 I just want to let you know that I did a [[https://bitbucket.org/etienned
 /django-autocomplete/overview|fork]] of  tyrion
 [[https://bitbucket.org/tyrion/django-autocomplete|django-autocomplete]]
 that add a little bit more integration with the Django Admin and other
 things:

  - Highlight (put in bold the search term in the results list)
  - Auto Focus (automatically select the first result of the list) need
 jQuery UI >= 1.8.11
  - Zebra (colorize list rows in alternance)
  - Simple Cache (cache each different query)
  - Add button (the green plus to add a new item for a Relation Field)
  - Lookup button (the loupe like in a RawIdField to select from the
 complete list)
  - Multiterms (possibility to have completion on many terms in one field
 separated by a delimiter, for example: a tag field)
  - Distinct result (get only distinct results for all fields excepted
 Relation fields)

 Maybe something there could help doing the integration to the Django
 Admin. [[http://teknozen.net/django-autocomplete_etienned.png|Here's]] a
 screenshot of it in action.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2011-11-22 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  tyrion   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |  Needs documentation:  1
  admin  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  1
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by Thijs Triemstra ):

 * cc: thijs.triemstra@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2011-06-04 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
   Reporter:  tyrion |  Owner:  nobody
   Type:  New| Status:  new
  feature|  Component:  contrib.admin
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  autocomplete,
 Resolution: |  jquery, javascript, widgets, admin
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  1  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-
Changes (by haras):

 * cc: djangoproject.com@… (added)
 * easy:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2011-04-20 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
   Reporter:  tyrion |Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  contrib.admin
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  autocomplete, jquery,
 Resolution: |  javascript, widgets, admin
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  1  |  Needs tests:  0
Patch needs improvement:  1  |
-+-

Comment (by tyrion):

 Replying to [comment:21 airstrike]:
 > could we possibly get a "real" patch for this? 1.3 has been released and
 the bitbucket repo now differs greatly from trunk, plus some of code was
 on dpaste (?) and is now gone, so it's extra hard to dive into the issue
 at the moment.
 >

 If you look at contrib.admin in my django bb repo, you can get an idea of
 how it was implemented.
 In the mean time I used that code to rewrite [https://bitbucket.org/tyrion
 /django-autocomplete django-autocomplete]. Now it's far more customizable
 than the initial patch in this ticket (but it is implemented as a generic
 app, not as a patch to contrib.admin, since I thought that other apps
 could benefit of the code too).

 * Is tying a generic AutocompleteWidget that could be used by other apps
 to contrib.admin a good thing to do?
 * Should we also add the "add another" link?

 If we're satisfied with the current implementation, updating it to the
 trunk shouldn't be too difficult.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2011-04-20 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
   Reporter:  tyrion |Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  contrib.admin
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  autocomplete, jquery,
 Resolution: |  javascript, widgets, admin
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  1  |  Needs tests:  0
Patch needs improvement:  1  |
-+-
Changes (by airstrike):

 * keywords:  autocomplete => autocomplete, jquery, javascript, widgets,
   admin
 * needs_better_patch:  0 => 1
 * version:  1.2 => SVN
 * type:  Uncategorized => New feature
 * cc: andreterra@… (added)


Comment:

 could we possibly get a "real" patch for this? 1.3 has been released and
 the bitbucket repo now differs greatly from trunk, plus some of code was
 on dpaste (?) and is now gone, so it's extra hard to dive into the issue
 at the moment.

 i'd like to help with this and make it "official" as soon as possible. in
 a ~~worst case~~ biggest noob scenario i'll test and write docs!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2011-04-12 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
-+-
   Reporter:  tyrion |Owner:  nobody
   Type:  Uncategorized  |   Status:  new
  Milestone: |Component:  contrib.admin
Version:  1.2| Severity:  Normal
 Resolution: | Keywords:  autocomplete
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  1  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by PF_tschwaerzl):

 * cc: thomas.schwaerzl@… (added)
 * type:   => Uncategorized
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2011-01-16 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by eduardocereto):

 * cc: eduardocereto (added)

Comment:

 is jqueryUI really needed? If that dependency is removed I think this is
 more likely to be accepted. Since jqueryUI is quite large and there's no
 reason to use it at all.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2010-12-19 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by istruble):

 Performed a jslint cleanup of the autocomplete.js and found some trailing
 commas that were breaking things for IE.  IE6 and IE7 now work.  IE8 and
 up should also work.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2010-12-18 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by istruble):

 * cc: istruble (added)

Comment:

 I have added the lookup/search icon, a splash of CSS, a pinch of
 documentation and a sprinkling of testing.

 No automated javascript testing at this point.  Based on manual testing, I
 do know that IE6 and IE7 do not work with the current code.  FF, Safari
 and Chrome seem like they are good to go.  It would be great to hear from
 someone with IE8 or greater what the experience is like.

 Patch file attached to the ticket based on django-trunk within the last
 few days.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by jezdez):

 Ah, ok, that'd make sense indeed, agreed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by sehmasch...@gmail.com):

 I personally wouldn´t make that an option because of coherence (the raw-
 id-field also shows the lookup-icon).
 however, if the icon is there by default and I´m having the option to
 disable it ... why not. the main point is that the lookup-icon is needed.

 just to clarify: with showing the lookup-icon, I don´t mean to show the
 input-field for the object-id as well.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by jezdez):

 Would making that an option per autocomplete field option make sense?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by sehmasch...@gmail.com):

 I´ve just tested the patch and I think it´s great.

 there´s just one minor issue: I´d still show the lookup-icon, because in
 some (rare) cases you won´t find an object without.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by anonymous):

 * cc: sehmasch...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by jezdez):

  * needs_docs:  0 => 1

Comment:

 It would be great if you could attach a diff of the current state to this
 ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2010-11-17 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by anonymous):

 Sure, some documentation should be added.

 A. I am not good with CSS, In my local copy I included the jquery
 lightness theme, with some improvements for contrib.admin...

 B. There are already some "reasonable" defaults, the queryset is required
 only for non fk/m2m fields.
 For fk/m2m fields the queryset if not specified is taken from the field
 (with respect to ``limit_choices_to``).
 The only required key should be "fields" (which maybe should be renamed to
 "search_fields").

 D. I don't know how the javascript could be tested. Do other Admin widgets
 have javascript tests?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2010-11-17 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by robhudson):

 1. I should have caught the above code sample when trying to hook this up,
 but this will need docs in the patch as part of the Django docs before
 this is committed.  That's what I was looking for and referring to.

 2 & 3. Ignore.  Apologies.

 OK, so now that I have it working a few comments...

 A. Looks like it could use a little CSS touch-up work.  I didn't see any
 CSS changes or additions on the bitbucket changes.

 B. I think some reasonable defaults should be considered so not all keys
 of the dict need to be specified.  e.g. if `queryset` isn't specified
 assume an `.all()` query?

 C. Django docs.

 D. Have you considered how we might test this?  It would probably be
 pretty easy to test that the admin hooked up the view that the
 autocomplete calls.  Testing the JS itself would prove a bit tougher but
 jezdez and I have mentioned that we probably need to figure this out
 eventually (QUnit?).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2010-11-17 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by tyrion):

 1. The documentation is at the top of the page. You can't use
 formfield_overrides with autocomplete_fields.
 2. jquery-ui.min.js is loaded in ModelAdmin._media.
 3. You shouldn't get any js error if you use it as documented.

 Let me know if you manage to make it work :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2010-11-15 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by robhudson):

 A couple notes after trying to get this to work on an existing project...

 1. This definitely needs documentation on how to enable these widgets.  I
 took what seemed like the obvious approach and tried adding the
 `MultipleAutocompleteWidget` to an existing m2m field and got an error
 that the `__init__` takes 2 arguments and only 1 was given.  After
 perusing the source I see it takes a settings dict so I passed in an empty
 one that seemed to make it happy.  Personally I think an empty dict should
 be a default along with default settings so the user only has to override
 via:

 {{{
 formfield_overrides = {
 models.ManyToManyField: {'widget': MultipleAutocompleteWidget}
 }
 }}}

 2. It looks like the jquery-ui.min.js isn't loaded anywhere.  I get an
 error in the console that `$.widget` is not a function.  If I add jquery-
 ui to the list of inner class `Media` it moves me past this error to
 another one...

 3. `(void 0) is undefined` on line 15 of jquery-ui.js, which is the `$.ui
 = $.ui || {};` line.  This is about where I stopped.  I tried changing
 jquery-ui to load `django.jQuery` rather than `jQuery` as a test and still
 got the error.  Not sure about this one.

 Hope that feedback helps some.  I'm happy to continue trying and poking at
 this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2010-11-02 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by jezdez):

  * stage:  Unreviewed => Accepted

Comment:

 Marking this accepted after the discussions on IRC and the mailing list.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2010-11-01 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Unreviewed| Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by anonymous):

 * cc: tyrion (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2010-10-07 Thread Django

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Unreviewed| Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by tyrion):

 Now the autocomplete feature can be used with any type of field.[[BR]]
 i.e. (email is an EmailField)
 {{{
 #!python
 class MyModelAdmin(admin.ModelAdmin):
 autocomplete_fields = dict(
 email = dict(
 queryset = User.objects.all(),
 fields = ('^email', '^username'),
 id = 'email',
 value = 'email',
 ),
 )
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Unreviewed| Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by subsume):

 Would it be reasonable to deprecate raw_id_fields in favor of this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Unreviewed| Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by subsume):

 * cc: subsume (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

#14370: Adding support for Autocomplete in contrib.admin
---+
  Reporter:  tyrion| Owner:  nobody  
Status:  new   | Milestone:  
 Component:  django.contrib.admin  |   Version:  1.2 
Resolution:|  Keywords:  autocomplete
 Stage:  Unreviewed| Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by tyrion):

  * needs_better_patch:  => 0
  * has_patch:  0 => 1
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14370: Adding support for Autocomplete in contrib.admin