Re: [Django] #30529: SQLCompiler.as_sql should return parameters as a list (and not as a tuple)

[Django]

#30529: SQLCompiler.as_sql should return parameters as a list (and not as a 
tuple)
-+-
 Reporter:  Tobias Krönke|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tobias Krönke):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Tuples, it is. https://github.com/django/django/pull/11430

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a3e6952ab28eaac13471cea2c621e722%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30529: SQLCompiler.as_sql should return parameters as a list (and not as a tuple)

[Django]

#30529: SQLCompiler.as_sql should return parameters as a list (and not as a 
tuple)
-+-
   Reporter:  Tobias |  Owner:  nobody
  Krönke |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  2.2
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 As wished by Adam (https://github.com/adamchainz/django-
 mysql/issues/50#issuecomment-496665473) I will give it a try and do a PR
 to turn those tuples into lists. Even the method comments in
 https://github.com/django/django/blob/master/django/db/models/sql/compiler.py
 all state:

 Return the SQL string and **list** of parameters.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.76e9e1451a269d2106280bd7045e9a1a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.